From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Sridharan S N <quic_sridsn@quicinc.com>,
agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 2/2] arm64: dts: qcom: ipq9574: enable GPIO based LEDs
Date: Sat, 15 Jul 2023 16:16:54 +0200 [thread overview]
Message-ID: <07176a10-0ef6-291a-cfea-71ec39a38427@linaro.org> (raw)
In-Reply-To: <20230616083238.20690-3-quic_sridsn@quicinc.com>
On 16.06.2023 10:32, Sridharan S N wrote:
> Add support for wlan-2g LED on GPIO 64.
>
> Signed-off-by: Sridharan S N <quic_sridsn@quicinc.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> Changes in V4:
> - Added patch dependency. This change depends on below patch set
> https://lore.kernel.org/linux-arm-msm/20230614085040.22071-2-quic_anusha@quicinc.com/
>
> Changes in V3:
> - Updated patch series title. Mentioned platform in series
> title
>
> Changes in V2:
> - No changes
>
> .../boot/dts/qcom/ipq9574-rdp-common.dtsi | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> index fd5326dc1773..25424cecd834 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> @@ -34,6 +34,18 @@
> debounce-interval = <60>;
> };
> };
> +
> + leds {
> + compatible = "gpio-leds";
> + pinctrl-0 = <&gpio_leds_default>;
> + pinctrl-names = "default";
> +
> + led-0 {
> + gpios = <&tlmm 64 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "phy0tx";
> + default-state = "off";
> + };
> + };
> };
>
> &blsp1_spi0 {
> @@ -137,6 +149,14 @@
> drive-strength = <8>;
> bias-pull-up;
> };
> +
> + gpio_leds_default: gpio-leds-default-state {
> + pins = "gpio64";
> + function = "gpio";
> + drive-strength = <8>;
> + bias-pull-up;
> + };
> +
> };
>
> &xo_board_clk {
next prev parent reply other threads:[~2023-07-15 14:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 8:32 [PATCH V4 0/2] Add support for GPIO based leds and buttons on IPQ5332/9574 devices Sridharan S N
2023-06-16 8:32 ` [PATCH V4 1/2] arm64: dts: qcom: ipq5332: enable GPIO based LEDs and Buttons Sridharan S N
2023-07-15 14:16 ` Konrad Dybcio
2023-06-16 8:32 ` [PATCH V4 2/2] arm64: dts: qcom: ipq9574: enable GPIO based LEDs Sridharan S N
2023-07-15 14:16 ` Konrad Dybcio [this message]
2023-08-14 3:27 ` (subset) [PATCH V4 0/2] Add support for GPIO based leds and buttons on IPQ5332/9574 devices Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07176a10-0ef6-291a-cfea-71ec39a38427@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_sridsn@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).