From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C3E0C001B0 for ; Sat, 15 Jul 2023 14:17:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230177AbjGOORD (ORCPT ); Sat, 15 Jul 2023 10:17:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbjGOORC (ORCPT ); Sat, 15 Jul 2023 10:17:02 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A0E2358D for ; Sat, 15 Jul 2023 07:16:58 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2b6f0508f54so43542621fa.3 for ; Sat, 15 Jul 2023 07:16:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689430616; x=1692022616; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fo1k/DQJKWK7eKDw0jXd1pagArbjShWTxq504FR2pi8=; b=tarcpxCpvBeEgLF6Ei4kqYI55LYNEEIubN3fx9YaHiIMCPy6euOvXmKkGOFeJ3/GG+ LCP1PD2H++CIm2HMtlx5mkcr55kva1rxg6bjpNFRzY/xkLbfFRbckDRKwcgzUhmtUPTi hwVaaqjTmN4TjoBOZuCn+2TVuvpXBa6QRnYMT391I456qSF2Zp7GQHY9YapbJAW1qSJG JmJRThPzrN0lsq14gdkaSnrFJm5vh/07XwAkdnC4uduEuYq149DJOef9qzh5629f/zJz 9MMhvz9hwqkikUp3jwF6Iocjdh8jFsttYQaJ7DFUh2OnXQ3vu6DeIL7WwJJOKv/hV+aB KN3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689430616; x=1692022616; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fo1k/DQJKWK7eKDw0jXd1pagArbjShWTxq504FR2pi8=; b=beiM+Hji+x3CFIBMpKuyK1Q5AhygEG6OwtKAEz4OFAuTUkIY2G5Eb/DqlyY/u8Ktao hmtCAVcCA/0mNaPa3cJsZmusytK7vWtvp/21zTs5Sz/8FUVuBFp98Z9Xd4zeNXXgsKkV etoCOj+aLxf2BHSA4k95Mk60C3Le5am6QzZLra9Ub8tYTBHwceYoPickqz7/iCDU8d1e 1KvO558Gu0RU0liGGhatycpbz8wcPhALla7pJD9AyC9txfw4K/rtuz/mmyPSUT4MZIEt Mk8xfqhOImh2dTJYP1LL+i5TN7sXAhEzW4fHV01bzlFYKOQycHhHNPcQs9SqMhn4CR8Z IlRQ== X-Gm-Message-State: ABy/qLYh/sl4DNbBe7+T7WFcQ5TtctyzB2LeR0BTtB+JTgApY6agj4hR 0vRuCAv4Da+MZBc0m6UghS3GnXDitmIs3c7uNY9yCQ== X-Google-Smtp-Source: APBJJlEptOc8JSycjXgkzv234hYnGER26otvf/5i9LrFcsFMCtV2BuSzRBQLaFKcLo0T1SStc7VYBQ== X-Received: by 2002:a2e:9606:0:b0:2b6:cd6a:17f7 with SMTP id v6-20020a2e9606000000b002b6cd6a17f7mr6087996ljh.20.1689430616427; Sat, 15 Jul 2023 07:16:56 -0700 (PDT) Received: from [192.168.1.101] (abxi167.neoplus.adsl.tpnet.pl. [83.9.2.167]) by smtp.gmail.com with ESMTPSA id r7-20020a2e94c7000000b002b6fe751b6esm2517593ljh.124.2023.07.15.07.16.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Jul 2023 07:16:56 -0700 (PDT) Message-ID: <07176a10-0ef6-291a-cfea-71ec39a38427@linaro.org> Date: Sat, 15 Jul 2023 16:16:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH V4 2/2] arm64: dts: qcom: ipq9574: enable GPIO based LEDs Content-Language: en-US To: Sridharan S N , agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230616083238.20690-1-quic_sridsn@quicinc.com> <20230616083238.20690-3-quic_sridsn@quicinc.com> From: Konrad Dybcio In-Reply-To: <20230616083238.20690-3-quic_sridsn@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16.06.2023 10:32, Sridharan S N wrote: > Add support for wlan-2g LED on GPIO 64. > > Signed-off-by: Sridharan S N > --- Reviewed-by: Konrad Dybcio Konrad > Changes in V4: > - Added patch dependency. This change depends on below patch set > https://lore.kernel.org/linux-arm-msm/20230614085040.22071-2-quic_anusha@quicinc.com/ > > Changes in V3: > - Updated patch series title. Mentioned platform in series > title > > Changes in V2: > - No changes > > .../boot/dts/qcom/ipq9574-rdp-common.dtsi | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi > index fd5326dc1773..25424cecd834 100644 > --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi > @@ -34,6 +34,18 @@ > debounce-interval = <60>; > }; > }; > + > + leds { > + compatible = "gpio-leds"; > + pinctrl-0 = <&gpio_leds_default>; > + pinctrl-names = "default"; > + > + led-0 { > + gpios = <&tlmm 64 GPIO_ACTIVE_LOW>; > + linux,default-trigger = "phy0tx"; > + default-state = "off"; > + }; > + }; > }; > > &blsp1_spi0 { > @@ -137,6 +149,14 @@ > drive-strength = <8>; > bias-pull-up; > }; > + > + gpio_leds_default: gpio-leds-default-state { > + pins = "gpio64"; > + function = "gpio"; > + drive-strength = <8>; > + bias-pull-up; > + }; > + > }; > > &xo_board_clk {