* [PATCH V4 1/2] arm64: dts: qcom: ipq5332: enable GPIO based LEDs and Buttons
2023-06-16 8:32 [PATCH V4 0/2] Add support for GPIO based leds and buttons on IPQ5332/9574 devices Sridharan S N
@ 2023-06-16 8:32 ` Sridharan S N
2023-07-15 14:16 ` Konrad Dybcio
2023-06-16 8:32 ` [PATCH V4 2/2] arm64: dts: qcom: ipq9574: enable GPIO based LEDs Sridharan S N
2023-08-14 3:27 ` (subset) [PATCH V4 0/2] Add support for GPIO based leds and buttons on IPQ5332/9574 devices Bjorn Andersson
2 siblings, 1 reply; 6+ messages in thread
From: Sridharan S N @ 2023-06-16 8:32 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linux-arm-msm, devicetree, linux-kernel
Cc: Sridharan S N
Add support for wlan-2g LED on GPIO 36 and wps buttons on GPIO 35.
Signed-off-by: Sridharan S N <quic_sridsn@quicinc.com>
---
Changes in V4:
- Added patch dependency. This change depends on below patch set
https://lore.kernel.org/linux-arm-msm/20230615090001.10970-1-quic_sridsn@quicinc.com/
Changes in V3:
- Updated patch series title. Mentioned platform in series
title
Changes in V2:
- Used the hypen in node name instead of underscore
- Dropped the status property
.../boot/dts/qcom/ipq5332-rdp-common.dtsi | 39 +++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi
index 97dc0e5c15f0..a8671a4ac2e4 100644
--- a/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi
@@ -19,6 +19,31 @@
chosen {
stdout-path = "serial0";
};
+
+ gpio-keys {
+ compatible = "gpio-keys";
+ pinctrl-0 = <&gpio_keys_default>;
+ pinctrl-names = "default";
+
+ button-wps {
+ label = "wps";
+ linux,code = <KEY_WPS_BUTTON>;
+ gpios = <&tlmm 35 GPIO_ACTIVE_LOW>;
+ debounce-interval = <60>;
+ };
+ };
+
+ leds {
+ compatible = "gpio-leds";
+ pinctrl-0 = <&gpio_leds_default>;
+ pinctrl-names = "default";
+
+ led-0 {
+ gpios = <&tlmm 36 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "phy0tx";
+ default-state = "off";
+ };
+ };
};
&blsp1_i2c1 {
@@ -52,6 +77,20 @@
/* PINCTRL */
&tlmm {
+ gpio_keys_default: gpio-keys-default-state {
+ pins = "gpio35";
+ function = "gpio";
+ drive-strength = <8>;
+ bias-pull-up;
+ };
+
+ gpio_leds_default: gpio-leds-default-state {
+ pins = "gpio36";
+ function = "gpio";
+ drive-strength = <8>;
+ bias-pull-down;
+ };
+
i2c_1_pins: i2c-1-state {
pins = "gpio29", "gpio30";
function = "blsp1_i2c0";
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH V4 1/2] arm64: dts: qcom: ipq5332: enable GPIO based LEDs and Buttons
2023-06-16 8:32 ` [PATCH V4 1/2] arm64: dts: qcom: ipq5332: enable GPIO based LEDs and Buttons Sridharan S N
@ 2023-07-15 14:16 ` Konrad Dybcio
0 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2023-07-15 14:16 UTC (permalink / raw)
To: Sridharan S N, agross, andersson, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linux-arm-msm, devicetree, linux-kernel
On 16.06.2023 10:32, Sridharan S N wrote:
> Add support for wlan-2g LED on GPIO 36 and wps buttons on GPIO 35.
>
> Signed-off-by: Sridharan S N <quic_sridsn@quicinc.com>
> ---
> Changes in V4:
> - Added patch dependency. This change depends on below patch set
> https://lore.kernel.org/linux-arm-msm/20230615090001.10970-1-quic_sridsn@quicinc.com/
>
> Changes in V3:
> - Updated patch series title. Mentioned platform in series
> title
>
> Changes in V2:
> - Used the hypen in node name instead of underscore
> - Dropped the status property
>
> .../boot/dts/qcom/ipq5332-rdp-common.dtsi | 39 +++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi
> index 97dc0e5c15f0..a8671a4ac2e4 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi
> @@ -19,6 +19,31 @@
> chosen {
> stdout-path = "serial0";
> };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> + pinctrl-0 = <&gpio_keys_default>;
> + pinctrl-names = "default";
> +
> + button-wps {
> + label = "wps";
> + linux,code = <KEY_WPS_BUTTON>;
> + gpios = <&tlmm 35 GPIO_ACTIVE_LOW>;
> + debounce-interval = <60>;
That's purely your choice, but don't you wanna make it wakeup-capable?
Otherwise:
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> + };
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> + pinctrl-0 = <&gpio_leds_default>;
> + pinctrl-names = "default";
> +
> + led-0 {
> + gpios = <&tlmm 36 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "phy0tx";
> + default-state = "off";
> + };
> + };
> };
>
> &blsp1_i2c1 {
> @@ -52,6 +77,20 @@
> /* PINCTRL */
>
> &tlmm {
> + gpio_keys_default: gpio-keys-default-state {
> + pins = "gpio35";
> + function = "gpio";
> + drive-strength = <8>;
> + bias-pull-up;
> + };
> +
> + gpio_leds_default: gpio-leds-default-state {
> + pins = "gpio36";
> + function = "gpio";
> + drive-strength = <8>;
> + bias-pull-down;
> + };
> +
> i2c_1_pins: i2c-1-state {
> pins = "gpio29", "gpio30";
> function = "blsp1_i2c0";
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V4 2/2] arm64: dts: qcom: ipq9574: enable GPIO based LEDs
2023-06-16 8:32 [PATCH V4 0/2] Add support for GPIO based leds and buttons on IPQ5332/9574 devices Sridharan S N
2023-06-16 8:32 ` [PATCH V4 1/2] arm64: dts: qcom: ipq5332: enable GPIO based LEDs and Buttons Sridharan S N
@ 2023-06-16 8:32 ` Sridharan S N
2023-07-15 14:16 ` Konrad Dybcio
2023-08-14 3:27 ` (subset) [PATCH V4 0/2] Add support for GPIO based leds and buttons on IPQ5332/9574 devices Bjorn Andersson
2 siblings, 1 reply; 6+ messages in thread
From: Sridharan S N @ 2023-06-16 8:32 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linux-arm-msm, devicetree, linux-kernel
Cc: Sridharan S N
Add support for wlan-2g LED on GPIO 64.
Signed-off-by: Sridharan S N <quic_sridsn@quicinc.com>
---
Changes in V4:
- Added patch dependency. This change depends on below patch set
https://lore.kernel.org/linux-arm-msm/20230614085040.22071-2-quic_anusha@quicinc.com/
Changes in V3:
- Updated patch series title. Mentioned platform in series
title
Changes in V2:
- No changes
.../boot/dts/qcom/ipq9574-rdp-common.dtsi | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
index fd5326dc1773..25424cecd834 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
@@ -34,6 +34,18 @@
debounce-interval = <60>;
};
};
+
+ leds {
+ compatible = "gpio-leds";
+ pinctrl-0 = <&gpio_leds_default>;
+ pinctrl-names = "default";
+
+ led-0 {
+ gpios = <&tlmm 64 GPIO_ACTIVE_LOW>;
+ linux,default-trigger = "phy0tx";
+ default-state = "off";
+ };
+ };
};
&blsp1_spi0 {
@@ -137,6 +149,14 @@
drive-strength = <8>;
bias-pull-up;
};
+
+ gpio_leds_default: gpio-leds-default-state {
+ pins = "gpio64";
+ function = "gpio";
+ drive-strength = <8>;
+ bias-pull-up;
+ };
+
};
&xo_board_clk {
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH V4 2/2] arm64: dts: qcom: ipq9574: enable GPIO based LEDs
2023-06-16 8:32 ` [PATCH V4 2/2] arm64: dts: qcom: ipq9574: enable GPIO based LEDs Sridharan S N
@ 2023-07-15 14:16 ` Konrad Dybcio
0 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2023-07-15 14:16 UTC (permalink / raw)
To: Sridharan S N, agross, andersson, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linux-arm-msm, devicetree, linux-kernel
On 16.06.2023 10:32, Sridharan S N wrote:
> Add support for wlan-2g LED on GPIO 64.
>
> Signed-off-by: Sridharan S N <quic_sridsn@quicinc.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> Changes in V4:
> - Added patch dependency. This change depends on below patch set
> https://lore.kernel.org/linux-arm-msm/20230614085040.22071-2-quic_anusha@quicinc.com/
>
> Changes in V3:
> - Updated patch series title. Mentioned platform in series
> title
>
> Changes in V2:
> - No changes
>
> .../boot/dts/qcom/ipq9574-rdp-common.dtsi | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> index fd5326dc1773..25424cecd834 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi
> @@ -34,6 +34,18 @@
> debounce-interval = <60>;
> };
> };
> +
> + leds {
> + compatible = "gpio-leds";
> + pinctrl-0 = <&gpio_leds_default>;
> + pinctrl-names = "default";
> +
> + led-0 {
> + gpios = <&tlmm 64 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "phy0tx";
> + default-state = "off";
> + };
> + };
> };
>
> &blsp1_spi0 {
> @@ -137,6 +149,14 @@
> drive-strength = <8>;
> bias-pull-up;
> };
> +
> + gpio_leds_default: gpio-leds-default-state {
> + pins = "gpio64";
> + function = "gpio";
> + drive-strength = <8>;
> + bias-pull-up;
> + };
> +
> };
>
> &xo_board_clk {
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (subset) [PATCH V4 0/2] Add support for GPIO based leds and buttons on IPQ5332/9574 devices
2023-06-16 8:32 [PATCH V4 0/2] Add support for GPIO based leds and buttons on IPQ5332/9574 devices Sridharan S N
2023-06-16 8:32 ` [PATCH V4 1/2] arm64: dts: qcom: ipq5332: enable GPIO based LEDs and Buttons Sridharan S N
2023-06-16 8:32 ` [PATCH V4 2/2] arm64: dts: qcom: ipq9574: enable GPIO based LEDs Sridharan S N
@ 2023-08-14 3:27 ` Bjorn Andersson
2 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2023-08-14 3:27 UTC (permalink / raw)
To: agross, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, conor+dt,
linux-arm-msm, devicetree, linux-kernel, Sridharan S N
On Fri, 16 Jun 2023 14:02:36 +0530, Sridharan S N wrote:
> Add support for wlan-2g led and wps button available on IPQ5332 and
> IPQ9574
>
> Changes since V1:
> - Updated patch series title. Mentioned platform in series
> title
>
> [...]
Applied, thanks!
[1/2] arm64: dts: qcom: ipq5332: enable GPIO based LEDs and Buttons
commit: 0354e2d4d203bcffb61d671265f9f0bc52b244ff
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread