From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2CF429A9FE for ; Tue, 25 Nov 2025 06:42:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764052980; cv=none; b=GIwhr6TJ/dr9KmbBxavgltRBAnGfK+sY4xAi4RjcIxqvDCsthPCwDWqhTknKChu4gCTecAFOLoHTlffr8VFB6qhHRCFvdA16c5pqMeMomlyIA+KzXh2LmMjQFFBT4JBRH/x4M25gnD+6AjtlSZSn6lGkPygyGPcaeXkMhVTHPNo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764052980; c=relaxed/simple; bh=bMVM6nwiRnBB3ygequtCXeKaSYZ8JKMr74Alu8bdTfM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PE6fv+EmPLjdeAcb8yp0oCiV+VZNtkBoSkz1bgHFACNOzeOgsnxrfnr+JaRPWks2X0ys/soKOrPz/5Cs58ZLkwo8Pj1ggFRgcw8j1sRFrhi6EX92zPqFxMIYdE+8R5R9Mom2Yr1p25XSsjpsW7VCCmaynBFN6f6d7lwpkiGdMn8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PXM4Oi51; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PXM4Oi51" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-37a415a22ecso42865811fa.0 for ; Mon, 24 Nov 2025 22:42:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764052975; x=1764657775; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oDwgPrbqR3WPQpKO2RN5Ep6D/2LO+UnqChlfZRK6eKg=; b=PXM4Oi51/FPSyFM+6n3W1MkZ8lRcQmQDf5xTo4W0x/8klPd2i17BG+PpU/k99qVrEd 8FhrIhgvL/oMBEixwIderB1Ww0ZYJApyL96SU76Usb+75ViTYcgBbNIJmkdB2sqglt39 EHyCtOP7rzTY2LMk/dKOF1maizgzB3exwy6gBuLAE/kfnFoF1jwJzDmiGDfDXLV4J1hr fHJIyFU4x2tpUq0fiJRIhox+RXrqjVWTwCFxxGlJtK13wa3x8sCRrXjhS17HwHoQn1a3 abGsydVqkqA5KRHnBiiW/E6itTeHdADHv/d7USbpF/FQoDWy/pxy9oSZYL14nXXU1RoR xnBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764052975; x=1764657775; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oDwgPrbqR3WPQpKO2RN5Ep6D/2LO+UnqChlfZRK6eKg=; b=cmtakuhqAVQValqVJ7YXw7g7yrwFYJd57+rsB+DGYODhSH1ysPTiGSW2sFiVkninmL 7dxVhLZgZ/vNOvzWy0NY6urrgAzUsmoNuGB0gXiwMgRQitqW/L27jqU13z6Ion5CpcIF JlH7zMd7GFmsuy4LotBkeSPIPymYxdTCKsotqL0T4g3IPTzvXXxr/cT3uwn1c2SVJbyo UlKijq2sta1U6y9LKakGq2zUHd5d5D/Dk7Me9g3Yq76IFAXtu15sw9SlDmdzu7hBPxdX HtqE4GtBRskUnzRBirw8HWH0F+RsaN/G8zklAnQL1EvX1VY2MUS7bNYI+ciIJy2WBr6D xZQQ== X-Forwarded-Encrypted: i=1; AJvYcCW6WDIUDk1RFwNnPgvMfIrV/BSNIzCyc0vxsb2Uze7P1nWtG/XxViffu1/lNwmWhli0g+k+LfeBBG9B@vger.kernel.org X-Gm-Message-State: AOJu0YyRnFM8lIS7XIlOM8B4XH48HDxPX2QOCt0Djst9EyNfih8Ai050 KgDGdbgs5HRwMu886w3KxANK1ai8eGeUZmVnLttmLdk9QO8WXr7g9cGE X-Gm-Gg: ASbGncvyfe0HToaIfQKF2f/SqAcputABQEbiDh7kFbRTqHzpMa4GE/CAMzkfiaKTIyo Pew2xTvez+J6j0YhcaJGZZQQQD6UuflOcgFijrNUWwDVtF6rDoZYQ6Px1LNDzuZ+T/lVpQp0ikb FeU1ZNQ/fev/UdoaHzpgWOgUOt1VphoD8LyLKNf6Ox0uMhCdh9PssVPD2F+y0HBTlI0557qQ5D/ xd+5fhZRJP7DZQGBQNvjzsuxPPmF/PHD4/SqtJBZE0MrwAtx+12WSUf4PuQh0HqrqF2fV+6ilDC d49Rbd6C/OvQJitx30+cs8HPHXyi9guEgVnRIDncbv/t9/HY+BWcWGrjJKLOkG4dD7aouvLWRKV u8hVgBXhzWKq2yOcXsGHyQUrXKzY8fl6gb8FDsqnU4yE0wbxK+/LEe0ivyDjODqUBzRWzlKCLmh Q238REbXioFPpiYDfSzBMw6p7VMDIib9fX1k9NzG35XfemJVYx7kHsl6T2BFHonrOulyw8 X-Google-Smtp-Source: AGHT+IGn4O/LdPwrRfIUFu/wkzsPRHVD6YOLdNx92wJy+rnsWi85zUpEuMS1eU2wO8cl4kItz2sVag== X-Received: by 2002:a2e:a805:0:b0:37a:3910:6c77 with SMTP id 38308e7fff4ca-37cc82af4a6mr55071391fa.5.1764052974535; Mon, 24 Nov 2025 22:42:54 -0800 (PST) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-37cc6b59ff5sm31356131fa.15.2025.11.24.22.42.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Nov 2025 22:42:53 -0800 (PST) Message-ID: <072dde7c-a53c-4525-83ac-57ea38edc0b5@gmail.com> Date: Tue, 25 Nov 2025 08:42:50 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 01/29] Revert "treewide: Fix probing of devices in DT overlays" To: Rob Herring , Kalle Niemi Cc: Herve Codina , Andrew Lunn , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Michael Turquette , Stephen Boyd , Andi Shyti , Wolfram Sang , Peter Rosin , Arnd Bergmann , Saravana Kannan , Bjorn Helgaas , Charles Keepax , Richard Fitzgerald , David Rhodes , Linus Walleij , Ulf Hansson , Mark Brown , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Len Brown , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Geert Uytterhoeven , Wolfram Sang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, linux-spi@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, Allan Nielsen , Horatiu Vultur , Steen Hegelund , Luca Ceresoli , Thomas Petazzoni References: <20251015071420.1173068-1-herve.codina@bootlin.com> <20251015071420.1173068-2-herve.codina@bootlin.com> <5cf2a12a-7c66-4622-b4a9-14896c6df005@gmail.com> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 24/11/2025 19:01, Rob Herring wrote: > On Mon, Nov 24, 2025 at 10:44 AM Kalle Niemi wrote: >> >> >> On 11/24/25 16:53, Rob Herring wrote: >>> On Mon, Nov 24, 2025 at 8:48 AM Kalle Niemi wrote: >>>> On 10/15/25 10:13, Herve Codina wrote: >>>>> From: Saravana Kannan >>>>> >>>>> This reverts commit 1a50d9403fb90cbe4dea0ec9fd0351d2ecbd8924. >>>>> >>>>> While the commit fixed fw_devlink overlay handling for one case, it >>>>> broke it for another case. So revert it and redo the fix in a separate >>>>> patch. >>>>> >>>>> Fixes: 1a50d9403fb9 ("treewide: Fix probing of devices in DT overlays") >>>>> Reported-by: Herve Codina >>>>> Closes: https://lore.kernel.org/lkml/CAMuHMdXEnSD4rRJ-o90x4OprUacN_rJgyo8x6=9F9rZ+-KzjOg@mail.gmail.com/ >>>>> Closes: https://lore.kernel.org/all/20240221095137.616d2aaa@bootlin.com/ >>>>> Closes: https://lore.kernel.org/lkml/20240312151835.29ef62a0@bootlin.com/ >>>>> Signed-off-by: Saravana Kannan >>>>> Link: https://lore.kernel.org/lkml/20240411235623.1260061-2-saravanak@google.com/ >>>>> Signed-off-by: Herve Codina >>>>> Acked-by: Mark Brown >>>>> --- >>>>> drivers/bus/imx-weim.c | 6 ------ >>>>> drivers/i2c/i2c-core-of.c | 5 ----- >>>>> drivers/of/dynamic.c | 1 - >>>>> drivers/of/platform.c | 5 ----- >>>>> drivers/spi/spi.c | 5 ----- >>>>> 5 files changed, 22 deletions(-) >>>>> >>>>> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c >>>>> index 83d623d97f5f..87070155b057 100644 >>>>> --- a/drivers/bus/imx-weim.c >>>>> +++ b/drivers/bus/imx-weim.c >>>>> @@ -327,12 +327,6 @@ static int of_weim_notify(struct notifier_block *nb, unsigned long action, >>>>> "Failed to setup timing for '%pOF'\n", rd->dn); >>>>> >>>>> if (!of_node_check_flag(rd->dn, OF_POPULATED)) { >>>>> - /* >>>>> - * Clear the flag before adding the device so that >>>>> - * fw_devlink doesn't skip adding consumers to this >>>>> - * device. >>>>> - */ >>>>> - rd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE; >>>>> if (!of_platform_device_create(rd->dn, NULL, &pdev->dev)) { >>>>> dev_err(&pdev->dev, >>>>> "Failed to create child device '%pOF'\n", >>>>> diff --git a/drivers/i2c/i2c-core-of.c b/drivers/i2c/i2c-core-of.c >>>>> index eb7fb202355f..30b48a428c0b 100644 >>>>> --- a/drivers/i2c/i2c-core-of.c >>>>> +++ b/drivers/i2c/i2c-core-of.c >>>>> @@ -176,11 +176,6 @@ static int of_i2c_notify(struct notifier_block *nb, unsigned long action, >>>>> return NOTIFY_OK; >>>>> } >>>>> >>>>> - /* >>>>> - * Clear the flag before adding the device so that fw_devlink >>>>> - * doesn't skip adding consumers to this device. >>>>> - */ >>>>> - rd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE; >>>>> client = of_i2c_register_device(adap, rd->dn); >>>>> if (IS_ERR(client)) { >>>>> dev_err(&adap->dev, "failed to create client for '%pOF'\n", >>>>> diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c >>>>> index 2eaaddcb0ec4..b5be7484fb36 100644 >>>>> --- a/drivers/of/dynamic.c >>>>> +++ b/drivers/of/dynamic.c >>>>> @@ -225,7 +225,6 @@ static void __of_attach_node(struct device_node *np) >>>>> np->sibling = np->parent->child; >>>>> np->parent->child = np; >>>>> of_node_clear_flag(np, OF_DETACHED); >>>>> - np->fwnode.flags |= FWNODE_FLAG_NOT_DEVICE; >>>>> >>>>> raw_spin_unlock_irqrestore(&devtree_lock, flags); >>>>> >>>>> diff --git a/drivers/of/platform.c b/drivers/of/platform.c >>>>> index f77cb19973a5..ef9445ba168b 100644 >>>>> --- a/drivers/of/platform.c >>>>> +++ b/drivers/of/platform.c >>>>> @@ -739,11 +739,6 @@ static int of_platform_notify(struct notifier_block *nb, >>>>> if (of_node_check_flag(rd->dn, OF_POPULATED)) >>>>> return NOTIFY_OK; >>>>> >>>>> - /* >>>>> - * Clear the flag before adding the device so that fw_devlink >>>>> - * doesn't skip adding consumers to this device. >>>>> - */ >>>>> - rd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE; >>>>> /* pdev_parent may be NULL when no bus platform device */ >>>>> pdev_parent = of_find_device_by_node(parent); >>>>> pdev = of_platform_device_create(rd->dn, NULL, >>>>> diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c >>>>> index 2e0647a06890..b22944a207c9 100644 >>>>> --- a/drivers/spi/spi.c >>>>> +++ b/drivers/spi/spi.c >>>>> @@ -4791,11 +4791,6 @@ static int of_spi_notify(struct notifier_block *nb, unsigned long action, >>>>> return NOTIFY_OK; >>>>> } >>>>> >>>>> - /* >>>>> - * Clear the flag before adding the device so that fw_devlink >>>>> - * doesn't skip adding consumers to this device. >>>>> - */ >>>>> - rd->dn->fwnode.flags &= ~FWNODE_FLAG_NOT_DEVICE; >>>>> spi = of_register_spi_device(ctlr, rd->dn); >>>>> put_device(&ctlr->dev); >>>>> >>>> Sorry, some of you will receive this message now for second time. First >>>> message was sent to older series of patches. >>>> - >>>> >>>> Hello, >>>> >>>> Test system testing drivers for ROHM ICs bisected this commit to cause >>>> BD71847 drivers probe to not be called. >>> This driver (and overlay support) is in linux-next or something out of >>> tree on top of linux-next? >>> >>> Rob >> >> Yes the driver is in mainline linux: /drivers/mfd/rohm-bd718x7.c > > I don't see any support to apply overlays in that driver. Ah. Sorry for the confusion peeps. I asked Kalle to report this without proper consideration. 100% my bad. While the bd718x7 drive indeed is mainline (and tested), the actual 'glue-code' doing the overlay is part of the downstream test infrastructure. So yes, this is not a bug in upstream kernel - this falls in the category of an upstream change causing downstream things to break. So, feel free to say: "Go fix your code" :) Now that this is sorted, if someone is still interested in helping us to get our upstream drivers tested - the downstream piece is just taking the compiled device-tree overlay at runtime (via bin-attribute file), and applying it using the of_overlay_fdt_apply(). The approach is working for our testing purposes when the device is added to I2C/SPI node which is already enabled. However, in case where we have the I2C disabled, and enable it in the same overlay where we add the new device - then the new device does not get probed. I would be really grateful if someone had a pointer for us. Yours, -- Matti -- --- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~