devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@denx.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Fabio Estevam <festevam@gmail.com>,
	neil.armstrong@linaro.org, marex@denx.de, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	jagan@amarulasolutions.com, inki.dae@samsung.com
Subject: Re: [PATCH v2] dt-bindings: bridge: Convert Samsung MIPI DSIM bridge to yaml
Date: Mon, 03 Apr 2023 10:25:45 -0300	[thread overview]
Message-ID: <074183d480cf18948aacd98be60308f8@denx.de> (raw)
In-Reply-To: <8f7f925f-638d-737c-bf47-2a66ce0eec59@linaro.org>

Hi Krzysztof,

On 03/04/2023 09:49, Krzysztof Kozlowski wrote:

>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>> Signed-off-by: Fabio Estevam <festevam@denx.de>
>> ---
>> Changes since v1:
>> - Added samsung,mipi-dsim.yaml entry to MAINTAINERS file (Jagan)
>> - Added Marek Szyprowski entry to the samsung,mipi-dsim.yaml 
>> maintainers section (Jagan)
>> - Mention that i.MX8M Plus is also supported (Marek)
>> - Remove endpoint@0 description as it only has one endpoint (Marek)
> 
> Where is the changelog from original submission? How your v1 differs
> form it? Or did you just ignore all the feedback?

I'm sorry, but it was not my intention to ignore any feedback.

Which feedback are you referring to specifically?

Some more context: last week I sent a patch adding a new property
for exynos_dsim.txt and you asked me to convert it to yaml first:

https://lore.kernel.org/all/ff66c8b9-c7f7-1eb2-c730-4812b7ff6824@linaro.org/#t

Jagan pointed out an earlier submission he did in 2021:

https://lore.kernel.org/all/20210704090230.26489-9-jagan@amarulasolutions.com/

That was my starting point.

>> +  phys:
>> +    maxItems: 1
>> +    description: phandle to the phy module representing the DPHY
> 
> OK, so you did ignore the feedback.

Not intentionally.

> NAK, go through the feedback and implement it.

Just found this feedback from Rob about Jagan's initial submission:

https://lore.kernel.org/all/20210712151322.GA1931925@robh.at.kernel.org/

I can send a new version that takes Rob's feedback into account.

Were there any further versions/feedback that were submitted? Can't find 
them on lore.

In another reply, you mention that this should be v13. I could not find 
previous versions of the yaml submission.

Please advise.

Thanks,

Fabio Estevam

  reply	other threads:[~2023-04-03 13:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-03 12:44 [PATCH v2] dt-bindings: bridge: Convert Samsung MIPI DSIM bridge to yaml Fabio Estevam
2023-04-03 12:49 ` Krzysztof Kozlowski
2023-04-03 13:25   ` Fabio Estevam [this message]
2023-04-03 13:43     ` Krzysztof Kozlowski
2023-04-03 14:36       ` Jagan Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=074183d480cf18948aacd98be60308f8@denx.de \
    --to=festevam@denx.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=festevam@gmail.com \
    --cc=inki.dae@samsung.com \
    --cc=jagan@amarulasolutions.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=marex@denx.de \
    --cc=neil.armstrong@linaro.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).