* [RESEND PATCH v2 0/6] Add display support on the stm32f746-disco board
@ 2023-06-07 6:31 Dario Binacchi
2023-06-07 6:31 ` [RESEND PATCH v2 1/6] ARM: dts: stm32: add ltdc support on stm32f746 MCU Dario Binacchi
` (4 more replies)
0 siblings, 5 replies; 13+ messages in thread
From: Dario Binacchi @ 2023-06-07 6:31 UTC (permalink / raw)
To: linux-kernel
Cc: Raphael Gallais-Pou, linux-arm-kernel, dri-devel, Philippe Cornu,
Amarula patchwork, Maxime Coquelin, michael, linux-stm32,
Alexandre Torgue, Dario Binacchi, Conor Dooley, Daniel Vetter,
David Airlie, Krzysztof Kozlowski, Neil Armstrong, Rob Herring,
Sam Ravnborg, Thierry Reding, Yannick Fertre, devicetree
The series adds support for the display on the stm32f746-disco board,
along with a generic patch that adds the "bpp" parameter to the stm-drm
module. The intention is to allow users to size, within certain limits,
the memory footprint required by the framebuffer.
Changes in v2:
- Add 'Acked-by' tag of Conor Dooley.
- Fix build warning reported by kernel test robot.
- Add 'Reported-by' tag of kernel test robot.
Dario Binacchi (6):
ARM: dts: stm32: add ltdc support on stm32f746 MCU
ARM: dts: stm32: add pin map for LTDC on stm32f7
ARM: dts: stm32: support display on stm32f746-disco board
dt-bindings: display: simple: add Rocktech RK043FN48H
drm/panel: simple: add support for Rocktech RK043FN48H panel
drm/stm: add an option to change FB bpp
.../bindings/display/panel/panel-simple.yaml | 2 +
arch/arm/boot/dts/stm32f7-pinctrl.dtsi | 35 +++++++++++++
arch/arm/boot/dts/stm32f746-disco.dts | 51 +++++++++++++++++++
arch/arm/boot/dts/stm32f746.dtsi | 10 ++++
drivers/gpu/drm/panel/panel-simple.c | 29 +++++++++++
drivers/gpu/drm/stm/drv.c | 8 ++-
6 files changed, 134 insertions(+), 1 deletion(-)
--
2.32.0
^ permalink raw reply [flat|nested] 13+ messages in thread* [RESEND PATCH v2 1/6] ARM: dts: stm32: add ltdc support on stm32f746 MCU 2023-06-07 6:31 [RESEND PATCH v2 0/6] Add display support on the stm32f746-disco board Dario Binacchi @ 2023-06-07 6:31 ` Dario Binacchi 2023-06-07 6:31 ` [RESEND PATCH v2 2/6] ARM: dts: stm32: add pin map for LTDC on stm32f7 Dario Binacchi ` (3 subsequent siblings) 4 siblings, 0 replies; 13+ messages in thread From: Dario Binacchi @ 2023-06-07 6:31 UTC (permalink / raw) To: linux-kernel Cc: Raphael Gallais-Pou, linux-arm-kernel, dri-devel, Philippe Cornu, Amarula patchwork, Maxime Coquelin, michael, linux-stm32, Alexandre Torgue, Dario Binacchi, Conor Dooley, Krzysztof Kozlowski, Rob Herring, devicetree Add LTDC (Lcd-tft Display Controller) support. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> --- (no changes since v1) arch/arm/boot/dts/stm32f746.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/stm32f746.dtsi b/arch/arm/boot/dts/stm32f746.dtsi index dc868e6da40e..9c4ba0b7f239 100644 --- a/arch/arm/boot/dts/stm32f746.dtsi +++ b/arch/arm/boot/dts/stm32f746.dtsi @@ -507,6 +507,16 @@ pwm { }; }; + ltdc: display-controller@40016800 { + compatible = "st,stm32-ltdc"; + reg = <0x40016800 0x200>; + interrupts = <88>, <89>; + resets = <&rcc STM32F7_APB2_RESET(LTDC)>; + clocks = <&rcc 1 CLK_LCD>; + clock-names = "lcd"; + status = "disabled"; + }; + pwrcfg: power-config@40007000 { compatible = "st,stm32-power-config", "syscon"; reg = <0x40007000 0x400>; -- 2.32.0 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [RESEND PATCH v2 2/6] ARM: dts: stm32: add pin map for LTDC on stm32f7 2023-06-07 6:31 [RESEND PATCH v2 0/6] Add display support on the stm32f746-disco board Dario Binacchi 2023-06-07 6:31 ` [RESEND PATCH v2 1/6] ARM: dts: stm32: add ltdc support on stm32f746 MCU Dario Binacchi @ 2023-06-07 6:31 ` Dario Binacchi 2023-06-08 12:42 ` Alexandre TORGUE 2023-06-07 6:31 ` [RESEND PATCH v2 3/6] ARM: dts: stm32: support display on stm32f746-disco board Dario Binacchi ` (2 subsequent siblings) 4 siblings, 1 reply; 13+ messages in thread From: Dario Binacchi @ 2023-06-07 6:31 UTC (permalink / raw) To: linux-kernel Cc: Raphael Gallais-Pou, linux-arm-kernel, dri-devel, Philippe Cornu, Amarula patchwork, Maxime Coquelin, michael, linux-stm32, Alexandre Torgue, Dario Binacchi, Conor Dooley, Krzysztof Kozlowski, Rob Herring, devicetree Add pin configurations for using LTDC (LCD-tft Display Controller) on stm32f746-disco board. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> --- (no changes since v1) arch/arm/boot/dts/stm32f7-pinctrl.dtsi | 35 ++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/arch/arm/boot/dts/stm32f7-pinctrl.dtsi b/arch/arm/boot/dts/stm32f7-pinctrl.dtsi index 9f65403295ca..f3f90b9bcd61 100644 --- a/arch/arm/boot/dts/stm32f7-pinctrl.dtsi +++ b/arch/arm/boot/dts/stm32f7-pinctrl.dtsi @@ -365,6 +365,41 @@ pins2 { bias-pull-up; }; }; + + + ltdc_pins_a: ltdc-pins-a-0 { + pins { + pinmux = <STM32_PINMUX('E', 4, AF14)>, /* LCD_B0 */ + <STM32_PINMUX('G',12, AF9)>, /* LCD_B4 */ + <STM32_PINMUX('I', 9, AF14)>, /* LCD_VSYNC */ + <STM32_PINMUX('I',10, AF14)>, /* LCD_HSYNC */ + <STM32_PINMUX('I',14, AF14)>, /* LCD_CLK */ + <STM32_PINMUX('I',15, AF14)>, /* LCD_R0 */ + <STM32_PINMUX('J', 0, AF14)>, /* LCD_R1 */ + <STM32_PINMUX('J', 1, AF14)>, /* LCD_R2 */ + <STM32_PINMUX('J', 2, AF14)>, /* LCD_R3 */ + <STM32_PINMUX('J', 3, AF14)>, /* LCD_R4 */ + <STM32_PINMUX('J', 4, AF14)>, /* LCD_R5 */ + <STM32_PINMUX('J', 5, AF14)>, /* LCD_R6 */ + <STM32_PINMUX('J', 6, AF14)>, /* LCD_R7 */ + <STM32_PINMUX('J', 7, AF14)>, /* LCD_G0 */ + <STM32_PINMUX('J', 8, AF14)>, /* LCD_G1 */ + <STM32_PINMUX('J', 9, AF14)>, /* LCD_G2 */ + <STM32_PINMUX('J',10, AF14)>, /* LCD_G3 */ + <STM32_PINMUX('J',11, AF14)>, /* LCD_G4 */ + <STM32_PINMUX('J',13, AF14)>, /* LCD_B1 */ + <STM32_PINMUX('J',14, AF14)>, /* LCD_B2 */ + <STM32_PINMUX('J',15, AF14)>, /* LCD_B3 */ + <STM32_PINMUX('K', 0, AF14)>, /* LCD_G5 */ + <STM32_PINMUX('K', 1, AF14)>, /* LCD_G6 */ + <STM32_PINMUX('K', 2, AF14)>, /* LCD_G7 */ + <STM32_PINMUX('K', 4, AF14)>, /* LCD_B5 */ + <STM32_PINMUX('K', 5, AF14)>, /* LCD_B6 */ + <STM32_PINMUX('K', 6, AF14)>, /* LCD_B7 */ + <STM32_PINMUX('K', 7, AF14)>; /* LCD_DE */ + slew-rate = <2>; + }; + }; }; }; }; -- 2.32.0 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH v2 2/6] ARM: dts: stm32: add pin map for LTDC on stm32f7 2023-06-07 6:31 ` [RESEND PATCH v2 2/6] ARM: dts: stm32: add pin map for LTDC on stm32f7 Dario Binacchi @ 2023-06-08 12:42 ` Alexandre TORGUE 2023-06-09 6:21 ` Dario Binacchi 0 siblings, 1 reply; 13+ messages in thread From: Alexandre TORGUE @ 2023-06-08 12:42 UTC (permalink / raw) To: Dario Binacchi, linux-kernel Cc: Raphael Gallais-Pou, linux-arm-kernel, dri-devel, Philippe Cornu, Amarula patchwork, Maxime Coquelin, michael, linux-stm32, Conor Dooley, Krzysztof Kozlowski, Rob Herring, devicetree Hi Dario On 6/7/23 08:31, Dario Binacchi wrote: > Add pin configurations for using LTDC (LCD-tft Display Controller) on > stm32f746-disco board. > > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> > --- > > (no changes since v1) > > arch/arm/boot/dts/stm32f7-pinctrl.dtsi | 35 ++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/arch/arm/boot/dts/stm32f7-pinctrl.dtsi b/arch/arm/boot/dts/stm32f7-pinctrl.dtsi > index 9f65403295ca..f3f90b9bcd61 100644 > --- a/arch/arm/boot/dts/stm32f7-pinctrl.dtsi > +++ b/arch/arm/boot/dts/stm32f7-pinctrl.dtsi > @@ -365,6 +365,41 @@ pins2 { > bias-pull-up; > }; > }; > + > + > + ltdc_pins_a: ltdc-pins-a-0 { ltdc-pins-a-0 --> ltdc-pins-0 is a bit cleaner. I know that I have to fix sdio pins nodes in this file to keep the same spirit for all group names. If there is no V3 I wil do it directly when I'll apply DT patches if you agree. Alex > + pins { > + pinmux = <STM32_PINMUX('E', 4, AF14)>, /* LCD_B0 */ > + <STM32_PINMUX('G',12, AF9)>, /* LCD_B4 */ > + <STM32_PINMUX('I', 9, AF14)>, /* LCD_VSYNC */ > + <STM32_PINMUX('I',10, AF14)>, /* LCD_HSYNC */ > + <STM32_PINMUX('I',14, AF14)>, /* LCD_CLK */ > + <STM32_PINMUX('I',15, AF14)>, /* LCD_R0 */ > + <STM32_PINMUX('J', 0, AF14)>, /* LCD_R1 */ > + <STM32_PINMUX('J', 1, AF14)>, /* LCD_R2 */ > + <STM32_PINMUX('J', 2, AF14)>, /* LCD_R3 */ > + <STM32_PINMUX('J', 3, AF14)>, /* LCD_R4 */ > + <STM32_PINMUX('J', 4, AF14)>, /* LCD_R5 */ > + <STM32_PINMUX('J', 5, AF14)>, /* LCD_R6 */ > + <STM32_PINMUX('J', 6, AF14)>, /* LCD_R7 */ > + <STM32_PINMUX('J', 7, AF14)>, /* LCD_G0 */ > + <STM32_PINMUX('J', 8, AF14)>, /* LCD_G1 */ > + <STM32_PINMUX('J', 9, AF14)>, /* LCD_G2 */ > + <STM32_PINMUX('J',10, AF14)>, /* LCD_G3 */ > + <STM32_PINMUX('J',11, AF14)>, /* LCD_G4 */ > + <STM32_PINMUX('J',13, AF14)>, /* LCD_B1 */ > + <STM32_PINMUX('J',14, AF14)>, /* LCD_B2 */ > + <STM32_PINMUX('J',15, AF14)>, /* LCD_B3 */ > + <STM32_PINMUX('K', 0, AF14)>, /* LCD_G5 */ > + <STM32_PINMUX('K', 1, AF14)>, /* LCD_G6 */ > + <STM32_PINMUX('K', 2, AF14)>, /* LCD_G7 */ > + <STM32_PINMUX('K', 4, AF14)>, /* LCD_B5 */ > + <STM32_PINMUX('K', 5, AF14)>, /* LCD_B6 */ > + <STM32_PINMUX('K', 6, AF14)>, /* LCD_B7 */ > + <STM32_PINMUX('K', 7, AF14)>; /* LCD_DE */ > + slew-rate = <2>; > + }; > + }; > }; > }; > }; ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH v2 2/6] ARM: dts: stm32: add pin map for LTDC on stm32f7 2023-06-08 12:42 ` Alexandre TORGUE @ 2023-06-09 6:21 ` Dario Binacchi 2023-06-12 7:35 ` Alexandre TORGUE 0 siblings, 1 reply; 13+ messages in thread From: Dario Binacchi @ 2023-06-09 6:21 UTC (permalink / raw) To: Alexandre TORGUE Cc: linux-kernel, Raphael Gallais-Pou, linux-arm-kernel, dri-devel, Philippe Cornu, Amarula patchwork, Maxime Coquelin, michael, linux-stm32, Conor Dooley, Krzysztof Kozlowski, Rob Herring, devicetree Hi Alexandre, On Thu, Jun 8, 2023 at 2:42 PM Alexandre TORGUE <alexandre.torgue@foss.st.com> wrote: > > Hi Dario > > On 6/7/23 08:31, Dario Binacchi wrote: > > Add pin configurations for using LTDC (LCD-tft Display Controller) on > > stm32f746-disco board. > > > > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> > > --- > > > > (no changes since v1) > > > > arch/arm/boot/dts/stm32f7-pinctrl.dtsi | 35 ++++++++++++++++++++++++++ > > 1 file changed, 35 insertions(+) > > > > diff --git a/arch/arm/boot/dts/stm32f7-pinctrl.dtsi b/arch/arm/boot/dts/stm32f7-pinctrl.dtsi > > index 9f65403295ca..f3f90b9bcd61 100644 > > --- a/arch/arm/boot/dts/stm32f7-pinctrl.dtsi > > +++ b/arch/arm/boot/dts/stm32f7-pinctrl.dtsi > > @@ -365,6 +365,41 @@ pins2 { > > bias-pull-up; > > }; > > }; > > + > > + > > + ltdc_pins_a: ltdc-pins-a-0 { > > ltdc-pins-a-0 --> ltdc-pins-0 is a bit cleaner. I know that I have to > fix sdio pins nodes in this file to keep the same spirit for all group > names. I have looked at the file arch/arm/boot/dts/stm32f7-pinctrl.dtsi, and based on the following nodes: usart1_pins_a: usart1-0 i2c1_pins_b: i2c1-0 can1_pins_a: can1-0 I have decided to rename ltdc-pins-a-0 to ltdc-0. I hope you agree. Thanks and regards, Dario > > If there is no V3 I wil do it directly when I'll apply DT patches if you > agree. > > Alex > > > > + pins { > > + pinmux = <STM32_PINMUX('E', 4, AF14)>, /* LCD_B0 */ > > + <STM32_PINMUX('G',12, AF9)>, /* LCD_B4 */ > > + <STM32_PINMUX('I', 9, AF14)>, /* LCD_VSYNC */ > > + <STM32_PINMUX('I',10, AF14)>, /* LCD_HSYNC */ > > + <STM32_PINMUX('I',14, AF14)>, /* LCD_CLK */ > > + <STM32_PINMUX('I',15, AF14)>, /* LCD_R0 */ > > + <STM32_PINMUX('J', 0, AF14)>, /* LCD_R1 */ > > + <STM32_PINMUX('J', 1, AF14)>, /* LCD_R2 */ > > + <STM32_PINMUX('J', 2, AF14)>, /* LCD_R3 */ > > + <STM32_PINMUX('J', 3, AF14)>, /* LCD_R4 */ > > + <STM32_PINMUX('J', 4, AF14)>, /* LCD_R5 */ > > + <STM32_PINMUX('J', 5, AF14)>, /* LCD_R6 */ > > + <STM32_PINMUX('J', 6, AF14)>, /* LCD_R7 */ > > + <STM32_PINMUX('J', 7, AF14)>, /* LCD_G0 */ > > + <STM32_PINMUX('J', 8, AF14)>, /* LCD_G1 */ > > + <STM32_PINMUX('J', 9, AF14)>, /* LCD_G2 */ > > + <STM32_PINMUX('J',10, AF14)>, /* LCD_G3 */ > > + <STM32_PINMUX('J',11, AF14)>, /* LCD_G4 */ > > + <STM32_PINMUX('J',13, AF14)>, /* LCD_B1 */ > > + <STM32_PINMUX('J',14, AF14)>, /* LCD_B2 */ > > + <STM32_PINMUX('J',15, AF14)>, /* LCD_B3 */ > > + <STM32_PINMUX('K', 0, AF14)>, /* LCD_G5 */ > > + <STM32_PINMUX('K', 1, AF14)>, /* LCD_G6 */ > > + <STM32_PINMUX('K', 2, AF14)>, /* LCD_G7 */ > > + <STM32_PINMUX('K', 4, AF14)>, /* LCD_B5 */ > > + <STM32_PINMUX('K', 5, AF14)>, /* LCD_B6 */ > > + <STM32_PINMUX('K', 6, AF14)>, /* LCD_B7 */ > > + <STM32_PINMUX('K', 7, AF14)>; /* LCD_DE */ > > + slew-rate = <2>; > > + }; > > + }; > > }; > > }; > > }; > -- Dario Binacchi Senior Embedded Linux Developer dario.binacchi@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH v2 2/6] ARM: dts: stm32: add pin map for LTDC on stm32f7 2023-06-09 6:21 ` Dario Binacchi @ 2023-06-12 7:35 ` Alexandre TORGUE 0 siblings, 0 replies; 13+ messages in thread From: Alexandre TORGUE @ 2023-06-12 7:35 UTC (permalink / raw) To: Dario Binacchi Cc: linux-kernel, Raphael Gallais-Pou, linux-arm-kernel, dri-devel, Philippe Cornu, Amarula patchwork, Maxime Coquelin, michael, linux-stm32, Conor Dooley, Krzysztof Kozlowski, Rob Herring, devicetree hi Dario On 6/9/23 08:21, Dario Binacchi wrote: > Hi Alexandre, > > On Thu, Jun 8, 2023 at 2:42 PM Alexandre TORGUE > <alexandre.torgue@foss.st.com> wrote: >> >> Hi Dario >> >> On 6/7/23 08:31, Dario Binacchi wrote: >>> Add pin configurations for using LTDC (LCD-tft Display Controller) on >>> stm32f746-disco board. >>> >>> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> >>> --- >>> >>> (no changes since v1) >>> >>> arch/arm/boot/dts/stm32f7-pinctrl.dtsi | 35 ++++++++++++++++++++++++++ >>> 1 file changed, 35 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/stm32f7-pinctrl.dtsi b/arch/arm/boot/dts/stm32f7-pinctrl.dtsi >>> index 9f65403295ca..f3f90b9bcd61 100644 >>> --- a/arch/arm/boot/dts/stm32f7-pinctrl.dtsi >>> +++ b/arch/arm/boot/dts/stm32f7-pinctrl.dtsi >>> @@ -365,6 +365,41 @@ pins2 { >>> bias-pull-up; >>> }; >>> }; >>> + >>> + >>> + ltdc_pins_a: ltdc-pins-a-0 { >> >> ltdc-pins-a-0 --> ltdc-pins-0 is a bit cleaner. I know that I have to >> fix sdio pins nodes in this file to keep the same spirit for all group >> names. > > I have looked at the file arch/arm/boot/dts/stm32f7-pinctrl.dtsi, and > based on the following nodes: > usart1_pins_a: usart1-0 > i2c1_pins_b: i2c1-0 > can1_pins_a: can1-0 > > I have decided to rename ltdc-pins-a-0 to ltdc-0. > > I hope you agree. Yes! perfect. Alex > > Thanks and regards, > > Dario > >> >> If there is no V3 I wil do it directly when I'll apply DT patches if you >> agree. >> >> Alex >> >> >>> + pins { >>> + pinmux = <STM32_PINMUX('E', 4, AF14)>, /* LCD_B0 */ >>> + <STM32_PINMUX('G',12, AF9)>, /* LCD_B4 */ >>> + <STM32_PINMUX('I', 9, AF14)>, /* LCD_VSYNC */ >>> + <STM32_PINMUX('I',10, AF14)>, /* LCD_HSYNC */ >>> + <STM32_PINMUX('I',14, AF14)>, /* LCD_CLK */ >>> + <STM32_PINMUX('I',15, AF14)>, /* LCD_R0 */ >>> + <STM32_PINMUX('J', 0, AF14)>, /* LCD_R1 */ >>> + <STM32_PINMUX('J', 1, AF14)>, /* LCD_R2 */ >>> + <STM32_PINMUX('J', 2, AF14)>, /* LCD_R3 */ >>> + <STM32_PINMUX('J', 3, AF14)>, /* LCD_R4 */ >>> + <STM32_PINMUX('J', 4, AF14)>, /* LCD_R5 */ >>> + <STM32_PINMUX('J', 5, AF14)>, /* LCD_R6 */ >>> + <STM32_PINMUX('J', 6, AF14)>, /* LCD_R7 */ >>> + <STM32_PINMUX('J', 7, AF14)>, /* LCD_G0 */ >>> + <STM32_PINMUX('J', 8, AF14)>, /* LCD_G1 */ >>> + <STM32_PINMUX('J', 9, AF14)>, /* LCD_G2 */ >>> + <STM32_PINMUX('J',10, AF14)>, /* LCD_G3 */ >>> + <STM32_PINMUX('J',11, AF14)>, /* LCD_G4 */ >>> + <STM32_PINMUX('J',13, AF14)>, /* LCD_B1 */ >>> + <STM32_PINMUX('J',14, AF14)>, /* LCD_B2 */ >>> + <STM32_PINMUX('J',15, AF14)>, /* LCD_B3 */ >>> + <STM32_PINMUX('K', 0, AF14)>, /* LCD_G5 */ >>> + <STM32_PINMUX('K', 1, AF14)>, /* LCD_G6 */ >>> + <STM32_PINMUX('K', 2, AF14)>, /* LCD_G7 */ >>> + <STM32_PINMUX('K', 4, AF14)>, /* LCD_B5 */ >>> + <STM32_PINMUX('K', 5, AF14)>, /* LCD_B6 */ >>> + <STM32_PINMUX('K', 6, AF14)>, /* LCD_B7 */ >>> + <STM32_PINMUX('K', 7, AF14)>; /* LCD_DE */ >>> + slew-rate = <2>; >>> + }; >>> + }; >>> }; >>> }; >>> }; >> > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* [RESEND PATCH v2 3/6] ARM: dts: stm32: support display on stm32f746-disco board 2023-06-07 6:31 [RESEND PATCH v2 0/6] Add display support on the stm32f746-disco board Dario Binacchi 2023-06-07 6:31 ` [RESEND PATCH v2 1/6] ARM: dts: stm32: add ltdc support on stm32f746 MCU Dario Binacchi 2023-06-07 6:31 ` [RESEND PATCH v2 2/6] ARM: dts: stm32: add pin map for LTDC on stm32f7 Dario Binacchi @ 2023-06-07 6:31 ` Dario Binacchi 2023-06-07 6:42 ` Jagan Teki 2023-06-07 6:31 ` [RESEND PATCH v2 4/6] dt-bindings: display: simple: add Rocktech RK043FN48H Dario Binacchi 2023-06-07 8:15 ` (subset) [RESEND PATCH v2 0/6] Add display support on the stm32f746-disco board Neil Armstrong 4 siblings, 1 reply; 13+ messages in thread From: Dario Binacchi @ 2023-06-07 6:31 UTC (permalink / raw) To: linux-kernel Cc: Raphael Gallais-Pou, linux-arm-kernel, dri-devel, Philippe Cornu, Amarula patchwork, Maxime Coquelin, michael, linux-stm32, Alexandre Torgue, Dario Binacchi, Conor Dooley, Krzysztof Kozlowski, Rob Herring, devicetree Add support to Rocktech RK043FN48H display on stm32f746-disco board. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> --- (no changes since v1) arch/arm/boot/dts/stm32f746-disco.dts | 51 +++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/arch/arm/boot/dts/stm32f746-disco.dts b/arch/arm/boot/dts/stm32f746-disco.dts index c11616ed5fc6..cda423b6a874 100644 --- a/arch/arm/boot/dts/stm32f746-disco.dts +++ b/arch/arm/boot/dts/stm32f746-disco.dts @@ -60,10 +60,41 @@ memory@c0000000 { reg = <0xC0000000 0x800000>; }; + reserved-memory { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + linux,cma { + compatible = "shared-dma-pool"; + no-map; + size = <0x80000>; + linux,dma-default; + }; + }; + aliases { serial0 = &usart1; }; + backlight: backlight { + compatible = "gpio-backlight"; + gpios = <&gpiok 3 GPIO_ACTIVE_HIGH>; + status = "okay"; + }; + + panel_rgb: panel-rgb { + compatible = "rocktech,rk043fn48h"; + backlight = <&backlight>; + enable-gpios = <&gpioi 12 GPIO_ACTIVE_HIGH>; + status = "okay"; + port { + panel_in_rgb: endpoint { + remote-endpoint = <<dc_out_rgb>; + }; + }; + }; + usbotg_hs_phy: usb-phy { #phy-cells = <0>; compatible = "usb-nop-xceiv"; @@ -99,6 +130,26 @@ &i2c1 { status = "okay"; }; +&dma1 { + status = "okay"; +}; + +&dma2 { + status = "okay"; +}; + +<dc { + pinctrl-0 = <<dc_pins_a>; + pinctrl-names = "default"; + status = "okay"; + + port { + ltdc_out_rgb: endpoint { + remote-endpoint = <&panel_in_rgb>; + }; + }; +}; + &sdio1 { status = "okay"; vmmc-supply = <&mmc_vcard>; -- 2.32.0 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH v2 3/6] ARM: dts: stm32: support display on stm32f746-disco board 2023-06-07 6:31 ` [RESEND PATCH v2 3/6] ARM: dts: stm32: support display on stm32f746-disco board Dario Binacchi @ 2023-06-07 6:42 ` Jagan Teki 2023-06-07 12:49 ` Dario Binacchi 0 siblings, 1 reply; 13+ messages in thread From: Jagan Teki @ 2023-06-07 6:42 UTC (permalink / raw) To: Dario Binacchi Cc: linux-kernel, Raphael Gallais-Pou, linux-arm-kernel, dri-devel, Philippe Cornu, Amarula patchwork, Maxime Coquelin, michael, linux-stm32, Alexandre Torgue, Conor Dooley, Krzysztof Kozlowski, Rob Herring, devicetree On Wed, Jun 7, 2023 at 12:01 PM Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote: > > Add support to Rocktech RK043FN48H display on stm32f746-disco board. > > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> > --- > > (no changes since v1) > > arch/arm/boot/dts/stm32f746-disco.dts | 51 +++++++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/arch/arm/boot/dts/stm32f746-disco.dts b/arch/arm/boot/dts/stm32f746-disco.dts > index c11616ed5fc6..cda423b6a874 100644 > --- a/arch/arm/boot/dts/stm32f746-disco.dts > +++ b/arch/arm/boot/dts/stm32f746-disco.dts > @@ -60,10 +60,41 @@ memory@c0000000 { > reg = <0xC0000000 0x800000>; > }; > > + reserved-memory { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + linux,cma { > + compatible = "shared-dma-pool"; > + no-map; > + size = <0x80000>; > + linux,dma-default; > + }; > + }; This looks unrelated to display enablement, isn't it? Jagan. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH v2 3/6] ARM: dts: stm32: support display on stm32f746-disco board 2023-06-07 6:42 ` Jagan Teki @ 2023-06-07 12:49 ` Dario Binacchi 0 siblings, 0 replies; 13+ messages in thread From: Dario Binacchi @ 2023-06-07 12:49 UTC (permalink / raw) To: Jagan Teki Cc: linux-kernel, Raphael Gallais-Pou, linux-arm-kernel, dri-devel, Philippe Cornu, Amarula patchwork, Maxime Coquelin, michael, linux-stm32, Alexandre Torgue, Conor Dooley, Krzysztof Kozlowski, Rob Herring, devicetree Hi Jagan, On Wed, Jun 7, 2023 at 8:43 AM Jagan Teki <jagan@amarulasolutions.com> wrote: > > On Wed, Jun 7, 2023 at 12:01 PM Dario Binacchi > <dario.binacchi@amarulasolutions.com> wrote: > > > > Add support to Rocktech RK043FN48H display on stm32f746-disco board. > > > > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> > > --- > > > > (no changes since v1) > > > > arch/arm/boot/dts/stm32f746-disco.dts | 51 +++++++++++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > > > diff --git a/arch/arm/boot/dts/stm32f746-disco.dts b/arch/arm/boot/dts/stm32f746-disco.dts > > index c11616ed5fc6..cda423b6a874 100644 > > --- a/arch/arm/boot/dts/stm32f746-disco.dts > > +++ b/arch/arm/boot/dts/stm32f746-disco.dts > > @@ -60,10 +60,41 @@ memory@c0000000 { > > reg = <0xC0000000 0x800000>; > > }; > > > > + reserved-memory { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges; > > + > > + linux,cma { > > + compatible = "shared-dma-pool"; > > + no-map; > > + size = <0x80000>; > > + linux,dma-default; > > + }; > > + }; > > This looks unrelated to display enablement, isn't it? Without the "reserved-memory" node, it is not possible to allocate memory for the framebuffer. I got this error: stm32-display 40016800.display-controller: [drm] *ERROR* failed to allocate buffer with size 139264 Thanks and regards, Dario > > Jagan. -- Dario Binacchi Senior Embedded Linux Developer dario.binacchi@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com ^ permalink raw reply [flat|nested] 13+ messages in thread
* [RESEND PATCH v2 4/6] dt-bindings: display: simple: add Rocktech RK043FN48H 2023-06-07 6:31 [RESEND PATCH v2 0/6] Add display support on the stm32f746-disco board Dario Binacchi ` (2 preceding siblings ...) 2023-06-07 6:31 ` [RESEND PATCH v2 3/6] ARM: dts: stm32: support display on stm32f746-disco board Dario Binacchi @ 2023-06-07 6:31 ` Dario Binacchi 2023-06-07 6:40 ` Jagan Teki 2023-06-07 7:16 ` Raphael Gallais-Pou 2023-06-07 8:15 ` (subset) [RESEND PATCH v2 0/6] Add display support on the stm32f746-disco board Neil Armstrong 4 siblings, 2 replies; 13+ messages in thread From: Dario Binacchi @ 2023-06-07 6:31 UTC (permalink / raw) To: linux-kernel Cc: Raphael Gallais-Pou, linux-arm-kernel, dri-devel, Philippe Cornu, Amarula patchwork, Maxime Coquelin, michael, linux-stm32, Alexandre Torgue, Dario Binacchi, Conor Dooley, Conor Dooley, Daniel Vetter, David Airlie, Krzysztof Kozlowski, Neil Armstrong, Rob Herring, Sam Ravnborg, Thierry Reding, devicetree Add compatible to panel-simple for Rocktech Displays Limited RK043FN48H 4.3" 480x272 LCD-TFT panel. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> --- Changes in v2: - Add 'Acked-by' tag of Conor Dooley. .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml index 01560fe226dd..bd6a92d2b41c 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml @@ -280,6 +280,8 @@ properties: - rocktech,rk101ii01d-ct # Rocktech Display Ltd. RK070ER9427 800(RGB)x480 TFT LCD panel - rocktech,rk070er9427 + # Rocktech Display Ltd. RK043FN48H 4.3" 480x272 LCD-TFT panel + - rocktech,rk043fn48h # Samsung 13.3" FHD (1920x1080 pixels) eDP AMOLED panel - samsung,atna33xc20 # Samsung 12.2" (2560x1600 pixels) TFT LCD panel -- 2.32.0 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH v2 4/6] dt-bindings: display: simple: add Rocktech RK043FN48H 2023-06-07 6:31 ` [RESEND PATCH v2 4/6] dt-bindings: display: simple: add Rocktech RK043FN48H Dario Binacchi @ 2023-06-07 6:40 ` Jagan Teki 2023-06-07 7:16 ` Raphael Gallais-Pou 1 sibling, 0 replies; 13+ messages in thread From: Jagan Teki @ 2023-06-07 6:40 UTC (permalink / raw) To: Dario Binacchi Cc: linux-kernel, Raphael Gallais-Pou, linux-arm-kernel, dri-devel, Philippe Cornu, Amarula patchwork, Maxime Coquelin, michael, linux-stm32, Alexandre Torgue, Conor Dooley, Conor Dooley, Daniel Vetter, David Airlie, Krzysztof Kozlowski, Neil Armstrong, Rob Herring, Sam Ravnborg, Thierry Reding, devicetree On Wed, Jun 7, 2023 at 12:01 PM Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote: > > Add compatible to panel-simple for Rocktech Displays Limited > RK043FN48H 4.3" 480x272 LCD-TFT panel. > > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > --- Reviewed-by: Jagan Teki <jagan@amarulasolutions.com> ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RESEND PATCH v2 4/6] dt-bindings: display: simple: add Rocktech RK043FN48H 2023-06-07 6:31 ` [RESEND PATCH v2 4/6] dt-bindings: display: simple: add Rocktech RK043FN48H Dario Binacchi 2023-06-07 6:40 ` Jagan Teki @ 2023-06-07 7:16 ` Raphael Gallais-Pou 1 sibling, 0 replies; 13+ messages in thread From: Raphael Gallais-Pou @ 2023-06-07 7:16 UTC (permalink / raw) To: Dario Binacchi, linux-kernel Cc: linux-arm-kernel, dri-devel, Philippe Cornu, Amarula patchwork, Maxime Coquelin, michael, linux-stm32, Alexandre Torgue, Conor Dooley, Conor Dooley, Daniel Vetter, David Airlie, Krzysztof Kozlowski, Neil Armstrong, Rob Herring, Sam Ravnborg, Thierry Reding, devicetree On 6/7/23 08:31, Dario Binacchi wrote: > Add compatible to panel-simple for Rocktech Displays Limited > RK043FN48H 4.3" 480x272 LCD-TFT panel. > > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> > Acked-by: Conor Dooley <conor.dooley@microchip.com> Reviewed-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com> Thanks, Raphaël ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: (subset) [RESEND PATCH v2 0/6] Add display support on the stm32f746-disco board 2023-06-07 6:31 [RESEND PATCH v2 0/6] Add display support on the stm32f746-disco board Dario Binacchi ` (3 preceding siblings ...) 2023-06-07 6:31 ` [RESEND PATCH v2 4/6] dt-bindings: display: simple: add Rocktech RK043FN48H Dario Binacchi @ 2023-06-07 8:15 ` Neil Armstrong 4 siblings, 0 replies; 13+ messages in thread From: Neil Armstrong @ 2023-06-07 8:15 UTC (permalink / raw) To: linux-kernel, Dario Binacchi Cc: Raphael Gallais-Pou, linux-arm-kernel, dri-devel, Philippe Cornu, Amarula patchwork, Maxime Coquelin, michael, linux-stm32, Alexandre Torgue, Conor Dooley, Daniel Vetter, David Airlie, Krzysztof Kozlowski, Rob Herring, Sam Ravnborg, Thierry Reding, Yannick Fertre, devicetree Hi, On Wed, 07 Jun 2023 08:31:33 +0200, Dario Binacchi wrote: > The series adds support for the display on the stm32f746-disco board, > along with a generic patch that adds the "bpp" parameter to the stm-drm > module. The intention is to allow users to size, within certain limits, > the memory footprint required by the framebuffer. > > Changes in v2: > - Add 'Acked-by' tag of Conor Dooley. > - Fix build warning reported by kernel test robot. > - Add 'Reported-by' tag of kernel test robot. > > [...] Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [4/6] dt-bindings: display: simple: add Rocktech RK043FN48H https://cgit.freedesktop.org/drm/drm-misc/commit/?id=c42a37a27c777d63961dd634a30f7c887949491a [5/6] drm/panel: simple: add support for Rocktech RK043FN48H panel https://cgit.freedesktop.org/drm/drm-misc/commit/?id=13cdd12a9f934158f4ec817cf048fcb4384aa9dc -- Neil ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2023-06-12 8:31 UTC | newest] Thread overview: 13+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-06-07 6:31 [RESEND PATCH v2 0/6] Add display support on the stm32f746-disco board Dario Binacchi 2023-06-07 6:31 ` [RESEND PATCH v2 1/6] ARM: dts: stm32: add ltdc support on stm32f746 MCU Dario Binacchi 2023-06-07 6:31 ` [RESEND PATCH v2 2/6] ARM: dts: stm32: add pin map for LTDC on stm32f7 Dario Binacchi 2023-06-08 12:42 ` Alexandre TORGUE 2023-06-09 6:21 ` Dario Binacchi 2023-06-12 7:35 ` Alexandre TORGUE 2023-06-07 6:31 ` [RESEND PATCH v2 3/6] ARM: dts: stm32: support display on stm32f746-disco board Dario Binacchi 2023-06-07 6:42 ` Jagan Teki 2023-06-07 12:49 ` Dario Binacchi 2023-06-07 6:31 ` [RESEND PATCH v2 4/6] dt-bindings: display: simple: add Rocktech RK043FN48H Dario Binacchi 2023-06-07 6:40 ` Jagan Teki 2023-06-07 7:16 ` Raphael Gallais-Pou 2023-06-07 8:15 ` (subset) [RESEND PATCH v2 0/6] Add display support on the stm32f746-disco board Neil Armstrong
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).