From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Krzysztof Kozlowski'" <krzk@kernel.org>,
"'raghav.s'" <raghav.s@samsung.com>, <s.nawrocki@samsung.com>,
<cw00.choi@samsung.com>, <peter.griffin@linaro.org>,
<mturquette@baylibre.com>, <sboyd@kernel.org>,
<bmasney@redhat.com>, <robh@kernel.org>, <conor+dt@kernel.org>
Cc: <linux-samsung-soc@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <hajun.sung@samsung.com>,
<is.gandhi@samsung.com>, <ts.amit@samsung.com>,
<pokala.reddy@samsung.com>
Subject: RE: [PATCH 04/13] arm64: dts: exynos8855: add cmu_top & cmu_peric clock DT nodes
Date: Tue, 28 Jul 2026 17:53:37 +0530 [thread overview]
Message-ID: <079201dd1e8b$eca22680$c5e67380$@samsung.com> (raw)
In-Reply-To: <8582d4f9-1a78-4f47-bab9-c52393dffbd1@kernel.org>
Hi Krzysztof,
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Tuesday, July 28, 2026 5:30 PM
> To: raghav.s <raghav.s@samsung.com>; s.nawrocki@samsung.com;
> cw00.choi@samsung.com; peter.griffin@linaro.org;
> alim.akhtar@samsung.com; mturquette@baylibre.com; sboyd@kernel.org;
> bmasney@redhat.com; robh@kernel.org; conor+dt@kernel.org
> Cc: linux-samsung-soc@vger.kernel.org; linux-clk@vger.kernel.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; hajun.sung@samsung.com;
> is.gandhi@samsung.com; ts.amit@samsung.com;
> pokala.reddy@samsung.com
> Subject: Re: [PATCH 04/13] arm64: dts: exynos8855: add cmu_top &
> cmu_peric clock DT nodes
>
> On 28/07/2026 14:11, raghav.s wrote:
> > Add required dt node for cmu_top & cmu_peric block
> >
> > Signed-off-by: raghav.s <raghav.s@samsung.com>
> > ---
> > arch/arm64/boot/dts/exynos/exynos8855.dtsi | 24
> > ++++++++++++++++++++++
> > 1 file changed, 24 insertions(+)
>
> Please organize your patches in reasonable order. DTS is never in the middle,
> see submitting patches (both documents) and maintainer-soc profile.
>
The thought was to add clks block wise and hence we see DTS coming in between but for the other blocks.
e.g. patch-2 and 3 adds binding and driver for TOP and PERIC and this patch-4 adds DTS.
And patch-5 and 6 adds binding and driver for PERIS and patch-7 adds DTS and so on.
Cover-letter should have explained this.
Are you suggesting to re-order all the binding first followed by all blocks driver and then add a single DTS for all clock controller?
Does current approach helps in review?
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2026-07-28 12:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260728115239epcas5p218bc69194dc55a5087c363816396cd5e@epcas5p2.samsung.com>
2026-07-28 12:10 ` [PATCH 00/13] Add clock support for Exynos8855 SoC raghav.s
2026-07-28 12:10 ` [PATCH 01/13] clk: samsung: clk-pll: Add supoprt for pll_4313 raghav.s
2026-07-28 11:58 ` Krzysztof Kozlowski
2026-07-28 12:11 ` [PATCH 02/13] dt-bindings: clock: exynos8855: add top & peric clock definitions raghav.s
2026-07-28 12:11 ` [PATCH 03/13] clk: samsung: exynos8855: add block top and peric clock support raghav.s
2026-07-28 12:11 ` sashiko-bot
2026-07-28 12:11 ` [PATCH 04/13] arm64: dts: exynos8855: add cmu_top & cmu_peric clock DT nodes raghav.s
2026-07-28 11:59 ` Krzysztof Kozlowski
2026-07-28 12:23 ` Alim Akhtar [this message]
2026-07-28 12:24 ` Krzysztof Kozlowski
2026-07-28 12:58 ` Alim Akhtar
2026-07-28 12:11 ` [PATCH 05/13] dt-bindings: clock: exynos8855: add peris clock definitions raghav.s
2026-07-28 12:01 ` sashiko-bot
2026-07-28 12:11 ` [PATCH 06/13] clk: samsung: exynos8855: add block peris clock support raghav.s
2026-07-28 12:00 ` Krzysztof Kozlowski
2026-07-28 12:11 ` [PATCH 07/13] arm64: dts: exynos8855: add cmu_peris clock DT nodes raghav.s
2026-07-28 12:11 ` [PATCH 08/13] dt-bindings: clock: exynos8855: add hsi clock definitions raghav.s
2026-07-28 12:11 ` [PATCH 09/13] clk: samsung: exynos8855: add block hsi clock support raghav.s
2026-07-28 12:11 ` [PATCH 10/13] arm64: dts: exynos8855: add cmu_hsi clock DT nodes raghav.s
2026-07-28 12:11 ` [PATCH 11/13] dt-bindings: clock: exynos8855: add usb clock definitions raghav.s
2026-07-28 12:11 ` [PATCH 12/13] clk: samsung: exynos8855: add block usb clock support raghav.s
2026-07-28 12:11 ` [PATCH 13/13] arm64: dts: exynos8855: add cmu_usb clock DT nodes raghav.s
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='079201dd1e8b$eca22680$c5e67380$@samsung.com' \
--to=alim.akhtar@samsung.com \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=hajun.sung@samsung.com \
--cc=is.gandhi@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter.griffin@linaro.org \
--cc=pokala.reddy@samsung.com \
--cc=raghav.s@samsung.com \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=ts.amit@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox