From: "Rafał Miłecki" <rafal@milecki.pl>
To: William Zhang <william.zhang@broadcom.com>
Cc: Linux ARM List <linux-arm-kernel@lists.infradead.org>,
joel.peshkin@broadcom.com, dan.beygelman@broadcom.com,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Florian Fainelli <f.fainelli@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH 3/9] arm64: dts: bcmbca: update BCM4908 board dts files
Date: Thu, 21 Jul 2022 08:15:15 +0200 [thread overview]
Message-ID: <07a566d45cf48baff70f027e52264aa8@milecki.pl> (raw)
In-Reply-To: <20220721000707.29557-1-william.zhang@broadcom.com>
On 2022-07-21 02:07, William Zhang wrote:
> Append "brcm,bcmbca" to compatible strings based on the new bcmbca
> binding rule for BCM4908 family based boards. This will break drivers
> that use the old compatible string for binding. Fortunately there is no
> such usage in linux and u-boot.
Why should an extra "compatible" value break anything? I don't think it
will happen unless some driver does some really crazy stuff (like
checking full list of "compatible" values).
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
Other than confusing commit message:
Acked-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>
> arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts | 2 +-
> .../dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts | 2 +-
> arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts | 2 +-
> .../arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git
> a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
> b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
> index 2dd028438c22..d8b60575eb4f 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
> @@ -7,7 +7,7 @@
> #include "bcm4906.dtsi"
>
> / {
> - compatible = "netgear,r8000p", "brcm,bcm4906", "brcm,bcm4908";
> + compatible = "netgear,r8000p", "brcm,bcm4906", "brcm,bcm4908",
> "brcm,bcmbca";
> model = "Netgear R8000P";
>
> memory@0 {
> diff --git
> a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts
> b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts
> index 064f7f549665..296393d4aaab 100644
> ---
> a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts
> +++
> b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts
> @@ -7,7 +7,7 @@
> #include "bcm4906.dtsi"
>
> / {
> - compatible = "tplink,archer-c2300-v1", "brcm,bcm4906",
> "brcm,bcm4908";
> + compatible = "tplink,archer-c2300-v1", "brcm,bcm4906",
> "brcm,bcm4908", "brcm,bcmbca";
> model = "TP-Link Archer C2300 V1";
>
> memory@0 {
> diff --git
> a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
> b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
> index 04f8524b5335..787c7ddf9102 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
> @@ -6,7 +6,7 @@
> #include "bcm4908.dtsi"
>
> / {
> - compatible = "asus,gt-ac5300", "brcm,bcm4908";
> + compatible = "asus,gt-ac5300", "brcm,bcm4908", "brcm,bcmbca";
> model = "Asus GT-AC5300";
>
> memory@0 {
> diff --git
> a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts
> b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts
> index 3c2cf2d238b6..23b96c663239 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts
> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts
> @@ -3,7 +3,7 @@
> #include "bcm4908.dtsi"
>
> / {
> - compatible = "netgear,raxe500", "brcm,bcm4908";
> + compatible = "netgear,raxe500", "brcm,bcm4908", "brcm,bcmbca";
> model = "Netgear RAXE500";
>
> memory@0 {
next prev parent reply other threads:[~2022-07-21 6:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 0:07 [RESEND PATCH 3/9] arm64: dts: bcmbca: update BCM4908 board dts files William Zhang
2022-07-21 6:15 ` Rafał Miłecki [this message]
2022-07-21 17:54 ` William Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07a566d45cf48baff70f027e52264aa8@milecki.pl \
--to=rafal@milecki.pl \
--cc=dan.beygelman@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=joel.peshkin@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).