From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ECD8C001DE for ; Mon, 17 Jul 2023 07:12:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230201AbjGQHMr (ORCPT ); Mon, 17 Jul 2023 03:12:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230213AbjGQHMp (ORCPT ); Mon, 17 Jul 2023 03:12:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79A7610DA; Mon, 17 Jul 2023 00:12:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 01C1960F7A; Mon, 17 Jul 2023 07:12:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85DA4C433C8; Mon, 17 Jul 2023 07:12:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689577962; bh=Tx/77+tErUVZAWuLrax7VIUu2uzMqwMf9CKDUK2pqEU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=N8Zd171RBHYUsQaHAzpkU5YalNpirRqrgQrWhGk7q7GZ3A+xmv7yhqJ7u3U0fKAIH X1jwKtSdXooNZjeRzUaMyY6jUCNCsC0AG4Xv2srM0fsZ+kK7y+lyjAFrzm+zaRL58H pxQ2N6y3EnC0ENoybc2oEQ+FFyfFKI92xKTOKH9agFtQoGmXPijD25dPCTdnEkrbl5 ZiX1OkzbIG/bW15ABvmV9VnnFk95dRzqQ7uFPeifWxoJjOQLq0jArU0XmE2m+8eVgV pQrDjeeu6q5X18vt7t20qpVxzPtJ4Uaw+OIM5ddy524jBazcUdhnPejktX/fHFB9Hb LiJo1/XEqM0QQ== Message-ID: <07aa464d-c9d8-4fe0-2063-98562a3480d6@kernel.org> Date: Mon, 17 Jul 2023 09:12:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 3/4] can: sun4i_can: Add send support for the Allwinner D1 To: Marc Kleine-Budde Cc: John Watts , linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, linux-can@vger.kernel.org, linux-riscv@lists.infradead.org, Fabien Poussin , Samuel Holland , Jernej Skrabec , Chen-Yu Tsai References: <20230715112523.2533742-1-contact@jookia.org> <20230715112523.2533742-4-contact@jookia.org> <20230717-aluminum-driven-a008473620ca-mkl@pengutronix.de> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230717-aluminum-driven-a008473620ca-mkl@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/07/2023 09:03, Marc Kleine-Budde wrote: > On 17.07.2023 08:41:07, Krzysztof Kozlowski wrote: >> On 16/07/2023 18:52, John Watts wrote: >>> Hello, >>> >>> On Sun, Jul 16, 2023 at 06:36:03PM +0200, Krzysztof Kozlowski wrote: >>>>> +static const struct sun4ican_quirks sun4ican_quirks_d1 = { >>>>> + .has_reset = true, >>>>> +}; >>>> >>>> Isn't this the same as previous? >>> >>> Yes, but I wanted to split up the new quirk in to its own patch. >> >> I don't understand why you need this new, duplicated entry. Aren't >> devices compatible? > > According to patch 4/4 the devices are not compatible. Ah, ok, I didn't go so far because it is not obvious to add support for a device in patch 3 which is already not correct and needs fix/followup in patch 4. Thanks. > Best regards, Krzysztof