* [PATCH v5 0/2] mmc: dw_mmc: exynos: Add HS400 support
@ 2015-01-29 2:41 Alim Akhtar
2015-01-29 2:41 ` [PATCH V5 1/2] mmc: dw_mmc: exynos: Support eMMC's HS400 mode Alim Akhtar
` (2 more replies)
0 siblings, 3 replies; 15+ messages in thread
From: Alim Akhtar @ 2015-01-29 2:41 UTC (permalink / raw)
To: linux-mmc
Cc: chris, ulf.hansson, jh80.chung, tgih.jun, dianders, alim.akhtar,
kgene, linux-arm-kernel, devicetree, linux-samsung-soc, a.kesavan,
alim.akhtar
This adds HS400 mode support for exynos dw_mmc host controller.
Currently tested on Exynos5800-peach-pi and Exyons7 platform for HS400 mode.
Tested HS200 mode with this series applied, HS200 still works.
Appreciate testing on other exynos5/7 platform which supports emmc5.0
Changes in V5:
* Enable HS400 on Exynos5800-peach-pi boards
* Addressed other review comments from Jaehoon Chung
Changes in V4:
* drop the idea of changing existing binding for ciu_div as per [1]
* addressed comments from Jaehoon Chung [2]
[1] http://www.spinics.net/lists/linux-samsung-soc/msg40923.html
[2] http://www.spinics.net/lists/devicetree/msg64373.html
Changes in V3:
rebased on ulf's next (commit: 607b448 mmc: core: Make tuning block patterns static)
Seungwon Jeon (2):
mmc: dw_mmc: exynos: Support eMMC's HS400 mode
ARM: dts: Add HS400 support for exynos5420 and exynos5800
.../devicetree/bindings/mmc/exynos-dw-mshc.txt | 7 +
arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +-
arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 +
arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 +-
arch/arm/boot/dts/exynos5800-peach-pi.dts | 7 +-
drivers/mmc/host/dw_mmc-exynos.c | 185 ++++++++++++++++----
drivers/mmc/host/dw_mmc-exynos.h | 19 +-
drivers/mmc/host/dw_mmc.c | 16 +-
drivers/mmc/host/dw_mmc.h | 2 +
9 files changed, 213 insertions(+), 38 deletions(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 15+ messages in thread* [PATCH V5 1/2] mmc: dw_mmc: exynos: Support eMMC's HS400 mode 2015-01-29 2:41 [PATCH v5 0/2] mmc: dw_mmc: exynos: Add HS400 support Alim Akhtar @ 2015-01-29 2:41 ` Alim Akhtar 2015-02-25 6:34 ` Jaehoon Chung 2015-02-25 14:38 ` Rob Herring 2015-01-29 2:41 ` [PATCH V5 2/2] ARM: dts: Add HS400 support for exynos5420 and exynos5800 Alim Akhtar 2015-02-06 1:18 ` [PATCH v5 0/2] mmc: dw_mmc: exynos: Add HS400 support Jaehoon Chung 2 siblings, 2 replies; 15+ messages in thread From: Alim Akhtar @ 2015-01-29 2:41 UTC (permalink / raw) To: linux-mmc Cc: chris, ulf.hansson, jh80.chung, tgih.jun, dianders, alim.akhtar, kgene, linux-arm-kernel, devicetree, linux-samsung-soc, a.kesavan, alim.akhtar From: Seungwon Jeon <tgih.jun@samsung.com> Implements HS400 mode support for exynos host driver. This also include some updates as new mode is added. Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> [Alim: addressed review comments] --- .../devicetree/bindings/mmc/exynos-dw-mshc.txt | 7 + drivers/mmc/host/dw_mmc-exynos.c | 185 ++++++++++++++++---- drivers/mmc/host/dw_mmc-exynos.h | 19 +- drivers/mmc/host/dw_mmc.c | 16 +- drivers/mmc/host/dw_mmc.h | 2 + 5 files changed, 195 insertions(+), 34 deletions(-) diff --git a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt index ee4fc05..aad9844 100644 --- a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt +++ b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt @@ -36,6 +36,8 @@ Required Properties: in transmit mode and CIU clock phase shift value in receive mode for double data rate mode operation. Refer notes below for the order of the cells and the valid values. +* samsung,dw-mshc-hs400-timing: Specifies the value of CIU TX and RX clock phase + shift value for hs400 mode operation. Notes for the sdr-timing and ddr-timing values: @@ -50,6 +52,9 @@ Required Properties: - if CIU clock divider value is 0 (that is divide by 1), both tx and rx phase shift clocks should be 0. +* samsung,read-strobe-delay: RCLK (Data strobe) delay to control HS400 mode + (Latency value for delay line in Read path) + Required properties for a slot (Deprecated - Recommend to use one slot per host): * gpios: specifies a list of gpios used for command, clock and data bus. The @@ -82,5 +87,7 @@ Example: samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <2 3>; samsung,dw-mshc-ddr-timing = <1 2>; + samsung,dw-mshc-hs400-timing = <0 2>; + samsung,read-strobe-delay = <90>; bus-width = <8>; }; diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c index fe32948..0a56d76 100644 --- a/drivers/mmc/host/dw_mmc-exynos.c +++ b/drivers/mmc/host/dw_mmc-exynos.c @@ -40,7 +40,12 @@ struct dw_mci_exynos_priv_data { u8 ciu_div; u32 sdr_timing; u32 ddr_timing; + u32 hs400_timing; + u32 tuned_sample; u32 cur_speed; + u32 dqs_delay; + u32 saved_dqs_en; + u32 saved_strobe_ctrl; }; static struct dw_mci_exynos_compatible { @@ -71,6 +76,21 @@ static struct dw_mci_exynos_compatible { }, }; +static inline u8 dw_mci_exynos_get_ciu_div(struct dw_mci *host) +{ + struct dw_mci_exynos_priv_data *priv = host->priv; + + if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS4412) + return EXYNOS4412_FIXED_CIU_CLK_DIV; + else if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS4210) + return EXYNOS4210_FIXED_CIU_CLK_DIV; + else if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS7 || + priv->ctrl_type == DW_MCI_TYPE_EXYNOS7_SMU) + return SDMMC_CLKSEL_GET_DIV(mci_readl(host, CLKSEL64)) + 1; + else + return SDMMC_CLKSEL_GET_DIV(mci_readl(host, CLKSEL)) + 1; +} + static int dw_mci_exynos_priv_init(struct dw_mci *host) { struct dw_mci_exynos_priv_data *priv = host->priv; @@ -85,6 +105,16 @@ static int dw_mci_exynos_priv_init(struct dw_mci *host) SDMMC_MPSCTRL_NON_SECURE_WRITE_BIT); } + if (priv->ctrl_type >= DW_MCI_TYPE_EXYNOS5420) { + priv->saved_strobe_ctrl = mci_readl(host, HS400_DLINE_CTRL); + priv->saved_dqs_en = mci_readl(host, HS400_DQS_EN); + priv->saved_dqs_en |= AXI_NON_BLOCKING_WR; + mci_writel(host, HS400_DQS_EN, priv->saved_dqs_en); + if (!priv->dqs_delay) + priv->dqs_delay = + DQS_CTRL_GET_RD_DELAY(priv->saved_strobe_ctrl); + } + return 0; } @@ -97,6 +127,26 @@ static int dw_mci_exynos_setup_clock(struct dw_mci *host) return 0; } +static void dw_mci_exynos_set_clksel_timing(struct dw_mci *host, u32 timing) +{ + struct dw_mci_exynos_priv_data *priv = host->priv; + u32 clksel; + + if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS7 || + priv->ctrl_type == DW_MCI_TYPE_EXYNOS7_SMU) + clksel = mci_readl(host, CLKSEL64); + else + clksel = mci_readl(host, CLKSEL); + + clksel = (clksel & ~SDMMC_CLKSEL_TIMING_MASK) | timing; + + if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS7 || + priv->ctrl_type == DW_MCI_TYPE_EXYNOS7_SMU) + mci_writel(host, CLKSEL64, clksel); + else + mci_writel(host, CLKSEL, clksel); +} + #ifdef CONFIG_PM_SLEEP static int dw_mci_exynos_suspend(struct device *dev) { @@ -172,30 +222,38 @@ static void dw_mci_exynos_prepare_command(struct dw_mci *host, u32 *cmdr) } } -static void dw_mci_exynos_set_ios(struct dw_mci *host, struct mmc_ios *ios) +static void dw_mci_exynos_config_hs400(struct dw_mci *host, u32 timing) { struct dw_mci_exynos_priv_data *priv = host->priv; - unsigned int wanted = ios->clock; - unsigned long actual; - u8 div = priv->ciu_div + 1; + u32 dqs, strobe; - if (ios->timing == MMC_TIMING_MMC_DDR52) { - if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS7 || - priv->ctrl_type == DW_MCI_TYPE_EXYNOS7_SMU) - mci_writel(host, CLKSEL64, priv->ddr_timing); - else - mci_writel(host, CLKSEL, priv->ddr_timing); - /* Should be double rate for DDR mode */ - if (ios->bus_width == MMC_BUS_WIDTH_8) - wanted <<= 1; + /* + * Not supported to configure register + * related to HS400 + */ + if (priv->ctrl_type < DW_MCI_TYPE_EXYNOS5420) + return; + + dqs = priv->saved_dqs_en; + strobe = priv->saved_strobe_ctrl; + + if (timing == MMC_TIMING_MMC_HS400) { + dqs |= DATA_STROBE_EN; + strobe = DQS_CTRL_RD_DELAY(strobe, priv->dqs_delay); } else { - if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS7 || - priv->ctrl_type == DW_MCI_TYPE_EXYNOS7_SMU) - mci_writel(host, CLKSEL64, priv->sdr_timing); - else - mci_writel(host, CLKSEL, priv->sdr_timing); + dqs &= ~DATA_STROBE_EN; } + mci_writel(host, HS400_DQS_EN, dqs); + mci_writel(host, HS400_DLINE_CTRL, strobe); +} + +static void dw_mci_exynos_adjust_clock(struct dw_mci *host, unsigned int wanted) +{ + struct dw_mci_exynos_priv_data *priv = host->priv; + unsigned long actual; + u8 div; + int ret; /* * Don't care if wanted clock is zero or * ciu clock is unavailable @@ -207,17 +265,52 @@ static void dw_mci_exynos_set_ios(struct dw_mci *host, struct mmc_ios *ios) if (wanted < EXYNOS_CCLKIN_MIN) wanted = EXYNOS_CCLKIN_MIN; - if (wanted != priv->cur_speed) { - int ret = clk_set_rate(host->ciu_clk, wanted * div); - if (ret) - dev_warn(host->dev, - "failed to set clk-rate %u error: %d\n", - wanted * div, ret); - actual = clk_get_rate(host->ciu_clk); - host->bus_hz = actual / div; - priv->cur_speed = wanted; - host->current_speed = 0; + if (wanted == priv->cur_speed) + return; + + div = dw_mci_exynos_get_ciu_div(host); + ret = clk_set_rate(host->ciu_clk, wanted * div); + if (ret) + dev_warn(host->dev, + "failed to set clk-rate %u error: %d\n", + wanted * div, ret); + actual = clk_get_rate(host->ciu_clk); + host->bus_hz = actual / div; + priv->cur_speed = wanted; + host->current_speed = 0; +} + +static void dw_mci_exynos_set_ios(struct dw_mci *host, struct mmc_ios *ios) +{ + struct dw_mci_exynos_priv_data *priv = host->priv; + unsigned int wanted = ios->clock; + u32 timing = ios->timing, clksel; + + switch (timing) { + case MMC_TIMING_MMC_HS400: + /* Update tuned sample timing */ + clksel = SDMMC_CLKSEL_UP_SAMPLE( + priv->hs400_timing, priv->tuned_sample); + wanted <<= 1; + break; + case MMC_TIMING_MMC_DDR52: + clksel = priv->ddr_timing; + /* Should be double rate for DDR mode */ + if (ios->bus_width == MMC_BUS_WIDTH_8) + wanted <<= 1; + break; + default: + clksel = priv->sdr_timing; } + + /* Set clock timing for the requested speed mode*/ + dw_mci_exynos_set_clksel_timing(host, clksel); + + /* Configure setting for HS400 */ + dw_mci_exynos_config_hs400(host, timing); + + /* Configure clock rate */ + dw_mci_exynos_adjust_clock(host, wanted); } static int dw_mci_exynos_parse_dt(struct dw_mci *host) @@ -260,6 +353,16 @@ static int dw_mci_exynos_parse_dt(struct dw_mci *host) return ret; priv->ddr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div); + + ret = of_property_read_u32_array(np, + "samsung,dw-mshc-hs400-timing", timing, 2); + if (!ret && of_property_read_u32(np, + "samsung,read-strobe-delay", &priv->dqs_delay)) + dev_dbg(host->dev, + "read-strobe-delay is not found, assuming usage of default value\n"); + + priv->hs400_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], + HS400_FIXED_CIU_CLK_DIV); host->priv = priv; return 0; } @@ -285,7 +388,7 @@ static inline void dw_mci_exynos_set_clksmpl(struct dw_mci *host, u8 sample) clksel = mci_readl(host, CLKSEL64); else clksel = mci_readl(host, CLKSEL); - clksel = (clksel & ~0x7) | SDMMC_CLKSEL_CCLK_SAMPLE(sample); + clksel = SDMMC_CLKSEL_UP_SAMPLE(clksel, sample); if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS7 || priv->ctrl_type == DW_MCI_TYPE_EXYNOS7_SMU) mci_writel(host, CLKSEL64, clksel); @@ -304,13 +407,16 @@ static inline u8 dw_mci_exynos_move_next_clksmpl(struct dw_mci *host) clksel = mci_readl(host, CLKSEL64); else clksel = mci_readl(host, CLKSEL); + sample = (clksel + 1) & 0x7; - clksel = (clksel & ~0x7) | sample; + clksel = SDMMC_CLKSEL_UP_SAMPLE(clksel, sample); + if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS7 || priv->ctrl_type == DW_MCI_TYPE_EXYNOS7_SMU) mci_writel(host, CLKSEL64, clksel); else mci_writel(host, CLKSEL, clksel); + return sample; } @@ -343,6 +449,7 @@ out: static int dw_mci_exynos_execute_tuning(struct dw_mci_slot *slot) { struct dw_mci *host = slot->host; + struct dw_mci_exynos_priv_data *priv = host->priv; struct mmc_host *mmc = slot->mmc; u8 start_smpl, smpl, candiates = 0; s8 found = -1; @@ -360,14 +467,27 @@ static int dw_mci_exynos_execute_tuning(struct dw_mci_slot *slot) } while (start_smpl != smpl); found = dw_mci_exynos_get_best_clksmpl(candiates); - if (found >= 0) + if (found >= 0) { dw_mci_exynos_set_clksmpl(host, found); - else + priv->tuned_sample = found; + } else { ret = -EIO; + } return ret; } +int dw_mci_exynos_prepare_hs400_tuning(struct dw_mci *host, + struct mmc_ios *ios) +{ + struct dw_mci_exynos_priv_data *priv = host->priv; + + dw_mci_exynos_set_clksel_timing(host, priv->hs400_timing); + dw_mci_exynos_adjust_clock(host, (ios->clock) << 1); + + return 0; +} + /* Common capabilities of Exynos4/Exynos5 SoC */ static unsigned long exynos_dwmmc_caps[4] = { MMC_CAP_1_8V_DDR | MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23, @@ -384,6 +504,7 @@ static const struct dw_mci_drv_data exynos_drv_data = { .set_ios = dw_mci_exynos_set_ios, .parse_dt = dw_mci_exynos_parse_dt, .execute_tuning = dw_mci_exynos_execute_tuning, + .prepare_hs400_tuning = dw_mci_exynos_prepare_hs400_tuning, }; static const struct of_device_id dw_mci_exynos_match[] = { diff --git a/drivers/mmc/host/dw_mmc-exynos.h b/drivers/mmc/host/dw_mmc-exynos.h index 7872ce5..595c934 100644 --- a/drivers/mmc/host/dw_mmc-exynos.h +++ b/drivers/mmc/host/dw_mmc-exynos.h @@ -12,20 +12,36 @@ #ifndef _DW_MMC_EXYNOS_H_ #define _DW_MMC_EXYNOS_H_ -/* Extended Register's Offset */ #define SDMMC_CLKSEL 0x09C #define SDMMC_CLKSEL64 0x0A8 +/* Extended Register's Offset */ +#define SDMMC_HS400_DQS_EN 0x180 +#define SDMMC_HS400_ASYNC_FIFO_CTRL 0x184 +#define SDMMC_HS400_DLINE_CTRL 0x188 + /* CLKSEL register defines */ #define SDMMC_CLKSEL_CCLK_SAMPLE(x) (((x) & 7) << 0) #define SDMMC_CLKSEL_CCLK_DRIVE(x) (((x) & 7) << 16) #define SDMMC_CLKSEL_CCLK_DIVIDER(x) (((x) & 7) << 24) #define SDMMC_CLKSEL_GET_DRV_WD3(x) (((x) >> 16) & 0x7) +#define SDMMC_CLKSEL_GET_DIV(x) (((x) >> 24) & 0x7) +#define SDMMC_CLKSEL_UP_SAMPLE(x, y) (((x) & ~SDMMC_CLKSEL_CCLK_SAMPLE(7)) |\ + SDMMC_CLKSEL_CCLK_SAMPLE(y)) #define SDMMC_CLKSEL_TIMING(x, y, z) (SDMMC_CLKSEL_CCLK_SAMPLE(x) | \ SDMMC_CLKSEL_CCLK_DRIVE(y) | \ SDMMC_CLKSEL_CCLK_DIVIDER(z)) +#define SDMMC_CLKSEL_TIMING_MASK SDMMC_CLKSEL_TIMING(0x7, 0x7, 0x7) #define SDMMC_CLKSEL_WAKEUP_INT BIT(11) +/* RCLK_EN register defines */ +#define DATA_STROBE_EN BIT(0) +#define AXI_NON_BLOCKING_WR BIT(7) + +/* DLINE_CTRL register defines */ +#define DQS_CTRL_RD_DELAY(x, y) (((x) & ~0x3FF) | ((y) & 0x3FF)) +#define DQS_CTRL_GET_RD_DELAY(x) ((x) & 0x3FF) + /* Protector Register */ #define SDMMC_EMMCP_BASE 0x1000 #define SDMMC_MPSECURITY (SDMMC_EMMCP_BASE + 0x0010) @@ -49,6 +65,7 @@ /* Fixed clock divider */ #define EXYNOS4210_FIXED_CIU_CLK_DIV 2 #define EXYNOS4412_FIXED_CIU_CLK_DIV 4 +#define HS400_FIXED_CIU_CLK_DIV 1 /* Minimal required clock frequency for cclkin, unit: HZ */ #define EXYNOS_CCLKIN_MIN 50000000 diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 4d2e3c2..f30ef69 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -1084,7 +1084,8 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) regs = mci_readl(slot->host, UHS_REG); /* DDR mode set */ - if (ios->timing == MMC_TIMING_MMC_DDR52) + if (ios->timing == MMC_TIMING_MMC_DDR52 || + ios->timing == MMC_TIMING_MMC_HS400) regs |= ((0x1 << slot->id) << 16); else regs &= ~((0x1 << slot->id) << 16); @@ -1323,6 +1324,18 @@ static int dw_mci_execute_tuning(struct mmc_host *mmc, u32 opcode) return err; } +int dw_mci_prepare_hs400_tuning(struct mmc_host *mmc, struct mmc_ios *ios) +{ + struct dw_mci_slot *slot = mmc_priv(mmc); + struct dw_mci *host = slot->host; + const struct dw_mci_drv_data *drv_data = host->drv_data; + + if (drv_data && drv_data->prepare_hs400_tuning) + return drv_data->prepare_hs400_tuning(host, ios); + + return 0; +} + static const struct mmc_host_ops dw_mci_ops = { .request = dw_mci_request, .pre_req = dw_mci_pre_req, @@ -1335,6 +1348,7 @@ static const struct mmc_host_ops dw_mci_ops = { .card_busy = dw_mci_card_busy, .start_signal_voltage_switch = dw_mci_switch_voltage, .init_card = dw_mci_init_card, + .prepare_hs400_tuning = dw_mci_prepare_hs400_tuning, }; static void dw_mci_request_end(struct dw_mci *host, struct mmc_request *mrq) diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h index 18c4afe..d239867 100644 --- a/drivers/mmc/host/dw_mmc.h +++ b/drivers/mmc/host/dw_mmc.h @@ -271,5 +271,7 @@ struct dw_mci_drv_data { void (*set_ios)(struct dw_mci *host, struct mmc_ios *ios); int (*parse_dt)(struct dw_mci *host); int (*execute_tuning)(struct dw_mci_slot *slot); + int (*prepare_hs400_tuning)(struct dw_mci *host, + struct mmc_ios *ios); }; #endif /* _DW_MMC_H_ */ -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH V5 1/2] mmc: dw_mmc: exynos: Support eMMC's HS400 mode 2015-01-29 2:41 ` [PATCH V5 1/2] mmc: dw_mmc: exynos: Support eMMC's HS400 mode Alim Akhtar @ 2015-02-25 6:34 ` Jaehoon Chung 2015-02-25 8:12 ` Alim Akhtar 2015-02-25 14:38 ` Rob Herring 1 sibling, 1 reply; 15+ messages in thread From: Jaehoon Chung @ 2015-02-25 6:34 UTC (permalink / raw) To: Alim Akhtar, linux-mmc Cc: chris, ulf.hansson, tgih.jun, dianders, alim.akhtar, kgene, linux-arm-kernel, devicetree, linux-samsung-soc, a.kesavan Hi, Alim. Tested-by: Jaehoon Chung <jh80.chung@samsung.com> Acked-by: Jaehoon Chung <jh80.chung@samsung.com> I will include this patch into my tree, and i will request pull to Ulf. Thanks! Best Regards, Jaehoon Chung On 01/29/2015 11:41 AM, Alim Akhtar wrote: > From: Seungwon Jeon <tgih.jun@samsung.com> > > Implements HS400 mode support for exynos host driver. > This also include some updates as new mode is added. > > Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > [Alim: addressed review comments] > --- > .../devicetree/bindings/mmc/exynos-dw-mshc.txt | 7 + > drivers/mmc/host/dw_mmc-exynos.c | 185 ++++++++++++++++---- > drivers/mmc/host/dw_mmc-exynos.h | 19 +- > drivers/mmc/host/dw_mmc.c | 16 +- > drivers/mmc/host/dw_mmc.h | 2 + > 5 files changed, 195 insertions(+), 34 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt > index ee4fc05..aad9844 100644 > --- a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt > +++ b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt > @@ -36,6 +36,8 @@ Required Properties: > in transmit mode and CIU clock phase shift value in receive mode for double > data rate mode operation. Refer notes below for the order of the cells and the > valid values. > +* samsung,dw-mshc-hs400-timing: Specifies the value of CIU TX and RX clock phase > + shift value for hs400 mode operation. > > Notes for the sdr-timing and ddr-timing values: > > @@ -50,6 +52,9 @@ Required Properties: > - if CIU clock divider value is 0 (that is divide by 1), both tx and rx > phase shift clocks should be 0. > > +* samsung,read-strobe-delay: RCLK (Data strobe) delay to control HS400 mode > + (Latency value for delay line in Read path) > + > Required properties for a slot (Deprecated - Recommend to use one slot per host): > > * gpios: specifies a list of gpios used for command, clock and data bus. The > @@ -82,5 +87,7 @@ Example: > samsung,dw-mshc-ciu-div = <3>; > samsung,dw-mshc-sdr-timing = <2 3>; > samsung,dw-mshc-ddr-timing = <1 2>; > + samsung,dw-mshc-hs400-timing = <0 2>; > + samsung,read-strobe-delay = <90>; > bus-width = <8>; > }; > diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c > index fe32948..0a56d76 100644 > --- a/drivers/mmc/host/dw_mmc-exynos.c > +++ b/drivers/mmc/host/dw_mmc-exynos.c > @@ -40,7 +40,12 @@ struct dw_mci_exynos_priv_data { > u8 ciu_div; > u32 sdr_timing; > u32 ddr_timing; > + u32 hs400_timing; > + u32 tuned_sample; > u32 cur_speed; > + u32 dqs_delay; > + u32 saved_dqs_en; > + u32 saved_strobe_ctrl; > }; > > static struct dw_mci_exynos_compatible { > @@ -71,6 +76,21 @@ static struct dw_mci_exynos_compatible { > }, > }; > > +static inline u8 dw_mci_exynos_get_ciu_div(struct dw_mci *host) > +{ > + struct dw_mci_exynos_priv_data *priv = host->priv; > + > + if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS4412) > + return EXYNOS4412_FIXED_CIU_CLK_DIV; > + else if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS4210) > + return EXYNOS4210_FIXED_CIU_CLK_DIV; > + else if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS7 || > + priv->ctrl_type == DW_MCI_TYPE_EXYNOS7_SMU) > + return SDMMC_CLKSEL_GET_DIV(mci_readl(host, CLKSEL64)) + 1; > + else > + return SDMMC_CLKSEL_GET_DIV(mci_readl(host, CLKSEL)) + 1; > +} > + > static int dw_mci_exynos_priv_init(struct dw_mci *host) > { > struct dw_mci_exynos_priv_data *priv = host->priv; > @@ -85,6 +105,16 @@ static int dw_mci_exynos_priv_init(struct dw_mci *host) > SDMMC_MPSCTRL_NON_SECURE_WRITE_BIT); > } > > + if (priv->ctrl_type >= DW_MCI_TYPE_EXYNOS5420) { > + priv->saved_strobe_ctrl = mci_readl(host, HS400_DLINE_CTRL); > + priv->saved_dqs_en = mci_readl(host, HS400_DQS_EN); > + priv->saved_dqs_en |= AXI_NON_BLOCKING_WR; > + mci_writel(host, HS400_DQS_EN, priv->saved_dqs_en); > + if (!priv->dqs_delay) > + priv->dqs_delay = > + DQS_CTRL_GET_RD_DELAY(priv->saved_strobe_ctrl); > + } > + > return 0; > } > > @@ -97,6 +127,26 @@ static int dw_mci_exynos_setup_clock(struct dw_mci *host) > return 0; > } > > +static void dw_mci_exynos_set_clksel_timing(struct dw_mci *host, u32 timing) > +{ > + struct dw_mci_exynos_priv_data *priv = host->priv; > + u32 clksel; > + > + if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS7 || > + priv->ctrl_type == DW_MCI_TYPE_EXYNOS7_SMU) > + clksel = mci_readl(host, CLKSEL64); > + else > + clksel = mci_readl(host, CLKSEL); > + > + clksel = (clksel & ~SDMMC_CLKSEL_TIMING_MASK) | timing; > + > + if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS7 || > + priv->ctrl_type == DW_MCI_TYPE_EXYNOS7_SMU) > + mci_writel(host, CLKSEL64, clksel); > + else > + mci_writel(host, CLKSEL, clksel); > +} > + > #ifdef CONFIG_PM_SLEEP > static int dw_mci_exynos_suspend(struct device *dev) > { > @@ -172,30 +222,38 @@ static void dw_mci_exynos_prepare_command(struct dw_mci *host, u32 *cmdr) > } > } > > -static void dw_mci_exynos_set_ios(struct dw_mci *host, struct mmc_ios *ios) > +static void dw_mci_exynos_config_hs400(struct dw_mci *host, u32 timing) > { > struct dw_mci_exynos_priv_data *priv = host->priv; > - unsigned int wanted = ios->clock; > - unsigned long actual; > - u8 div = priv->ciu_div + 1; > + u32 dqs, strobe; > > - if (ios->timing == MMC_TIMING_MMC_DDR52) { > - if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS7 || > - priv->ctrl_type == DW_MCI_TYPE_EXYNOS7_SMU) > - mci_writel(host, CLKSEL64, priv->ddr_timing); > - else > - mci_writel(host, CLKSEL, priv->ddr_timing); > - /* Should be double rate for DDR mode */ > - if (ios->bus_width == MMC_BUS_WIDTH_8) > - wanted <<= 1; > + /* > + * Not supported to configure register > + * related to HS400 > + */ > + if (priv->ctrl_type < DW_MCI_TYPE_EXYNOS5420) > + return; > + > + dqs = priv->saved_dqs_en; > + strobe = priv->saved_strobe_ctrl; > + > + if (timing == MMC_TIMING_MMC_HS400) { > + dqs |= DATA_STROBE_EN; > + strobe = DQS_CTRL_RD_DELAY(strobe, priv->dqs_delay); > } else { > - if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS7 || > - priv->ctrl_type == DW_MCI_TYPE_EXYNOS7_SMU) > - mci_writel(host, CLKSEL64, priv->sdr_timing); > - else > - mci_writel(host, CLKSEL, priv->sdr_timing); > + dqs &= ~DATA_STROBE_EN; > } > > + mci_writel(host, HS400_DQS_EN, dqs); > + mci_writel(host, HS400_DLINE_CTRL, strobe); > +} > + > +static void dw_mci_exynos_adjust_clock(struct dw_mci *host, unsigned int wanted) > +{ > + struct dw_mci_exynos_priv_data *priv = host->priv; > + unsigned long actual; > + u8 div; > + int ret; > /* > * Don't care if wanted clock is zero or > * ciu clock is unavailable > @@ -207,17 +265,52 @@ static void dw_mci_exynos_set_ios(struct dw_mci *host, struct mmc_ios *ios) > if (wanted < EXYNOS_CCLKIN_MIN) > wanted = EXYNOS_CCLKIN_MIN; > > - if (wanted != priv->cur_speed) { > - int ret = clk_set_rate(host->ciu_clk, wanted * div); > - if (ret) > - dev_warn(host->dev, > - "failed to set clk-rate %u error: %d\n", > - wanted * div, ret); > - actual = clk_get_rate(host->ciu_clk); > - host->bus_hz = actual / div; > - priv->cur_speed = wanted; > - host->current_speed = 0; > + if (wanted == priv->cur_speed) > + return; > + > + div = dw_mci_exynos_get_ciu_div(host); > + ret = clk_set_rate(host->ciu_clk, wanted * div); > + if (ret) > + dev_warn(host->dev, > + "failed to set clk-rate %u error: %d\n", > + wanted * div, ret); > + actual = clk_get_rate(host->ciu_clk); > + host->bus_hz = actual / div; > + priv->cur_speed = wanted; > + host->current_speed = 0; > +} > + > +static void dw_mci_exynos_set_ios(struct dw_mci *host, struct mmc_ios *ios) > +{ > + struct dw_mci_exynos_priv_data *priv = host->priv; > + unsigned int wanted = ios->clock; > + u32 timing = ios->timing, clksel; > + > + switch (timing) { > + case MMC_TIMING_MMC_HS400: > + /* Update tuned sample timing */ > + clksel = SDMMC_CLKSEL_UP_SAMPLE( > + priv->hs400_timing, priv->tuned_sample); > + wanted <<= 1; > + break; > + case MMC_TIMING_MMC_DDR52: > + clksel = priv->ddr_timing; > + /* Should be double rate for DDR mode */ > + if (ios->bus_width == MMC_BUS_WIDTH_8) > + wanted <<= 1; > + break; > + default: > + clksel = priv->sdr_timing; > } > + > + /* Set clock timing for the requested speed mode*/ > + dw_mci_exynos_set_clksel_timing(host, clksel); > + > + /* Configure setting for HS400 */ > + dw_mci_exynos_config_hs400(host, timing); > + > + /* Configure clock rate */ > + dw_mci_exynos_adjust_clock(host, wanted); > } > > static int dw_mci_exynos_parse_dt(struct dw_mci *host) > @@ -260,6 +353,16 @@ static int dw_mci_exynos_parse_dt(struct dw_mci *host) > return ret; > > priv->ddr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div); > + > + ret = of_property_read_u32_array(np, > + "samsung,dw-mshc-hs400-timing", timing, 2); > + if (!ret && of_property_read_u32(np, > + "samsung,read-strobe-delay", &priv->dqs_delay)) > + dev_dbg(host->dev, > + "read-strobe-delay is not found, assuming usage of default value\n"); > + > + priv->hs400_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], > + HS400_FIXED_CIU_CLK_DIV); > host->priv = priv; > return 0; > } > @@ -285,7 +388,7 @@ static inline void dw_mci_exynos_set_clksmpl(struct dw_mci *host, u8 sample) > clksel = mci_readl(host, CLKSEL64); > else > clksel = mci_readl(host, CLKSEL); > - clksel = (clksel & ~0x7) | SDMMC_CLKSEL_CCLK_SAMPLE(sample); > + clksel = SDMMC_CLKSEL_UP_SAMPLE(clksel, sample); > if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS7 || > priv->ctrl_type == DW_MCI_TYPE_EXYNOS7_SMU) > mci_writel(host, CLKSEL64, clksel); > @@ -304,13 +407,16 @@ static inline u8 dw_mci_exynos_move_next_clksmpl(struct dw_mci *host) > clksel = mci_readl(host, CLKSEL64); > else > clksel = mci_readl(host, CLKSEL); > + > sample = (clksel + 1) & 0x7; > - clksel = (clksel & ~0x7) | sample; > + clksel = SDMMC_CLKSEL_UP_SAMPLE(clksel, sample); > + > if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS7 || > priv->ctrl_type == DW_MCI_TYPE_EXYNOS7_SMU) > mci_writel(host, CLKSEL64, clksel); > else > mci_writel(host, CLKSEL, clksel); > + > return sample; > } > > @@ -343,6 +449,7 @@ out: > static int dw_mci_exynos_execute_tuning(struct dw_mci_slot *slot) > { > struct dw_mci *host = slot->host; > + struct dw_mci_exynos_priv_data *priv = host->priv; > struct mmc_host *mmc = slot->mmc; > u8 start_smpl, smpl, candiates = 0; > s8 found = -1; > @@ -360,14 +467,27 @@ static int dw_mci_exynos_execute_tuning(struct dw_mci_slot *slot) > } while (start_smpl != smpl); > > found = dw_mci_exynos_get_best_clksmpl(candiates); > - if (found >= 0) > + if (found >= 0) { > dw_mci_exynos_set_clksmpl(host, found); > - else > + priv->tuned_sample = found; > + } else { > ret = -EIO; > + } > > return ret; > } > > +int dw_mci_exynos_prepare_hs400_tuning(struct dw_mci *host, > + struct mmc_ios *ios) > +{ > + struct dw_mci_exynos_priv_data *priv = host->priv; > + > + dw_mci_exynos_set_clksel_timing(host, priv->hs400_timing); > + dw_mci_exynos_adjust_clock(host, (ios->clock) << 1); > + > + return 0; > +} > + > /* Common capabilities of Exynos4/Exynos5 SoC */ > static unsigned long exynos_dwmmc_caps[4] = { > MMC_CAP_1_8V_DDR | MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23, > @@ -384,6 +504,7 @@ static const struct dw_mci_drv_data exynos_drv_data = { > .set_ios = dw_mci_exynos_set_ios, > .parse_dt = dw_mci_exynos_parse_dt, > .execute_tuning = dw_mci_exynos_execute_tuning, > + .prepare_hs400_tuning = dw_mci_exynos_prepare_hs400_tuning, > }; > > static const struct of_device_id dw_mci_exynos_match[] = { > diff --git a/drivers/mmc/host/dw_mmc-exynos.h b/drivers/mmc/host/dw_mmc-exynos.h > index 7872ce5..595c934 100644 > --- a/drivers/mmc/host/dw_mmc-exynos.h > +++ b/drivers/mmc/host/dw_mmc-exynos.h > @@ -12,20 +12,36 @@ > #ifndef _DW_MMC_EXYNOS_H_ > #define _DW_MMC_EXYNOS_H_ > > -/* Extended Register's Offset */ > #define SDMMC_CLKSEL 0x09C > #define SDMMC_CLKSEL64 0x0A8 > > +/* Extended Register's Offset */ > +#define SDMMC_HS400_DQS_EN 0x180 > +#define SDMMC_HS400_ASYNC_FIFO_CTRL 0x184 > +#define SDMMC_HS400_DLINE_CTRL 0x188 > + > /* CLKSEL register defines */ > #define SDMMC_CLKSEL_CCLK_SAMPLE(x) (((x) & 7) << 0) > #define SDMMC_CLKSEL_CCLK_DRIVE(x) (((x) & 7) << 16) > #define SDMMC_CLKSEL_CCLK_DIVIDER(x) (((x) & 7) << 24) > #define SDMMC_CLKSEL_GET_DRV_WD3(x) (((x) >> 16) & 0x7) > +#define SDMMC_CLKSEL_GET_DIV(x) (((x) >> 24) & 0x7) > +#define SDMMC_CLKSEL_UP_SAMPLE(x, y) (((x) & ~SDMMC_CLKSEL_CCLK_SAMPLE(7)) |\ > + SDMMC_CLKSEL_CCLK_SAMPLE(y)) > #define SDMMC_CLKSEL_TIMING(x, y, z) (SDMMC_CLKSEL_CCLK_SAMPLE(x) | \ > SDMMC_CLKSEL_CCLK_DRIVE(y) | \ > SDMMC_CLKSEL_CCLK_DIVIDER(z)) > +#define SDMMC_CLKSEL_TIMING_MASK SDMMC_CLKSEL_TIMING(0x7, 0x7, 0x7) > #define SDMMC_CLKSEL_WAKEUP_INT BIT(11) > > +/* RCLK_EN register defines */ > +#define DATA_STROBE_EN BIT(0) > +#define AXI_NON_BLOCKING_WR BIT(7) > + > +/* DLINE_CTRL register defines */ > +#define DQS_CTRL_RD_DELAY(x, y) (((x) & ~0x3FF) | ((y) & 0x3FF)) > +#define DQS_CTRL_GET_RD_DELAY(x) ((x) & 0x3FF) > + > /* Protector Register */ > #define SDMMC_EMMCP_BASE 0x1000 > #define SDMMC_MPSECURITY (SDMMC_EMMCP_BASE + 0x0010) > @@ -49,6 +65,7 @@ > /* Fixed clock divider */ > #define EXYNOS4210_FIXED_CIU_CLK_DIV 2 > #define EXYNOS4412_FIXED_CIU_CLK_DIV 4 > +#define HS400_FIXED_CIU_CLK_DIV 1 > > /* Minimal required clock frequency for cclkin, unit: HZ */ > #define EXYNOS_CCLKIN_MIN 50000000 > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 4d2e3c2..f30ef69 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -1084,7 +1084,8 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) > regs = mci_readl(slot->host, UHS_REG); > > /* DDR mode set */ > - if (ios->timing == MMC_TIMING_MMC_DDR52) > + if (ios->timing == MMC_TIMING_MMC_DDR52 || > + ios->timing == MMC_TIMING_MMC_HS400) > regs |= ((0x1 << slot->id) << 16); > else > regs &= ~((0x1 << slot->id) << 16); > @@ -1323,6 +1324,18 @@ static int dw_mci_execute_tuning(struct mmc_host *mmc, u32 opcode) > return err; > } > > +int dw_mci_prepare_hs400_tuning(struct mmc_host *mmc, struct mmc_ios *ios) > +{ > + struct dw_mci_slot *slot = mmc_priv(mmc); > + struct dw_mci *host = slot->host; > + const struct dw_mci_drv_data *drv_data = host->drv_data; > + > + if (drv_data && drv_data->prepare_hs400_tuning) > + return drv_data->prepare_hs400_tuning(host, ios); > + > + return 0; > +} > + > static const struct mmc_host_ops dw_mci_ops = { > .request = dw_mci_request, > .pre_req = dw_mci_pre_req, > @@ -1335,6 +1348,7 @@ static const struct mmc_host_ops dw_mci_ops = { > .card_busy = dw_mci_card_busy, > .start_signal_voltage_switch = dw_mci_switch_voltage, > .init_card = dw_mci_init_card, > + .prepare_hs400_tuning = dw_mci_prepare_hs400_tuning, > }; > > static void dw_mci_request_end(struct dw_mci *host, struct mmc_request *mrq) > diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h > index 18c4afe..d239867 100644 > --- a/drivers/mmc/host/dw_mmc.h > +++ b/drivers/mmc/host/dw_mmc.h > @@ -271,5 +271,7 @@ struct dw_mci_drv_data { > void (*set_ios)(struct dw_mci *host, struct mmc_ios *ios); > int (*parse_dt)(struct dw_mci *host); > int (*execute_tuning)(struct dw_mci_slot *slot); > + int (*prepare_hs400_tuning)(struct dw_mci *host, > + struct mmc_ios *ios); > }; > #endif /* _DW_MMC_H_ */ > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH V5 1/2] mmc: dw_mmc: exynos: Support eMMC's HS400 mode 2015-02-25 6:34 ` Jaehoon Chung @ 2015-02-25 8:12 ` Alim Akhtar 0 siblings, 0 replies; 15+ messages in thread From: Alim Akhtar @ 2015-02-25 8:12 UTC (permalink / raw) To: Jaehoon Chung Cc: Alim Akhtar, linux-mmc@vger.kernel.org, Chris Ball, Ulf Hansson, Seungwon Jeon, Douglas Anderson, kgene, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Abhilash Kesavan Thanks Jaehoon, On Wed, Feb 25, 2015 at 12:04 PM, Jaehoon Chung <jh80.chung@samsung.com> wrote: > Hi, Alim. > > Tested-by: Jaehoon Chung <jh80.chung@samsung.com> > Acked-by: Jaehoon Chung <jh80.chung@samsung.com> > > I will include this patch into my tree, and i will request pull to Ulf. > If any rebase is required, I won't be able to do so until march 9th, hope you can take care of such changes. > Thanks! > > Best Regards, > Jaehoon Chung > > On 01/29/2015 11:41 AM, Alim Akhtar wrote: >> From: Seungwon Jeon <tgih.jun@samsung.com> >> >> Implements HS400 mode support for exynos host driver. >> This also include some updates as new mode is added. >> >> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com> >> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> >> [Alim: addressed review comments] >> --- >> .../devicetree/bindings/mmc/exynos-dw-mshc.txt | 7 + >> drivers/mmc/host/dw_mmc-exynos.c | 185 ++++++++++++++++---- >> drivers/mmc/host/dw_mmc-exynos.h | 19 +- >> drivers/mmc/host/dw_mmc.c | 16 +- >> drivers/mmc/host/dw_mmc.h | 2 + >> 5 files changed, 195 insertions(+), 34 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt >> index ee4fc05..aad9844 100644 >> --- a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt >> +++ b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt >> @@ -36,6 +36,8 @@ Required Properties: >> in transmit mode and CIU clock phase shift value in receive mode for double >> data rate mode operation. Refer notes below for the order of the cells and the >> valid values. >> +* samsung,dw-mshc-hs400-timing: Specifies the value of CIU TX and RX clock phase >> + shift value for hs400 mode operation. >> >> Notes for the sdr-timing and ddr-timing values: >> >> @@ -50,6 +52,9 @@ Required Properties: >> - if CIU clock divider value is 0 (that is divide by 1), both tx and rx >> phase shift clocks should be 0. >> >> +* samsung,read-strobe-delay: RCLK (Data strobe) delay to control HS400 mode >> + (Latency value for delay line in Read path) >> + >> Required properties for a slot (Deprecated - Recommend to use one slot per host): >> >> * gpios: specifies a list of gpios used for command, clock and data bus. The >> @@ -82,5 +87,7 @@ Example: >> samsung,dw-mshc-ciu-div = <3>; >> samsung,dw-mshc-sdr-timing = <2 3>; >> samsung,dw-mshc-ddr-timing = <1 2>; >> + samsung,dw-mshc-hs400-timing = <0 2>; >> + samsung,read-strobe-delay = <90>; >> bus-width = <8>; >> }; >> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c >> index fe32948..0a56d76 100644 >> --- a/drivers/mmc/host/dw_mmc-exynos.c >> +++ b/drivers/mmc/host/dw_mmc-exynos.c >> @@ -40,7 +40,12 @@ struct dw_mci_exynos_priv_data { >> u8 ciu_div; >> u32 sdr_timing; >> u32 ddr_timing; >> + u32 hs400_timing; >> + u32 tuned_sample; >> u32 cur_speed; >> + u32 dqs_delay; >> + u32 saved_dqs_en; >> + u32 saved_strobe_ctrl; >> }; >> >> static struct dw_mci_exynos_compatible { >> @@ -71,6 +76,21 @@ static struct dw_mci_exynos_compatible { >> }, >> }; >> >> +static inline u8 dw_mci_exynos_get_ciu_div(struct dw_mci *host) >> +{ >> + struct dw_mci_exynos_priv_data *priv = host->priv; >> + >> + if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS4412) >> + return EXYNOS4412_FIXED_CIU_CLK_DIV; >> + else if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS4210) >> + return EXYNOS4210_FIXED_CIU_CLK_DIV; >> + else if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS7 || >> + priv->ctrl_type == DW_MCI_TYPE_EXYNOS7_SMU) >> + return SDMMC_CLKSEL_GET_DIV(mci_readl(host, CLKSEL64)) + 1; >> + else >> + return SDMMC_CLKSEL_GET_DIV(mci_readl(host, CLKSEL)) + 1; >> +} >> + >> static int dw_mci_exynos_priv_init(struct dw_mci *host) >> { >> struct dw_mci_exynos_priv_data *priv = host->priv; >> @@ -85,6 +105,16 @@ static int dw_mci_exynos_priv_init(struct dw_mci *host) >> SDMMC_MPSCTRL_NON_SECURE_WRITE_BIT); >> } >> >> + if (priv->ctrl_type >= DW_MCI_TYPE_EXYNOS5420) { >> + priv->saved_strobe_ctrl = mci_readl(host, HS400_DLINE_CTRL); >> + priv->saved_dqs_en = mci_readl(host, HS400_DQS_EN); >> + priv->saved_dqs_en |= AXI_NON_BLOCKING_WR; >> + mci_writel(host, HS400_DQS_EN, priv->saved_dqs_en); >> + if (!priv->dqs_delay) >> + priv->dqs_delay = >> + DQS_CTRL_GET_RD_DELAY(priv->saved_strobe_ctrl); >> + } >> + >> return 0; >> } >> >> @@ -97,6 +127,26 @@ static int dw_mci_exynos_setup_clock(struct dw_mci *host) >> return 0; >> } >> >> +static void dw_mci_exynos_set_clksel_timing(struct dw_mci *host, u32 timing) >> +{ >> + struct dw_mci_exynos_priv_data *priv = host->priv; >> + u32 clksel; >> + >> + if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS7 || >> + priv->ctrl_type == DW_MCI_TYPE_EXYNOS7_SMU) >> + clksel = mci_readl(host, CLKSEL64); >> + else >> + clksel = mci_readl(host, CLKSEL); >> + >> + clksel = (clksel & ~SDMMC_CLKSEL_TIMING_MASK) | timing; >> + >> + if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS7 || >> + priv->ctrl_type == DW_MCI_TYPE_EXYNOS7_SMU) >> + mci_writel(host, CLKSEL64, clksel); >> + else >> + mci_writel(host, CLKSEL, clksel); >> +} >> + >> #ifdef CONFIG_PM_SLEEP >> static int dw_mci_exynos_suspend(struct device *dev) >> { >> @@ -172,30 +222,38 @@ static void dw_mci_exynos_prepare_command(struct dw_mci *host, u32 *cmdr) >> } >> } >> >> -static void dw_mci_exynos_set_ios(struct dw_mci *host, struct mmc_ios *ios) >> +static void dw_mci_exynos_config_hs400(struct dw_mci *host, u32 timing) >> { >> struct dw_mci_exynos_priv_data *priv = host->priv; >> - unsigned int wanted = ios->clock; >> - unsigned long actual; >> - u8 div = priv->ciu_div + 1; >> + u32 dqs, strobe; >> >> - if (ios->timing == MMC_TIMING_MMC_DDR52) { >> - if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS7 || >> - priv->ctrl_type == DW_MCI_TYPE_EXYNOS7_SMU) >> - mci_writel(host, CLKSEL64, priv->ddr_timing); >> - else >> - mci_writel(host, CLKSEL, priv->ddr_timing); >> - /* Should be double rate for DDR mode */ >> - if (ios->bus_width == MMC_BUS_WIDTH_8) >> - wanted <<= 1; >> + /* >> + * Not supported to configure register >> + * related to HS400 >> + */ >> + if (priv->ctrl_type < DW_MCI_TYPE_EXYNOS5420) >> + return; >> + >> + dqs = priv->saved_dqs_en; >> + strobe = priv->saved_strobe_ctrl; >> + >> + if (timing == MMC_TIMING_MMC_HS400) { >> + dqs |= DATA_STROBE_EN; >> + strobe = DQS_CTRL_RD_DELAY(strobe, priv->dqs_delay); >> } else { >> - if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS7 || >> - priv->ctrl_type == DW_MCI_TYPE_EXYNOS7_SMU) >> - mci_writel(host, CLKSEL64, priv->sdr_timing); >> - else >> - mci_writel(host, CLKSEL, priv->sdr_timing); >> + dqs &= ~DATA_STROBE_EN; >> } >> >> + mci_writel(host, HS400_DQS_EN, dqs); >> + mci_writel(host, HS400_DLINE_CTRL, strobe); >> +} >> + >> +static void dw_mci_exynos_adjust_clock(struct dw_mci *host, unsigned int wanted) >> +{ >> + struct dw_mci_exynos_priv_data *priv = host->priv; >> + unsigned long actual; >> + u8 div; >> + int ret; >> /* >> * Don't care if wanted clock is zero or >> * ciu clock is unavailable >> @@ -207,17 +265,52 @@ static void dw_mci_exynos_set_ios(struct dw_mci *host, struct mmc_ios *ios) >> if (wanted < EXYNOS_CCLKIN_MIN) >> wanted = EXYNOS_CCLKIN_MIN; >> >> - if (wanted != priv->cur_speed) { >> - int ret = clk_set_rate(host->ciu_clk, wanted * div); >> - if (ret) >> - dev_warn(host->dev, >> - "failed to set clk-rate %u error: %d\n", >> - wanted * div, ret); >> - actual = clk_get_rate(host->ciu_clk); >> - host->bus_hz = actual / div; >> - priv->cur_speed = wanted; >> - host->current_speed = 0; >> + if (wanted == priv->cur_speed) >> + return; >> + >> + div = dw_mci_exynos_get_ciu_div(host); >> + ret = clk_set_rate(host->ciu_clk, wanted * div); >> + if (ret) >> + dev_warn(host->dev, >> + "failed to set clk-rate %u error: %d\n", >> + wanted * div, ret); >> + actual = clk_get_rate(host->ciu_clk); >> + host->bus_hz = actual / div; >> + priv->cur_speed = wanted; >> + host->current_speed = 0; >> +} >> + >> +static void dw_mci_exynos_set_ios(struct dw_mci *host, struct mmc_ios *ios) >> +{ >> + struct dw_mci_exynos_priv_data *priv = host->priv; >> + unsigned int wanted = ios->clock; >> + u32 timing = ios->timing, clksel; >> + >> + switch (timing) { >> + case MMC_TIMING_MMC_HS400: >> + /* Update tuned sample timing */ >> + clksel = SDMMC_CLKSEL_UP_SAMPLE( >> + priv->hs400_timing, priv->tuned_sample); >> + wanted <<= 1; >> + break; >> + case MMC_TIMING_MMC_DDR52: >> + clksel = priv->ddr_timing; >> + /* Should be double rate for DDR mode */ >> + if (ios->bus_width == MMC_BUS_WIDTH_8) >> + wanted <<= 1; >> + break; >> + default: >> + clksel = priv->sdr_timing; >> } >> + >> + /* Set clock timing for the requested speed mode*/ >> + dw_mci_exynos_set_clksel_timing(host, clksel); >> + >> + /* Configure setting for HS400 */ >> + dw_mci_exynos_config_hs400(host, timing); >> + >> + /* Configure clock rate */ >> + dw_mci_exynos_adjust_clock(host, wanted); >> } >> >> static int dw_mci_exynos_parse_dt(struct dw_mci *host) >> @@ -260,6 +353,16 @@ static int dw_mci_exynos_parse_dt(struct dw_mci *host) >> return ret; >> >> priv->ddr_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], div); >> + >> + ret = of_property_read_u32_array(np, >> + "samsung,dw-mshc-hs400-timing", timing, 2); >> + if (!ret && of_property_read_u32(np, >> + "samsung,read-strobe-delay", &priv->dqs_delay)) >> + dev_dbg(host->dev, >> + "read-strobe-delay is not found, assuming usage of default value\n"); >> + >> + priv->hs400_timing = SDMMC_CLKSEL_TIMING(timing[0], timing[1], >> + HS400_FIXED_CIU_CLK_DIV); >> host->priv = priv; >> return 0; >> } >> @@ -285,7 +388,7 @@ static inline void dw_mci_exynos_set_clksmpl(struct dw_mci *host, u8 sample) >> clksel = mci_readl(host, CLKSEL64); >> else >> clksel = mci_readl(host, CLKSEL); >> - clksel = (clksel & ~0x7) | SDMMC_CLKSEL_CCLK_SAMPLE(sample); >> + clksel = SDMMC_CLKSEL_UP_SAMPLE(clksel, sample); >> if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS7 || >> priv->ctrl_type == DW_MCI_TYPE_EXYNOS7_SMU) >> mci_writel(host, CLKSEL64, clksel); >> @@ -304,13 +407,16 @@ static inline u8 dw_mci_exynos_move_next_clksmpl(struct dw_mci *host) >> clksel = mci_readl(host, CLKSEL64); >> else >> clksel = mci_readl(host, CLKSEL); >> + >> sample = (clksel + 1) & 0x7; >> - clksel = (clksel & ~0x7) | sample; >> + clksel = SDMMC_CLKSEL_UP_SAMPLE(clksel, sample); >> + >> if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS7 || >> priv->ctrl_type == DW_MCI_TYPE_EXYNOS7_SMU) >> mci_writel(host, CLKSEL64, clksel); >> else >> mci_writel(host, CLKSEL, clksel); >> + >> return sample; >> } >> >> @@ -343,6 +449,7 @@ out: >> static int dw_mci_exynos_execute_tuning(struct dw_mci_slot *slot) >> { >> struct dw_mci *host = slot->host; >> + struct dw_mci_exynos_priv_data *priv = host->priv; >> struct mmc_host *mmc = slot->mmc; >> u8 start_smpl, smpl, candiates = 0; >> s8 found = -1; >> @@ -360,14 +467,27 @@ static int dw_mci_exynos_execute_tuning(struct dw_mci_slot *slot) >> } while (start_smpl != smpl); >> >> found = dw_mci_exynos_get_best_clksmpl(candiates); >> - if (found >= 0) >> + if (found >= 0) { >> dw_mci_exynos_set_clksmpl(host, found); >> - else >> + priv->tuned_sample = found; >> + } else { >> ret = -EIO; >> + } >> >> return ret; >> } >> >> +int dw_mci_exynos_prepare_hs400_tuning(struct dw_mci *host, >> + struct mmc_ios *ios) >> +{ >> + struct dw_mci_exynos_priv_data *priv = host->priv; >> + >> + dw_mci_exynos_set_clksel_timing(host, priv->hs400_timing); >> + dw_mci_exynos_adjust_clock(host, (ios->clock) << 1); >> + >> + return 0; >> +} >> + >> /* Common capabilities of Exynos4/Exynos5 SoC */ >> static unsigned long exynos_dwmmc_caps[4] = { >> MMC_CAP_1_8V_DDR | MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23, >> @@ -384,6 +504,7 @@ static const struct dw_mci_drv_data exynos_drv_data = { >> .set_ios = dw_mci_exynos_set_ios, >> .parse_dt = dw_mci_exynos_parse_dt, >> .execute_tuning = dw_mci_exynos_execute_tuning, >> + .prepare_hs400_tuning = dw_mci_exynos_prepare_hs400_tuning, >> }; >> >> static const struct of_device_id dw_mci_exynos_match[] = { >> diff --git a/drivers/mmc/host/dw_mmc-exynos.h b/drivers/mmc/host/dw_mmc-exynos.h >> index 7872ce5..595c934 100644 >> --- a/drivers/mmc/host/dw_mmc-exynos.h >> +++ b/drivers/mmc/host/dw_mmc-exynos.h >> @@ -12,20 +12,36 @@ >> #ifndef _DW_MMC_EXYNOS_H_ >> #define _DW_MMC_EXYNOS_H_ >> >> -/* Extended Register's Offset */ >> #define SDMMC_CLKSEL 0x09C >> #define SDMMC_CLKSEL64 0x0A8 >> >> +/* Extended Register's Offset */ >> +#define SDMMC_HS400_DQS_EN 0x180 >> +#define SDMMC_HS400_ASYNC_FIFO_CTRL 0x184 >> +#define SDMMC_HS400_DLINE_CTRL 0x188 >> + >> /* CLKSEL register defines */ >> #define SDMMC_CLKSEL_CCLK_SAMPLE(x) (((x) & 7) << 0) >> #define SDMMC_CLKSEL_CCLK_DRIVE(x) (((x) & 7) << 16) >> #define SDMMC_CLKSEL_CCLK_DIVIDER(x) (((x) & 7) << 24) >> #define SDMMC_CLKSEL_GET_DRV_WD3(x) (((x) >> 16) & 0x7) >> +#define SDMMC_CLKSEL_GET_DIV(x) (((x) >> 24) & 0x7) >> +#define SDMMC_CLKSEL_UP_SAMPLE(x, y) (((x) & ~SDMMC_CLKSEL_CCLK_SAMPLE(7)) |\ >> + SDMMC_CLKSEL_CCLK_SAMPLE(y)) >> #define SDMMC_CLKSEL_TIMING(x, y, z) (SDMMC_CLKSEL_CCLK_SAMPLE(x) | \ >> SDMMC_CLKSEL_CCLK_DRIVE(y) | \ >> SDMMC_CLKSEL_CCLK_DIVIDER(z)) >> +#define SDMMC_CLKSEL_TIMING_MASK SDMMC_CLKSEL_TIMING(0x7, 0x7, 0x7) >> #define SDMMC_CLKSEL_WAKEUP_INT BIT(11) >> >> +/* RCLK_EN register defines */ >> +#define DATA_STROBE_EN BIT(0) >> +#define AXI_NON_BLOCKING_WR BIT(7) >> + >> +/* DLINE_CTRL register defines */ >> +#define DQS_CTRL_RD_DELAY(x, y) (((x) & ~0x3FF) | ((y) & 0x3FF)) >> +#define DQS_CTRL_GET_RD_DELAY(x) ((x) & 0x3FF) >> + >> /* Protector Register */ >> #define SDMMC_EMMCP_BASE 0x1000 >> #define SDMMC_MPSECURITY (SDMMC_EMMCP_BASE + 0x0010) >> @@ -49,6 +65,7 @@ >> /* Fixed clock divider */ >> #define EXYNOS4210_FIXED_CIU_CLK_DIV 2 >> #define EXYNOS4412_FIXED_CIU_CLK_DIV 4 >> +#define HS400_FIXED_CIU_CLK_DIV 1 >> >> /* Minimal required clock frequency for cclkin, unit: HZ */ >> #define EXYNOS_CCLKIN_MIN 50000000 >> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c >> index 4d2e3c2..f30ef69 100644 >> --- a/drivers/mmc/host/dw_mmc.c >> +++ b/drivers/mmc/host/dw_mmc.c >> @@ -1084,7 +1084,8 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) >> regs = mci_readl(slot->host, UHS_REG); >> >> /* DDR mode set */ >> - if (ios->timing == MMC_TIMING_MMC_DDR52) >> + if (ios->timing == MMC_TIMING_MMC_DDR52 || >> + ios->timing == MMC_TIMING_MMC_HS400) >> regs |= ((0x1 << slot->id) << 16); >> else >> regs &= ~((0x1 << slot->id) << 16); >> @@ -1323,6 +1324,18 @@ static int dw_mci_execute_tuning(struct mmc_host *mmc, u32 opcode) >> return err; >> } >> >> +int dw_mci_prepare_hs400_tuning(struct mmc_host *mmc, struct mmc_ios *ios) >> +{ >> + struct dw_mci_slot *slot = mmc_priv(mmc); >> + struct dw_mci *host = slot->host; >> + const struct dw_mci_drv_data *drv_data = host->drv_data; >> + >> + if (drv_data && drv_data->prepare_hs400_tuning) >> + return drv_data->prepare_hs400_tuning(host, ios); >> + >> + return 0; >> +} >> + >> static const struct mmc_host_ops dw_mci_ops = { >> .request = dw_mci_request, >> .pre_req = dw_mci_pre_req, >> @@ -1335,6 +1348,7 @@ static const struct mmc_host_ops dw_mci_ops = { >> .card_busy = dw_mci_card_busy, >> .start_signal_voltage_switch = dw_mci_switch_voltage, >> .init_card = dw_mci_init_card, >> + .prepare_hs400_tuning = dw_mci_prepare_hs400_tuning, >> }; >> >> static void dw_mci_request_end(struct dw_mci *host, struct mmc_request *mrq) >> diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h >> index 18c4afe..d239867 100644 >> --- a/drivers/mmc/host/dw_mmc.h >> +++ b/drivers/mmc/host/dw_mmc.h >> @@ -271,5 +271,7 @@ struct dw_mci_drv_data { >> void (*set_ios)(struct dw_mci *host, struct mmc_ios *ios); >> int (*parse_dt)(struct dw_mci *host); >> int (*execute_tuning)(struct dw_mci_slot *slot); >> + int (*prepare_hs400_tuning)(struct dw_mci *host, >> + struct mmc_ios *ios); >> }; >> #endif /* _DW_MMC_H_ */ >> > -- Regards, Alim ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH V5 1/2] mmc: dw_mmc: exynos: Support eMMC's HS400 mode 2015-01-29 2:41 ` [PATCH V5 1/2] mmc: dw_mmc: exynos: Support eMMC's HS400 mode Alim Akhtar 2015-02-25 6:34 ` Jaehoon Chung @ 2015-02-25 14:38 ` Rob Herring 2015-02-26 1:22 ` Jaehoon Chung 1 sibling, 1 reply; 15+ messages in thread From: Rob Herring @ 2015-02-25 14:38 UTC (permalink / raw) To: Alim Akhtar Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, Ulf Hansson, linux-samsung-soc@vger.kernel.org, Seungwon Jeon, chris@printf.net, Doug Anderson, Jaehoon Chung, kgene@kernel.org, a.kesavan, alim.akhtar, linux-arm-kernel@lists.infradead.org On Wed, Jan 28, 2015 at 8:41 PM, Alim Akhtar <alim.akhtar@samsung.com> wrote: > From: Seungwon Jeon <tgih.jun@samsung.com> > > Implements HS400 mode support for exynos host driver. > This also include some updates as new mode is added. > > Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > [Alim: addressed review comments] > --- > .../devicetree/bindings/mmc/exynos-dw-mshc.txt | 7 + > drivers/mmc/host/dw_mmc-exynos.c | 185 ++++++++++++++++---- > drivers/mmc/host/dw_mmc-exynos.h | 19 +- > drivers/mmc/host/dw_mmc.c | 16 +- > drivers/mmc/host/dw_mmc.h | 2 + > 5 files changed, 195 insertions(+), 34 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt > index ee4fc05..aad9844 100644 > --- a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt > +++ b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt > @@ -36,6 +36,8 @@ Required Properties: > in transmit mode and CIU clock phase shift value in receive mode for double > data rate mode operation. Refer notes below for the order of the cells and the > valid values. > +* samsung,dw-mshc-hs400-timing: Specifies the value of CIU TX and RX clock phase > + shift value for hs400 mode operation. What are the units? Rob ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH V5 1/2] mmc: dw_mmc: exynos: Support eMMC's HS400 mode 2015-02-25 14:38 ` Rob Herring @ 2015-02-26 1:22 ` Jaehoon Chung 0 siblings, 0 replies; 15+ messages in thread From: Jaehoon Chung @ 2015-02-26 1:22 UTC (permalink / raw) To: Rob Herring, Alim Akhtar Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, Ulf Hansson, linux-samsung-soc@vger.kernel.org, Seungwon Jeon, chris@printf.net, Doug Anderson, kgene@kernel.org, a.kesavan, alim.akhtar, linux-arm-kernel@lists.infradead.org Dear, Rob. On 02/25/2015 11:38 PM, Rob Herring wrote: > On Wed, Jan 28, 2015 at 8:41 PM, Alim Akhtar <alim.akhtar@samsung.com> wrote: >> From: Seungwon Jeon <tgih.jun@samsung.com> >> >> Implements HS400 mode support for exynos host driver. >> This also include some updates as new mode is added. >> >> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com> >> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> >> [Alim: addressed review comments] >> --- >> .../devicetree/bindings/mmc/exynos-dw-mshc.txt | 7 + >> drivers/mmc/host/dw_mmc-exynos.c | 185 ++++++++++++++++---- >> drivers/mmc/host/dw_mmc-exynos.h | 19 +- >> drivers/mmc/host/dw_mmc.c | 16 +- >> drivers/mmc/host/dw_mmc.h | 2 + >> 5 files changed, 195 insertions(+), 34 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt >> index ee4fc05..aad9844 100644 >> --- a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt >> +++ b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt >> @@ -36,6 +36,8 @@ Required Properties: >> in transmit mode and CIU clock phase shift value in receive mode for double >> data rate mode operation. Refer notes below for the order of the cells and the >> valid values. >> +* samsung,dw-mshc-hs400-timing: Specifies the value of CIU TX and RX clock phase >> + shift value for hs400 mode operation. > > What are the units? Do you means what is "sumsung,dw-mshci-hs400-timing" unit? It's timing value for eMMC/SD/SDIO clock phase.(It's exynos specific value.) Using timing value can shift the H/W clock phase. If invalid timing value is set, eMMC/SD/SDIO can produce the CRC error. Do you think it can't include into device-tree? I want to know your thinking. let me know, plz. Best Regards, Jaehoon Chung > > Rob > ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH V5 2/2] ARM: dts: Add HS400 support for exynos5420 and exynos5800 2015-01-29 2:41 [PATCH v5 0/2] mmc: dw_mmc: exynos: Add HS400 support Alim Akhtar 2015-01-29 2:41 ` [PATCH V5 1/2] mmc: dw_mmc: exynos: Support eMMC's HS400 mode Alim Akhtar @ 2015-01-29 2:41 ` Alim Akhtar 2015-02-25 6:35 ` Jaehoon Chung 2015-02-06 1:18 ` [PATCH v5 0/2] mmc: dw_mmc: exynos: Add HS400 support Jaehoon Chung 2 siblings, 1 reply; 15+ messages in thread From: Alim Akhtar @ 2015-01-29 2:41 UTC (permalink / raw) To: linux-mmc Cc: chris, ulf.hansson, jh80.chung, tgih.jun, dianders, alim.akhtar, kgene, linux-arm-kernel, devicetree, linux-samsung-soc, a.kesavan, alim.akhtar From: Seungwon Jeon <tgih.jun@samsung.com> HS400 timing values are added for SMDK5420, exynos5420-peach-pit and exynos5800-peach-pi boards. This also adds RCLK GPIO line, this gpio should be in pull-down state. This also enables HS400 on peach-pi and this updates the clock frequency to 800MHz to be set as input clock to controller. Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> [Alim: addressed review comments] --- arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +++- arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 +++++++ arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 +++- arch/arm/boot/dts/exynos5800-peach-pi.dts | 7 +++++-- 4 files changed, 18 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts index 9a050e1..f7a44a4 100644 --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts @@ -569,8 +569,10 @@ samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; + samsung,dw-mshc-hs400-timing = <0 2>; + samsung,read-strobe-delay = <90>; pinctrl-names = "default"; - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; bus-width = <8>; }; diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi index ba686e4..8b15316 100644 --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi @@ -201,6 +201,13 @@ samsung,pin-drv = <3>; }; + sd0_rclk: sd0-rclk { + samsung,pins = "gpc0-7"; + samsung,pin-function = <2>; + samsung,pin-pud = <1>; + samsung,pin-drv = <3>; + }; + sd1_cmd: sd1-cmd { samsung,pins = "gpc1-1"; samsung,pin-function = <2>; diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts index 8be3d7b..2078a1f 100644 --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts @@ -80,8 +80,10 @@ samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; + samsung,dw-mshc-hs400-timing = <0 2>; + samsung,read-strobe-delay = <90>; pinctrl-names = "default"; - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; bus-width = <8>; cap-mmc-highspeed; }; diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts index e8fdda8..96f0d61 100644 --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts @@ -550,15 +550,18 @@ num-slots = <1>; broken-cd; mmc-hs200-1_8v; + mmc-hs400-1_8v; cap-mmc-highspeed; non-removable; card-detect-delay = <200>; - clock-frequency = <400000000>; + clock-frequency = <800000000>; samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; + samsung,dw-mshc-hs400-timing = <0 2>; + samsung,read-strobe-delay = <90>; pinctrl-names = "default"; - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; bus-width = <8>; }; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH V5 2/2] ARM: dts: Add HS400 support for exynos5420 and exynos5800 2015-01-29 2:41 ` [PATCH V5 2/2] ARM: dts: Add HS400 support for exynos5420 and exynos5800 Alim Akhtar @ 2015-02-25 6:35 ` Jaehoon Chung 2015-03-15 11:28 ` Alim Akhtar 0 siblings, 1 reply; 15+ messages in thread From: Jaehoon Chung @ 2015-02-25 6:35 UTC (permalink / raw) To: Alim Akhtar, linux-mmc Cc: chris, ulf.hansson, tgih.jun, dianders, alim.akhtar, kgene, linux-arm-kernel, devicetree, linux-samsung-soc, a.kesavan Hi, Alim. Acked-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung On 01/29/2015 11:41 AM, Alim Akhtar wrote: > From: Seungwon Jeon <tgih.jun@samsung.com> > > HS400 timing values are added for SMDK5420, exynos5420-peach-pit > and exynos5800-peach-pi boards. > This also adds RCLK GPIO line, this gpio should be in pull-down > state. > This also enables HS400 on peach-pi and this updates the clock frequency > to 800MHz to be set as input clock to controller. > > Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > [Alim: addressed review comments] > --- > arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +++- > arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 +++++++ > arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 +++- > arch/arm/boot/dts/exynos5800-peach-pi.dts | 7 +++++-- > 4 files changed, 18 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts > index 9a050e1..f7a44a4 100644 > --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts > +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts > @@ -569,8 +569,10 @@ > samsung,dw-mshc-ciu-div = <3>; > samsung,dw-mshc-sdr-timing = <0 4>; > samsung,dw-mshc-ddr-timing = <0 2>; > + samsung,dw-mshc-hs400-timing = <0 2>; > + samsung,read-strobe-delay = <90>; > pinctrl-names = "default"; > - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; > + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; > bus-width = <8>; > }; > > diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi > index ba686e4..8b15316 100644 > --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi > +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi > @@ -201,6 +201,13 @@ > samsung,pin-drv = <3>; > }; > > + sd0_rclk: sd0-rclk { > + samsung,pins = "gpc0-7"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <1>; > + samsung,pin-drv = <3>; > + }; > + > sd1_cmd: sd1-cmd { > samsung,pins = "gpc1-1"; > samsung,pin-function = <2>; > diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts > index 8be3d7b..2078a1f 100644 > --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts > +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts > @@ -80,8 +80,10 @@ > samsung,dw-mshc-ciu-div = <3>; > samsung,dw-mshc-sdr-timing = <0 4>; > samsung,dw-mshc-ddr-timing = <0 2>; > + samsung,dw-mshc-hs400-timing = <0 2>; > + samsung,read-strobe-delay = <90>; > pinctrl-names = "default"; > - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; > + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; > bus-width = <8>; > cap-mmc-highspeed; > }; > diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts > index e8fdda8..96f0d61 100644 > --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts > +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts > @@ -550,15 +550,18 @@ > num-slots = <1>; > broken-cd; > mmc-hs200-1_8v; > + mmc-hs400-1_8v; > cap-mmc-highspeed; > non-removable; > card-detect-delay = <200>; > - clock-frequency = <400000000>; > + clock-frequency = <800000000>; > samsung,dw-mshc-ciu-div = <3>; > samsung,dw-mshc-sdr-timing = <0 4>; > samsung,dw-mshc-ddr-timing = <0 2>; > + samsung,dw-mshc-hs400-timing = <0 2>; > + samsung,read-strobe-delay = <90>; > pinctrl-names = "default"; > - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; > + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; > bus-width = <8>; > }; > > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH V5 2/2] ARM: dts: Add HS400 support for exynos5420 and exynos5800 2015-02-25 6:35 ` Jaehoon Chung @ 2015-03-15 11:28 ` Alim Akhtar 2015-03-17 2:12 ` Kukjin Kim 0 siblings, 1 reply; 15+ messages in thread From: Alim Akhtar @ 2015-03-15 11:28 UTC (permalink / raw) To: Jaehoon Chung Cc: Alim Akhtar, linux-mmc@vger.kernel.org, Chris Ball, Ulf Hansson, Seungwon Jeon, Douglas Anderson, kgene, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Abhilash Kesavan Ping? On Wed, Feb 25, 2015 at 12:05 PM, Jaehoon Chung <jh80.chung@samsung.com> wrote: > Hi, Alim. > > Acked-by: Jaehoon Chung <jh80.chung@samsung.com> > > Best Regards, > Jaehoon Chung > > On 01/29/2015 11:41 AM, Alim Akhtar wrote: >> From: Seungwon Jeon <tgih.jun@samsung.com> >> >> HS400 timing values are added for SMDK5420, exynos5420-peach-pit >> and exynos5800-peach-pi boards. >> This also adds RCLK GPIO line, this gpio should be in pull-down >> state. >> This also enables HS400 on peach-pi and this updates the clock frequency >> to 800MHz to be set as input clock to controller. >> >> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com> >> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> >> [Alim: addressed review comments] >> --- >> arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +++- >> arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 +++++++ >> arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 +++- >> arch/arm/boot/dts/exynos5800-peach-pi.dts | 7 +++++-- >> 4 files changed, 18 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> index 9a050e1..f7a44a4 100644 >> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts >> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> @@ -569,8 +569,10 @@ >> samsung,dw-mshc-ciu-div = <3>; >> samsung,dw-mshc-sdr-timing = <0 4>; >> samsung,dw-mshc-ddr-timing = <0 2>; >> + samsung,dw-mshc-hs400-timing = <0 2>; >> + samsung,read-strobe-delay = <90>; >> pinctrl-names = "default"; >> - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; >> + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; >> bus-width = <8>; >> }; >> >> diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi >> index ba686e4..8b15316 100644 >> --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi >> +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi >> @@ -201,6 +201,13 @@ >> samsung,pin-drv = <3>; >> }; >> >> + sd0_rclk: sd0-rclk { >> + samsung,pins = "gpc0-7"; >> + samsung,pin-function = <2>; >> + samsung,pin-pud = <1>; >> + samsung,pin-drv = <3>; >> + }; >> + >> sd1_cmd: sd1-cmd { >> samsung,pins = "gpc1-1"; >> samsung,pin-function = <2>; >> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts >> index 8be3d7b..2078a1f 100644 >> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts >> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts >> @@ -80,8 +80,10 @@ >> samsung,dw-mshc-ciu-div = <3>; >> samsung,dw-mshc-sdr-timing = <0 4>; >> samsung,dw-mshc-ddr-timing = <0 2>; >> + samsung,dw-mshc-hs400-timing = <0 2>; >> + samsung,read-strobe-delay = <90>; >> pinctrl-names = "default"; >> - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; >> + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; >> bus-width = <8>; >> cap-mmc-highspeed; >> }; >> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts >> index e8fdda8..96f0d61 100644 >> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts >> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts >> @@ -550,15 +550,18 @@ >> num-slots = <1>; >> broken-cd; >> mmc-hs200-1_8v; >> + mmc-hs400-1_8v; >> cap-mmc-highspeed; >> non-removable; >> card-detect-delay = <200>; >> - clock-frequency = <400000000>; >> + clock-frequency = <800000000>; >> samsung,dw-mshc-ciu-div = <3>; >> samsung,dw-mshc-sdr-timing = <0 4>; >> samsung,dw-mshc-ddr-timing = <0 2>; >> + samsung,dw-mshc-hs400-timing = <0 2>; >> + samsung,read-strobe-delay = <90>; >> pinctrl-names = "default"; >> - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; >> + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; >> bus-width = <8>; >> }; >> >> > -- Regards, Alim ^ permalink raw reply [flat|nested] 15+ messages in thread
* RE: [PATCH V5 2/2] ARM: dts: Add HS400 support for exynos5420 and exynos5800 2015-03-15 11:28 ` Alim Akhtar @ 2015-03-17 2:12 ` Kukjin Kim 2015-03-17 23:26 ` Alim Akhtar 0 siblings, 1 reply; 15+ messages in thread From: Kukjin Kim @ 2015-03-17 2:12 UTC (permalink / raw) To: 'Alim Akhtar', 'Jaehoon Chung' Cc: devicetree, 'Ulf Hansson', linux-samsung-soc, 'Seungwon Jeon', linux-mmc, 'Chris Ball', 'Douglas Anderson', 'kgene', 'Alim Akhtar', 'Abhilash Kesavan', linux-arm-kernel Alim Akhtar wrote: > > Ping? > Alim, Can you please re-send it based on latest my tree? It would be helpful for me ;) Thanks, Kukjin > On Wed, Feb 25, 2015 at 12:05 PM, Jaehoon Chung <jh80.chung@samsung.com> wrote: > > Hi, Alim. > > > > Acked-by: Jaehoon Chung <jh80.chung@samsung.com> > > > > Best Regards, > > Jaehoon Chung > > > > On 01/29/2015 11:41 AM, Alim Akhtar wrote: > >> From: Seungwon Jeon <tgih.jun@samsung.com> > >> > >> HS400 timing values are added for SMDK5420, exynos5420-peach-pit > >> and exynos5800-peach-pi boards. > >> This also adds RCLK GPIO line, this gpio should be in pull-down > >> state. > >> This also enables HS400 on peach-pi and this updates the clock frequency > >> to 800MHz to be set as input clock to controller. > >> > >> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com> > >> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > >> [Alim: addressed review comments] > >> --- > >> arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +++- > >> arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 +++++++ > >> arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 +++- > >> arch/arm/boot/dts/exynos5800-peach-pi.dts | 7 +++++-- > >> 4 files changed, 18 insertions(+), 4 deletions(-) > >> > >> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach- > pit.dts > >> index 9a050e1..f7a44a4 100644 > >> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts > >> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts > >> @@ -569,8 +569,10 @@ > >> samsung,dw-mshc-ciu-div = <3>; > >> samsung,dw-mshc-sdr-timing = <0 4>; > >> samsung,dw-mshc-ddr-timing = <0 2>; > >> + samsung,dw-mshc-hs400-timing = <0 2>; > >> + samsung,read-strobe-delay = <90>; > >> pinctrl-names = "default"; > >> - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; > >> + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; > >> bus-width = <8>; > >> }; > >> > >> diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi > >> index ba686e4..8b15316 100644 > >> --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi > >> +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi > >> @@ -201,6 +201,13 @@ > >> samsung,pin-drv = <3>; > >> }; > >> > >> + sd0_rclk: sd0-rclk { > >> + samsung,pins = "gpc0-7"; > >> + samsung,pin-function = <2>; > >> + samsung,pin-pud = <1>; > >> + samsung,pin-drv = <3>; > >> + }; > >> + > >> sd1_cmd: sd1-cmd { > >> samsung,pins = "gpc1-1"; > >> samsung,pin-function = <2>; > >> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts > >> index 8be3d7b..2078a1f 100644 > >> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts > >> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts > >> @@ -80,8 +80,10 @@ > >> samsung,dw-mshc-ciu-div = <3>; > >> samsung,dw-mshc-sdr-timing = <0 4>; > >> samsung,dw-mshc-ddr-timing = <0 2>; > >> + samsung,dw-mshc-hs400-timing = <0 2>; > >> + samsung,read-strobe-delay = <90>; > >> pinctrl-names = "default"; > >> - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; > >> + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; > >> bus-width = <8>; > >> cap-mmc-highspeed; > >> }; > >> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts > >> index e8fdda8..96f0d61 100644 > >> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts > >> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts > >> @@ -550,15 +550,18 @@ > >> num-slots = <1>; > >> broken-cd; > >> mmc-hs200-1_8v; > >> + mmc-hs400-1_8v; > >> cap-mmc-highspeed; > >> non-removable; > >> card-detect-delay = <200>; > >> - clock-frequency = <400000000>; > >> + clock-frequency = <800000000>; > >> samsung,dw-mshc-ciu-div = <3>; > >> samsung,dw-mshc-sdr-timing = <0 4>; > >> samsung,dw-mshc-ddr-timing = <0 2>; > >> + samsung,dw-mshc-hs400-timing = <0 2>; > >> + samsung,read-strobe-delay = <90>; > >> pinctrl-names = "default"; > >> - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; > >> + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; > >> bus-width = <8>; > >> }; ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH V5 2/2] ARM: dts: Add HS400 support for exynos5420 and exynos5800 2015-03-17 2:12 ` Kukjin Kim @ 2015-03-17 23:26 ` Alim Akhtar 0 siblings, 0 replies; 15+ messages in thread From: Alim Akhtar @ 2015-03-17 23:26 UTC (permalink / raw) To: Kukjin Kim Cc: Jaehoon Chung, devicetree@vger.kernel.org, Ulf Hansson, linux-samsung-soc@vger.kernel.org, Seungwon Jeon, linux-mmc@vger.kernel.org, Chris Ball, Douglas Anderson, Alim Akhtar, Abhilash Kesavan, linux-arm-kernel@lists.infradead.org Thanks Kukjin for looking into this. I will rebase on top of your for-next and send again. On Tue, Mar 17, 2015 at 7:42 AM, Kukjin Kim <kgene@kernel.org> wrote: > Alim Akhtar wrote: >> >> Ping? >> > Alim, > > Can you please re-send it based on latest my tree? > It would be helpful for me ;) > > Thanks, > Kukjin > >> On Wed, Feb 25, 2015 at 12:05 PM, Jaehoon Chung <jh80.chung@samsung.com> wrote: >> > Hi, Alim. >> > >> > Acked-by: Jaehoon Chung <jh80.chung@samsung.com> >> > >> > Best Regards, >> > Jaehoon Chung >> > >> > On 01/29/2015 11:41 AM, Alim Akhtar wrote: >> >> From: Seungwon Jeon <tgih.jun@samsung.com> >> >> >> >> HS400 timing values are added for SMDK5420, exynos5420-peach-pit >> >> and exynos5800-peach-pi boards. >> >> This also adds RCLK GPIO line, this gpio should be in pull-down >> >> state. >> >> This also enables HS400 on peach-pi and this updates the clock frequency >> >> to 800MHz to be set as input clock to controller. >> >> >> >> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com> >> >> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> >> >> [Alim: addressed review comments] >> >> --- >> >> arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +++- >> >> arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 +++++++ >> >> arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 +++- >> >> arch/arm/boot/dts/exynos5800-peach-pi.dts | 7 +++++-- >> >> 4 files changed, 18 insertions(+), 4 deletions(-) >> >> >> >> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach- >> pit.dts >> >> index 9a050e1..f7a44a4 100644 >> >> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts >> >> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> >> @@ -569,8 +569,10 @@ >> >> samsung,dw-mshc-ciu-div = <3>; >> >> samsung,dw-mshc-sdr-timing = <0 4>; >> >> samsung,dw-mshc-ddr-timing = <0 2>; >> >> + samsung,dw-mshc-hs400-timing = <0 2>; >> >> + samsung,read-strobe-delay = <90>; >> >> pinctrl-names = "default"; >> >> - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; >> >> + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; >> >> bus-width = <8>; >> >> }; >> >> >> >> diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi >> >> index ba686e4..8b15316 100644 >> >> --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi >> >> +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi >> >> @@ -201,6 +201,13 @@ >> >> samsung,pin-drv = <3>; >> >> }; >> >> >> >> + sd0_rclk: sd0-rclk { >> >> + samsung,pins = "gpc0-7"; >> >> + samsung,pin-function = <2>; >> >> + samsung,pin-pud = <1>; >> >> + samsung,pin-drv = <3>; >> >> + }; >> >> + >> >> sd1_cmd: sd1-cmd { >> >> samsung,pins = "gpc1-1"; >> >> samsung,pin-function = <2>; >> >> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts >> >> index 8be3d7b..2078a1f 100644 >> >> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts >> >> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts >> >> @@ -80,8 +80,10 @@ >> >> samsung,dw-mshc-ciu-div = <3>; >> >> samsung,dw-mshc-sdr-timing = <0 4>; >> >> samsung,dw-mshc-ddr-timing = <0 2>; >> >> + samsung,dw-mshc-hs400-timing = <0 2>; >> >> + samsung,read-strobe-delay = <90>; >> >> pinctrl-names = "default"; >> >> - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; >> >> + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; >> >> bus-width = <8>; >> >> cap-mmc-highspeed; >> >> }; >> >> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts >> >> index e8fdda8..96f0d61 100644 >> >> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts >> >> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts >> >> @@ -550,15 +550,18 @@ >> >> num-slots = <1>; >> >> broken-cd; >> >> mmc-hs200-1_8v; >> >> + mmc-hs400-1_8v; >> >> cap-mmc-highspeed; >> >> non-removable; >> >> card-detect-delay = <200>; >> >> - clock-frequency = <400000000>; >> >> + clock-frequency = <800000000>; >> >> samsung,dw-mshc-ciu-div = <3>; >> >> samsung,dw-mshc-sdr-timing = <0 4>; >> >> samsung,dw-mshc-ddr-timing = <0 2>; >> >> + samsung,dw-mshc-hs400-timing = <0 2>; >> >> + samsung,read-strobe-delay = <90>; >> >> pinctrl-names = "default"; >> >> - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; >> >> + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; >> >> bus-width = <8>; >> >> }; > -- Regards, Alim ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v5 0/2] mmc: dw_mmc: exynos: Add HS400 support 2015-01-29 2:41 [PATCH v5 0/2] mmc: dw_mmc: exynos: Add HS400 support Alim Akhtar 2015-01-29 2:41 ` [PATCH V5 1/2] mmc: dw_mmc: exynos: Support eMMC's HS400 mode Alim Akhtar 2015-01-29 2:41 ` [PATCH V5 2/2] ARM: dts: Add HS400 support for exynos5420 and exynos5800 Alim Akhtar @ 2015-02-06 1:18 ` Jaehoon Chung [not found] ` <54D41654.8030702-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2 siblings, 1 reply; 15+ messages in thread From: Jaehoon Chung @ 2015-02-06 1:18 UTC (permalink / raw) To: Alim Akhtar, linux-mmc Cc: chris, ulf.hansson, tgih.jun, dianders, alim.akhtar, kgene, linux-arm-kernel, devicetree, linux-samsung-soc, a.kesavan Hi, Alim. On my board, this patch isn't working fine. So when i complete to test on my board(exynos5), i will reply with comments. Sorry for late testing. Best Regards, Jaehoon Chung On 01/29/2015 11:41 AM, Alim Akhtar wrote: > This adds HS400 mode support for exynos dw_mmc host controller. > > Currently tested on Exynos5800-peach-pi and Exyons7 platform for HS400 mode. > Tested HS200 mode with this series applied, HS200 still works. > > Appreciate testing on other exynos5/7 platform which supports emmc5.0 > > Changes in V5: > * Enable HS400 on Exynos5800-peach-pi boards > * Addressed other review comments from Jaehoon Chung > > Changes in V4: > * drop the idea of changing existing binding for ciu_div as per [1] > * addressed comments from Jaehoon Chung [2] > > [1] http://www.spinics.net/lists/linux-samsung-soc/msg40923.html > [2] http://www.spinics.net/lists/devicetree/msg64373.html > > Changes in V3: > rebased on ulf's next (commit: 607b448 mmc: core: Make tuning block patterns static) > > Seungwon Jeon (2): > mmc: dw_mmc: exynos: Support eMMC's HS400 mode > ARM: dts: Add HS400 support for exynos5420 and exynos5800 > > .../devicetree/bindings/mmc/exynos-dw-mshc.txt | 7 + > arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +- > arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 + > arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 +- > arch/arm/boot/dts/exynos5800-peach-pi.dts | 7 +- > drivers/mmc/host/dw_mmc-exynos.c | 185 ++++++++++++++++---- > drivers/mmc/host/dw_mmc-exynos.h | 19 +- > drivers/mmc/host/dw_mmc.c | 16 +- > drivers/mmc/host/dw_mmc.h | 2 + > 9 files changed, 213 insertions(+), 38 deletions(-) > ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <54D41654.8030702-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>]
* Re: [PATCH v5 0/2] mmc: dw_mmc: exynos: Add HS400 support [not found] ` <54D41654.8030702-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> @ 2015-02-06 5:52 ` Vivek Gautam [not found] ` <CAFp+6iEGCEiGf5WooHJyh=cnJF_c7j=n_YhHLowfwjpLiXUPiQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 15+ messages in thread From: Vivek Gautam @ 2015-02-06 5:52 UTC (permalink / raw) To: Jaehoon Chung Cc: Alim Akhtar, linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Chris Ball, Ulf Hansson, Seungwon Jeon, Doug Anderson, Alim Akhtar, Kukjin Kim, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Abhilash Kesavan Hi Jaehoon, On Fri, Feb 6, 2015 at 6:48 AM, Jaehoon Chung <jh80.chung-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote: > Hi, Alim. > > On my board, this patch isn't working fine. > So when i complete to test on my board(exynos5), i will reply with comments. > Sorry for late testing. I tested this series on linux-next, on Exynos5800-peach-pi board, and HS400 seems to be working fine. I can see the card getting detected as HS400, and then i ran iozone as well. The iozone numbers are also as required. On peach-pit board too, the HS200 mode seems to be working good. What are the observations you saw on your board ? > > Best Regards, > Jaehoon Chung > > On 01/29/2015 11:41 AM, Alim Akhtar wrote: >> This adds HS400 mode support for exynos dw_mmc host controller. >> >> Currently tested on Exynos5800-peach-pi and Exyons7 platform for HS400 mode. >> Tested HS200 mode with this series applied, HS200 still works. >> >> Appreciate testing on other exynos5/7 platform which supports emmc5.0 >> >> Changes in V5: >> * Enable HS400 on Exynos5800-peach-pi boards >> * Addressed other review comments from Jaehoon Chung >> >> Changes in V4: >> * drop the idea of changing existing binding for ciu_div as per [1] >> * addressed comments from Jaehoon Chung [2] >> >> [1] http://www.spinics.net/lists/linux-samsung-soc/msg40923.html >> [2] http://www.spinics.net/lists/devicetree/msg64373.html >> >> Changes in V3: >> rebased on ulf's next (commit: 607b448 mmc: core: Make tuning block patterns static) >> >> Seungwon Jeon (2): >> mmc: dw_mmc: exynos: Support eMMC's HS400 mode >> ARM: dts: Add HS400 support for exynos5420 and exynos5800 >> >> .../devicetree/bindings/mmc/exynos-dw-mshc.txt | 7 + >> arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +- >> arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 + >> arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 +- >> arch/arm/boot/dts/exynos5800-peach-pi.dts | 7 +- >> drivers/mmc/host/dw_mmc-exynos.c | 185 ++++++++++++++++---- >> drivers/mmc/host/dw_mmc-exynos.h | 19 +- >> drivers/mmc/host/dw_mmc.c | 16 +- >> drivers/mmc/host/dw_mmc.h | 2 + >> 9 files changed, 213 insertions(+), 38 deletions(-) >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards Vivek Gautam Samsung R&D Institute, Bangalore India -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <CAFp+6iEGCEiGf5WooHJyh=cnJF_c7j=n_YhHLowfwjpLiXUPiQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH v5 0/2] mmc: dw_mmc: exynos: Add HS400 support [not found] ` <CAFp+6iEGCEiGf5WooHJyh=cnJF_c7j=n_YhHLowfwjpLiXUPiQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2015-02-06 6:03 ` Jaehoon Chung 2015-02-06 6:07 ` Vivek Gautam 0 siblings, 1 reply; 15+ messages in thread From: Jaehoon Chung @ 2015-02-06 6:03 UTC (permalink / raw) To: Vivek Gautam Cc: Alim Akhtar, linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Chris Ball, Ulf Hansson, Seungwon Jeon, Doug Anderson, Alim Akhtar, Kukjin Kim, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Abhilash Kesavan Hi, Vivek. On 02/06/2015 02:52 PM, Vivek Gautam wrote: > Hi Jaehoon, > > > On Fri, Feb 6, 2015 at 6:48 AM, Jaehoon Chung <jh80.chung-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote: >> Hi, Alim. >> >> On my board, this patch isn't working fine. >> So when i complete to test on my board(exynos5), i will reply with comments. >> Sorry for late testing. > > I tested this series on linux-next, on Exynos5800-peach-pi board, and HS400 > seems to be working fine. > I can see the card getting detected as HS400, and then i ran iozone as well. > The iozone numbers are also as required. > > On peach-pit board too, the HS200 mode seems to be working good. > > What are the observations you saw on your board ? Thanks for testing on your board. I have exynos5422 and exynos5433.(One is eMMC5.0, other is eMMC5.1) I want to see that it's working fine on my board. I should miss something..so i will check more detail after complete my other job, or on this weekend. (It failed for hs400 tuning sequence..I needs to check that it has the board dependency) Best Regards, Jaehoon Chung > >> >> Best Regards, >> Jaehoon Chung >> >> On 01/29/2015 11:41 AM, Alim Akhtar wrote: >>> This adds HS400 mode support for exynos dw_mmc host controller. >>> >>> Currently tested on Exynos5800-peach-pi and Exyons7 platform for HS400 mode. >>> Tested HS200 mode with this series applied, HS200 still works. >>> >>> Appreciate testing on other exynos5/7 platform which supports emmc5.0 >>> >>> Changes in V5: >>> * Enable HS400 on Exynos5800-peach-pi boards >>> * Addressed other review comments from Jaehoon Chung >>> >>> Changes in V4: >>> * drop the idea of changing existing binding for ciu_div as per [1] >>> * addressed comments from Jaehoon Chung [2] >>> >>> [1] http://www.spinics.net/lists/linux-samsung-soc/msg40923.html >>> [2] http://www.spinics.net/lists/devicetree/msg64373.html >>> >>> Changes in V3: >>> rebased on ulf's next (commit: 607b448 mmc: core: Make tuning block patterns static) >>> >>> Seungwon Jeon (2): >>> mmc: dw_mmc: exynos: Support eMMC's HS400 mode >>> ARM: dts: Add HS400 support for exynos5420 and exynos5800 >>> >>> .../devicetree/bindings/mmc/exynos-dw-mshc.txt | 7 + >>> arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +- >>> arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 + >>> arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 +- >>> arch/arm/boot/dts/exynos5800-peach-pi.dts | 7 +- >>> drivers/mmc/host/dw_mmc-exynos.c | 185 ++++++++++++++++---- >>> drivers/mmc/host/dw_mmc-exynos.h | 19 +- >>> drivers/mmc/host/dw_mmc.c | 16 +- >>> drivers/mmc/host/dw_mmc.h | 2 + >>> 9 files changed, 213 insertions(+), 38 deletions(-) >>> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in >> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH v5 0/2] mmc: dw_mmc: exynos: Add HS400 support 2015-02-06 6:03 ` Jaehoon Chung @ 2015-02-06 6:07 ` Vivek Gautam 0 siblings, 0 replies; 15+ messages in thread From: Vivek Gautam @ 2015-02-06 6:07 UTC (permalink / raw) To: Jaehoon Chung Cc: Alim Akhtar, linux-mmc@vger.kernel.org, Chris Ball, Ulf Hansson, Seungwon Jeon, Doug Anderson, Alim Akhtar, Kukjin Kim, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Abhilash Kesavan Hi, On Fri, Feb 6, 2015 at 11:33 AM, Jaehoon Chung <jh80.chung@samsung.com> wrote: > Hi, Vivek. > > On 02/06/2015 02:52 PM, Vivek Gautam wrote: >> Hi Jaehoon, >> >> >> On Fri, Feb 6, 2015 at 6:48 AM, Jaehoon Chung <jh80.chung@samsung.com> wrote: >>> Hi, Alim. >>> >>> On my board, this patch isn't working fine. >>> So when i complete to test on my board(exynos5), i will reply with comments. >>> Sorry for late testing. >> >> I tested this series on linux-next, on Exynos5800-peach-pi board, and HS400 >> seems to be working fine. >> I can see the card getting detected as HS400, and then i ran iozone as well. >> The iozone numbers are also as required. >> >> On peach-pit board too, the HS200 mode seems to be working good. >> >> What are the observations you saw on your board ? > > Thanks for testing on your board. I have exynos5422 and exynos5433.(One is eMMC5.0, other is eMMC5.1) > I want to see that it's working fine on my board. > I should miss something..so i will check more detail after complete my other job, or on this weekend. > (It failed for hs400 tuning sequence..I needs to check that it has the board dependency) Ok Thanks for testing it on your side. > > Best Regards, > Jaehoon Chung > >> >>> >>> Best Regards, >>> Jaehoon Chung >>> >>> On 01/29/2015 11:41 AM, Alim Akhtar wrote: >>>> This adds HS400 mode support for exynos dw_mmc host controller. >>>> >>>> Currently tested on Exynos5800-peach-pi and Exyons7 platform for HS400 mode. >>>> Tested HS200 mode with this series applied, HS200 still works. >>>> >>>> Appreciate testing on other exynos5/7 platform which supports emmc5.0 >>>> >>>> Changes in V5: >>>> * Enable HS400 on Exynos5800-peach-pi boards >>>> * Addressed other review comments from Jaehoon Chung >>>> >>>> Changes in V4: >>>> * drop the idea of changing existing binding for ciu_div as per [1] >>>> * addressed comments from Jaehoon Chung [2] >>>> >>>> [1] http://www.spinics.net/lists/linux-samsung-soc/msg40923.html >>>> [2] http://www.spinics.net/lists/devicetree/msg64373.html >>>> >>>> Changes in V3: >>>> rebased on ulf's next (commit: 607b448 mmc: core: Make tuning block patterns static) >>>> >>>> Seungwon Jeon (2): >>>> mmc: dw_mmc: exynos: Support eMMC's HS400 mode >>>> ARM: dts: Add HS400 support for exynos5420 and exynos5800 >>>> >>>> .../devicetree/bindings/mmc/exynos-dw-mshc.txt | 7 + >>>> arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +- >>>> arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 + >>>> arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 +- >>>> arch/arm/boot/dts/exynos5800-peach-pi.dts | 7 +- >>>> drivers/mmc/host/dw_mmc-exynos.c | 185 ++++++++++++++++---- >>>> drivers/mmc/host/dw_mmc-exynos.h | 19 +- >>>> drivers/mmc/host/dw_mmc.c | 16 +- >>>> drivers/mmc/host/dw_mmc.h | 2 + >>>> 9 files changed, 213 insertions(+), 38 deletions(-) >>>> >>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> >> > -- Best Regards Vivek Gautam Samsung R&D Institute, Bangalore India ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2015-03-17 23:26 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-29 2:41 [PATCH v5 0/2] mmc: dw_mmc: exynos: Add HS400 support Alim Akhtar
2015-01-29 2:41 ` [PATCH V5 1/2] mmc: dw_mmc: exynos: Support eMMC's HS400 mode Alim Akhtar
2015-02-25 6:34 ` Jaehoon Chung
2015-02-25 8:12 ` Alim Akhtar
2015-02-25 14:38 ` Rob Herring
2015-02-26 1:22 ` Jaehoon Chung
2015-01-29 2:41 ` [PATCH V5 2/2] ARM: dts: Add HS400 support for exynos5420 and exynos5800 Alim Akhtar
2015-02-25 6:35 ` Jaehoon Chung
2015-03-15 11:28 ` Alim Akhtar
2015-03-17 2:12 ` Kukjin Kim
2015-03-17 23:26 ` Alim Akhtar
2015-02-06 1:18 ` [PATCH v5 0/2] mmc: dw_mmc: exynos: Add HS400 support Jaehoon Chung
[not found] ` <54D41654.8030702-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-02-06 5:52 ` Vivek Gautam
[not found] ` <CAFp+6iEGCEiGf5WooHJyh=cnJF_c7j=n_YhHLowfwjpLiXUPiQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-06 6:03 ` Jaehoon Chung
2015-02-06 6:07 ` Vivek Gautam
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).