Devicetree
 help / color / mirror / Atom feed
From: Sunyun Yang <syyang@lontium.com>
To: sashiko@lists.linux.dev
Cc: conor+dt@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: bridge: Add Lontium LT7911EXC eDP to MIPI DSI bridge
Date: Sat, 9 May 2026 11:39:54 +0800	[thread overview]
Message-ID: <07b51d33-52ac-49d7-a596-b7ca70d68a58@lontium.com> (raw)
In-Reply-To: <20260508205007.655C6C2BCB0@smtp.kernel.org>

在 2026/5/9 4:50, sashiko-bot@kernel.org 写道:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [Medium] The binding lacks support for the dual-port MIPI DSI output claimed in the commit message.

1. When using single-port mode:
   (a). Only either Port A or Port B can be output at a time.
   (b). Port A and Port B are combined into a single port to output 
8-lane DSI.

2. When using dual-port mode:
Port A outputs the signal, and Port B copy the same signal from Port 
A.Both ports output the same image, and configuration for Port A alone 
is sufficient.

I need to look into how to modify it.

> - [Low] Typographical errors in the commit message alter the meaning and reduce clarity.
      it will be fixed.> --
> 
> commit d7e3500f4741bb0ae26a44a80c52b86455bf1c05
> Author: Sunyun Yang <syyang@lontium.com>
> 
> dt-bindings: bridge: Add Lontium LT7911EXC eDP to MIPI DSI bridge
> 
> This commit adds the device tree binding schema for the Lontium LT7911EXC.
> This device is an I2C-controlled bridge that converts eDP 1.4 input to MIPI
> DSI output.
> 
>> The LT7911EXC is an I2C-controlled bridge that Receiver eDP1.4
>> and output signal/dual port mipi dsi.
> 
> This isn't a bug, but there appear to be a few typos in the commit message
> description. The word Receiver reads like it should be receives, and the
> word signal looks like a typo for single.
> 
it will be fixed in next version.

>> diff --git a/Documentation/devicetree/bindings/display/bridge/lontium,lt7911exc.yaml b/Documentation/devicetree/bindings/display/bridge/lontium,lt7911exc.yaml
>> new file mode 100644
>> index 0000000000000..3290b10ce8835
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/bridge/lontium,lt7911exc.yaml
> 
> [ ... ]
> 
>>    ports:
>>      $ref: /schemas/graph.yaml#/properties/ports
>>
>>      properties:
>>        port@0:
>>          $ref: /schemas/graph.yaml#/properties/port
>>          description: Video port for eDP input.
>>
>>        port@1:
>>          $ref: /schemas/graph.yaml#/properties/port
>>          description: Video port for MIPI DSI output.
> 
> Since the commit message indicates the hardware supports dual port MIPI DSI
> output, should the schema define a secondary DSI interface here?
> 
> Without a second endpoint or an additional port defined, it seems device
> tree authors would be unable to properly model a dual-port display panel
> connection.
> 


  reply	other threads:[~2026-05-09  3:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-08 13:47 [PATCH v6 0/2] Add Lontium LT7911EXC eDP to MIPI DSI bridge syyang
2026-05-08 13:47 ` [PATCH v6 1/2] dt-bindings: bridge: " syyang
2026-05-08 20:50   ` sashiko-bot
2026-05-09  3:39     ` Sunyun Yang [this message]
2026-05-08 13:47 ` [PATCH v6 2/2] drm/bridge: " syyang
2026-05-08 21:13   ` sashiko-bot
2026-05-11 10:45     ` Sunyun Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07b51d33-52ac-49d7-a596-b7ca70d68a58@lontium.com \
    --to=syyang@lontium.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox