From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBC968C0B for ; Tue, 15 Apr 2025 05:18:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744694286; cv=none; b=YjNULmzpeIsHUiU05QgNhahV872QeJRomLVNgp5vbbl7hRQDQiETFEEoNEnB3AmU1cLEcpZoNBNDlYBFPl7SLo3ai8OCaRL7vNvwoQ28Q8e4WXZ9HfIhoKNNl9YY06Fi7aq945Qw+U9q0FONrMz6vJttkhniXhtm/gbTtp3nDfk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744694286; c=relaxed/simple; bh=FdZfU792CCDWPGZjzJCzg6hNwAhPIBTs2kh7NysYrVc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Avct/h5bVxPkWGWcpTYDnt6HnE5dRUMBD0cE6WyKukoj5xLbtKBKriOn1uMyAq+ihp/jrfGJU+ESbJ6G1cAnwXct6nXoYMQKO6kDLFgbEkJqMQbkj9Lauhh6WxQ3RLRVLCAGOYxwOgcO9F6FyTnX43rb5GnfWwQxoy29p8sCz64= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=TC6Vab0P; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TC6Vab0P" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5e5b736b3fcso705093a12.1 for ; Mon, 14 Apr 2025 22:18:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744694281; x=1745299081; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=nKGbhsbFx21TCcQEoUf/MpO6geW2Hf6flFl6tVO6zDM=; b=TC6Vab0PEM2bmp5GfNINN4K9YQFWUILOhKa5N266OJsiU6FDVUOQNG1lCwNqMpYL31 aAAqSQNccIfXijsmE/3KTbwEbEbM/mo/ll2eIBxdrQ7wKgxbc7KKDY4JzxXZ3DdqAfDg CAsOvMQaTtOK0XGYE9EEiRklPMYnazLVO+f5n3ZchbBZ931qE5pYLWaO8ScFfoO45S92 4qegDOchi/IYwNXVRfI2DrhT+nKsKCSPQyK0p0qSIhB2DyciCCHH2PcQCcBRzM5pW3II ZG2AmFW012DmXNIUIoZJ2KBukAtEWOBh7VHX2HGG9Yle9z2cexAWQJJ+MVBV2BpqngKp upXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744694281; x=1745299081; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nKGbhsbFx21TCcQEoUf/MpO6geW2Hf6flFl6tVO6zDM=; b=Xs3zCUpynTRE96pMIMgbExEb2d+Kn72YDuVnoke0iKkA6YkhN40yLyvVbTNpAG42CZ xtow5w5451K3ETu5f/SmVhMjTngP/w7UIRPpT6Mxn/KzBwoFQPaKMvNdXiU/9Tt4pg3q 0BlnNrD/nbgKGSbjeHNukRWVYHkiZgbcm0X2EyYGSlOf687xp7EaAaQhOkgBzvck7Ann iSufcK1xwEbLHmE4Sy4bo6xxa+9azkW993gpuJIxliH+6OZck/9is3Z/xZPepj4UNpMF Mf5iNoPL4PHf5qlBNwVZoowRW1o6zWDUddpmxChOaOW3w4T15CuTktPMM8OeZE1yBqwi bq/Q== X-Forwarded-Encrypted: i=1; AJvYcCXgzjfxQafMFRQT88X0LtMgObt9OHUSJDFLGpbaaDzvuhvKsUoEsiAWHcLw7wB7g6YSlNrNJem93hVT@vger.kernel.org X-Gm-Message-State: AOJu0Yw5qxF/loMkqprxE7ktILe3ERidwuWMRiPXjGxevNK+n0NecSB3 dSHY74zitZhQMMKQyh+yGzp2ZJw5pYVT27vh3+mNg0mLdhTmvJ3bk8aLN3kVl0g= X-Gm-Gg: ASbGncsZiAmrJwQs0IeO6/58szq6Ys8zlhioG0xcf9HVM+RCqLYKRqbY1oycXhGUZKD 8FAOnIHQxsDR0JDp8VVt7ELhy1eTaiQ92T7ZRrNJ2dBsI02UKLjOqMdFTRyfhZ620sizar2hMOA 8eJvFnFM85lXW+w2eKjys4HUsFf1dWX7AZsqQR60spnGwwxebl1KcUJ/2AR0cKVi6F7UAtTFdwA fAVhUjVhQz07QEfNhrqo2PIRHKLOsjjX32/jmG0yxddOC+L2OMegj1mpLOdN53AyiYe5Zeysowi h4rrbxsl6+Y+c0opY6AVN3ybMNYg73XJh/vaQ+YbIy3gKBoYwEv56g4NcLaR0TsPN+RR8qWY9pd flWklheoTLMBc4hYjZdL2xgPmrnI= X-Google-Smtp-Source: AGHT+IHdCQRv/1mN/hp1esBtPsQ6NLByGfwzZPRAy9S6SqZ9wExx4ggi8SyS7oKyBCf/Tbkfl8c7vg== X-Received: by 2002:a17:907:9588:b0:ac0:b71e:44e7 with SMTP id a640c23a62f3a-acad3574329mr460120066b.12.1744694280847; Mon, 14 Apr 2025 22:18:00 -0700 (PDT) Received: from [192.168.0.101] (46.150.74.144.lvv.nat.volia.net. [46.150.74.144]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1bb3120sm1012633166b.1.2025.04.14.22.17.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Apr 2025 22:18:00 -0700 (PDT) Message-ID: <07bf9f93-deb8-48a1-aae9-a8a053680cc9@linaro.org> Date: Tue, 15 Apr 2025 07:17:58 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] dt-bindings: mfd: syscon: Add ti,am62-ddr-pmctrl To: Andrew Davis , Markus Schneider-Pargmann Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Siddharth Vadapalli , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20250122-topic-am62-dt-syscon-v6-13-v1-0-515d56edc35e@baylibre.com> <20250122-topic-am62-dt-syscon-v6-13-v1-2-515d56edc35e@baylibre.com> <20250124-heavy-jaybird-of-vitality-4cbe24@krzk-bin> <20250124-able-beagle-of-prowess-f5eb7a@krzk-bin> <639b4e3a-3f68-4fba-aa33-c46dcb6fc88f@linaro.org> <74ee6d9b-fd78-4d8a-a94f-b2c4dc794b60@linaro.org> <2130b439-74d0-475d-8429-1a1b4d9738aa@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 09/04/2025 19:39, Andrew Davis wrote: > On 2/12/25 1:35 PM, Krzysztof Kozlowski wrote: >> On 10/02/2025 11:35, Markus Schneider-Pargmann wrote: >>> On Sun, Feb 09, 2025 at 01:21:27PM +0100, Krzysztof Kozlowski wrote: >>>> On 07/02/2025 15:40, Markus Schneider-Pargmann wrote: >>>>> Hi Krzysztof, >>>>> >>>>> On Mon, Jan 27, 2025 at 01:09:49PM +0100, Krzysztof Kozlowski wrote: >>>>>> On 24/01/2025 23:35, Andrew Davis wrote: >>>>>>> On 1/24/25 10:48 AM, Krzysztof Kozlowski wrote: >>>>>>>> On 24/01/2025 17:05, Markus Schneider-Pargmann wrote: >>>>>>>>> Hi Krzysztof, >>>>>>>>> >>>>>>>>> On Fri, Jan 24, 2025 at 09:22:54AM +0100, Krzysztof Kozlowski wrote: >>>>>>>>>> On Fri, Jan 24, 2025 at 09:19:49AM +0100, Krzysztof Kozlowski wrote: >>>>>>>>>>> On Wed, Jan 22, 2025 at 11:24:33AM +0100, Markus Schneider-Pargmann wrote: >>>>>>>>>>>> Add compatible for ti,am62-ddr-pmctrl to the list. There is a DDR pmctrl >>>>>>>>>>>> register in the wkup-conf register space of am62a and am62p. This >>>>>>>>>>>> register controls DDR power management. >>>>>>>>>>>> >>>>>>>>>>>> Signed-off-by: Markus Schneider-Pargmann >>>>>>>>>>>> --- >>>>>>>>>>>> Documentation/devicetree/bindings/mfd/syscon.yaml | 2 ++ >>>>>>>>>>>> 1 file changed, 2 insertions(+) >>>>>>>>>>> >>>>>>>>>>> Acked-by: Krzysztof Kozlowski >>>>>>>>>> >>>>>>>>>> Un-acked, I missed the point that you really speak in commit msg about >>>>>>>>>> register and you really treat one register is a device. I assumed you >>>>>>>>>> only need that register from this device, but no. That obviously is not >>>>>>>>>> what this device is. Device is not a single register among 10000 others. >>>>>>>>>> IOW, You do not have 10000 devices there. >>>>>>>>> >>>>>>>>> Do I understand you correctly that the whole register range of the >>>>>>>>> wkup_conf node as seen in arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi >>>>>>>>> should be considered a single syscon device? >>>>>>>> >>>>>>>> I don't have the datasheets (and not my task to actually check this), >>>>>>>> but you should probably follow datasheet. I assume it describes what is >>>>>>>> the device, more or less. >>>>>>>> >>>>>>>> I assume entire wkup_conf is considered a device. >>>>>>>> >>>>>>>>> >>>>>>>>> Unfortunately wkup_conf is modeled as a simple-bus with currently 5 >>>>>>>>> subnodes defined of which 4 of them consist of a single register. Most >>>>>>>>> of them are syscon as well. So I think I can't change the simple-bus >>>>>>>>> back to syscon. >>>>>>>> >>>>>>>> Huh... Maybe TI folks will help us understand why such design was chosen. >>>>>>>> >>>>>>> >>>>>>> Many of the devices inside the wkup_conf are already modeled as such. >>>>>>> Clocks and muxes for instance already have drivers and bindings, this >>>>>>> is nothing new to TI. >>>>>>> >>>>>>> If we just use a blank "syscon" over the entire region we would end up >>>>>>> with drivers that use phandles to the top level wkup_conf node and >>>>>>> poke directly the registers they need from that space. >>>>>>> >>>>>>> Would you rather have >>>>>>> >>>>>>> some-device { >>>>>>> ti,epwm_tbclk = <&wkup_conf>; >>>>>>> } >>>>>>> >>>>>>> or >>>>>>> >>>>>>> some-device { >>>>>>> clocks = <&epwm_tbclk 0>; >>>>>>> } >>>>>> >>>>>> How is this comparable? These are clocks. You would have clocks property >>>>>> in both cases. >>>>>> >>>>>> >>>>>>> >>>>>>> with that epwm_tbclk being a proper clock node inside wkup_conf? >>>>>>> I would much prefer the second, even though the clock node >>>>>>> only uses a single register. And in the first case, we would need >>>>>>> to have the offset into the wkup_conf space hard-coded in the >>>>>>> driver for each new SoC. Eventually all that data would need to be >>>>>>> put in tables and we end up back to machine board files.. >>>>>>> >>>>>>> I'm not saying every magic number in all drivers should >>>>>>> be offloaded into DT, but there is a line somewhere between >>>>>>> that and having the DT simply contain the SoC's name compatible >>>>>> >>>>>> That's not the question here. >>>>>> >>>>>>> and all other data going into the kernel. That line might be a >>>>>>> personal preference, so my question back is: what is wrong >>>>>>> if we do want "1000 new syscons per each register" for our >>>>>>> SoCs DT? >>>>>> >>>>>> Because it is false representation of hardware. You do not have 1000 >>>>>> devices. You have only one device. >>>>>> >>>>>> >>>>>>> >>>>>>> (and the number is not 1000, scanning the kernel I can see >>>>>>> the largest wkup_conf region node we have today has a grand >>>>>>> total number sub-nodes of 6) >>>>>> >>>>>> But what is being added here is device per each register, not per feature. >>>>> >>>>> The register layout is like this: >>>> >>>> The register layout of what? How is the device called? Is datasheet >>>> available anywhere? >>> >>> Yes, it is available here: https://www.ti.com/de/lit/pdf/spruj16 >>> >>> 14 Registers >>> 14.2 Device Configuration Registers >>> 14.2.1 CTRL_MMR Registers >>> 14.2.1.1 General Purpose Control Registers >>> 14.2.1.1.3 WKUP_CTRL_MMR0 Registers >>> >>> Each domain has their own set of general purpose control registers, >>> CTRL_MMR for the main domain, MCU_CTRL_MMR0 for the MCU domain, >>> WKUP_CTRL_MMR0 for the wakeup domain. >> >> >> So according to the doc you have only one device - CTRL_MMR. All other >> splits are superficial. >> > > It is not one device, it is a collection of devices under one labeled > bus range. Some items here are full normal devices, already modeled by DT > as stand-alone devices, for instance our chipid, efuse, clock controller, > etc. even our pinmux is part of this bus range. > > They are grouped as we have one set for each domain (MAIN, WKUP, MCU). > > All other splits are not superficial, if we go down that path then > the whole SoC is one "device". We could simply have the whole address > bus be one node and have Linux hard-code offsets in the drivers, we > end up back at board files.. > > DT should break things into logically distinct and reusable units > so we don't have to store that in the kernel. That is what we do > here, even if some units end up being very small. > >>> >>> So I understand this to just be a collection of general purpose control >>> registers. If you go by feature, then many of the registers can be >>> grouped into units with a specific purpose or controlling a specific >>> device which are also grouped by the offsets they represent. I assume >> >> It could work if you have distinctive groups, but here: >> 1. You do not have this grouped, you just judge by yourself "oh, that's >> group A, that's B". >> 2. Group per one register is not that. >> >> For me this is one big block and even CLKSEL is spread all over so >> cannot be really made distinctive. >> >>> this is why the other nodes in this wkup_conf node were created. Also in >> >> The other nodes represent some sort of fake or totally arbitrary >> grouping. That's abuse of the syscon. >> > > They are grouped by function. Not really - other DTS sent just few days ago created each entry per one register. > >>> my opinion this makes the relation between the original device and this >>> general purpose control registers better understandable. >>> >>> For this patch the ddr-pmctrl regsiter is just a single register, but it >>> has the purpose of controlling the DDR device power management. >> >> Sure, but that is NOT syscon. One register of entire block is not system >> controller. The entire block is system controller. >> > > The whole block cannot be a system controller as there are regular > devices inside this range. If we made the whole region a syscon and That's still system controller. It's nothing special here. > also left the device nodes inside, then we would have overlapping > register owners, one register would be controlled by two or more No, owner is the parent device always. > drivers. How would we synchronize mappings, access, updates, etc. > Any one register should belong to exactly one device. regmap synchronizes everything. There is no problem here, at all. > > Is your issue the name "system controller", as yes I agree some of > these regions are not "system controllers". > > Would it work better if we didn't call this "ti,am62-ddr-pmctrl" > node a "syscon"? That can be done, we just would add a normal > binding doc for it, instead of trying to reuse the generic > bindings/mfd/syscon.yaml file. You still do not have multiple subnodes, one per each register or even few registers. Best regards, Krzysztof