RE: [PATCH 1/2] drm/fsl-dcu: update the panel dt binding document

[Stefan Agner <stefan-XLVq0VzYD2Y@public.gmane.org>]

On 2016-06-28 19:58, Meng Yi wrote:
>> >>  Optional properties:
>> >>  - fsl,tcon:		The phandle to the timing controller node.
>> >> @@ -24,6 +24,11 @@ dcu: dcu@2ce0000 {
>> >>  	clocks = <&platform_clk 0>, <&platform_clk 0>;
>> >>  	clock-names = "dcu", "pix";
>> >>  	big-endian;
>> >> -	fsl,panel = <&panel>;
>> >>  	fsl,tcon = <&tcon>;
>> >> +
>> >> +	port: port@0 {
>> >
>> > Drop the unit address. With that,
>>
>> I was going to say add a corresponding reg property and specify address-cells.
>>
> 
> For now, we only have one 'remote-endpoint', you mean maybe we should
> use 'ports' that prepare for multiple connections?
> 

I ment to add the address because most drivers do. But then, most
drivers support multiple ports.

>> So is it ok to also create a port without address?
>>
> 
> It works fine, I think it is ok.

I guess it is ok too since Rob suggested it. However, consequently I
also would drop the unit address of the port node inside the panel node.

--
Stefan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html