From: Puranjay Mohan <p-mohan@ti.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <linux-kernel@vger.kernel.org>, <bjorn.andersson@linaro.org>,
<mathieu.poirier@linaro.org>, <krzysztof.kozlowski+dt@linaro.org>,
<linux-remoteproc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<nm@ti.com>, <ssantosh@kernel.org>, <s-anna@ti.com>,
<linux-arm-kernel@lists.infradead.org>, <davem@davemloft.net>,
<kuba@kernel.org>, <netdev@vger.kernel.org>, <vigneshr@ti.com>,
<kishon@ti.com>, roger Quadros <rogerq@kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [RFC 13/13] net: ti: icssg-prueth: Add ICSSG ethernet driver
Date: Tue, 12 Apr 2022 15:16:35 +0530 [thread overview]
Message-ID: <080bf31d-a452-af0b-ca41-a6b3d951e18f@ti.com> (raw)
In-Reply-To: <Yk3fHzDsl1iNl9ah@lunn.ch>
+Roger, Grygorii
On 07/04/22 00:12, Andrew Lunn wrote:
>> +config TI_ICSSG_PRUETH
>> + tristate "TI Gigabit PRU Ethernet driver"
>> + select TI_DAVINCI_MDIO
>> +
>
> I don't see a dependency on TI_DAVINCI_MDIO in the code. All you need
> is an MDIO bus so that your phy-handle has somewhere to point. But that
> could be a GPIO bit banger.
>
> What i do think is missing here is a dependency on PHYLIB.
>
> If possible, it would be good to also have it compile when
> COMPILE_TEST is set.
>
> Andrew
next prev parent reply other threads:[~2022-04-12 10:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 9:43 [RFC 00/13] PRUSS Remoteproc, Platform APIS, and Ethernet Driver Puranjay Mohan
2022-04-06 9:43 ` [RFC 01/13] dt-bindings: remoteproc: Add PRU consumer bindings Puranjay Mohan
2022-04-07 13:50 ` Rob Herring
2022-04-07 15:09 ` Rob Herring
2022-04-12 6:41 ` Puranjay Mohan
2022-04-06 9:43 ` [RFC 02/13] remoteproc: pru: Add APIs to get and put the PRU cores Puranjay Mohan
2022-04-06 9:43 ` [RFC 03/13] remoteproc: pru: Make sysfs entries read-only for PRU client driven boots Puranjay Mohan
2022-04-06 9:43 ` [RFC 04/13] remoteproc: pru: Add pru_rproc_set_ctable() function Puranjay Mohan
2022-04-06 9:43 ` [RFC 05/13] remoteproc: pru: Configure firmware based on client setup Puranjay Mohan
2022-04-06 9:43 ` [RFC 06/13] soc: ti: pruss: Add pruss_get()/put() API Puranjay Mohan
2022-04-06 9:43 ` [RFC 07/13] soc: ti: pruss: Add pruss_{request,release}_mem_region() API Puranjay Mohan
2022-04-06 9:43 ` [RFC 08/13] soc: ti: pruss: Add pruss_cfg_read()/update() API Puranjay Mohan
2022-04-06 9:43 ` [RFC 09/13] soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR Puranjay Mohan
2022-04-06 9:43 ` [RFC 10/13] soc: ti: pruss: Add helper function to enable OCP master ports Puranjay Mohan
2022-04-06 9:43 ` [RFC 11/13] soc: ti: pruss: Add helper functions to get/set PRUSS_CFG_GPMUX Puranjay Mohan
2022-04-06 9:43 ` [RFC 12/13] dt-bindings: net: Add ICSSG Ethernet Driver bindings Puranjay Mohan
2022-04-06 18:54 ` Rob Herring
2022-04-07 16:56 ` Rob Herring
2022-04-06 9:43 ` [RFC 13/13] net: ti: icssg-prueth: Add ICSSG ethernet driver Puranjay Mohan
2022-04-06 14:13 ` Andrew Lunn
2022-04-12 9:42 ` Puranjay Mohan
2022-04-13 8:15 ` Roger Quadros
2022-04-06 18:37 ` Andrew Lunn
2022-04-12 9:45 ` Puranjay Mohan
2022-04-12 9:56 ` Grygorii Strashko
2022-04-12 13:10 ` Andrew Lunn
2022-04-06 18:42 ` Andrew Lunn
2022-04-12 9:46 ` Puranjay Mohan [this message]
2022-04-13 8:09 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=080bf31d-a452-af0b-ca41-a6b3d951e18f@ti.com \
--to=p-mohan@ti.com \
--cc=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=rogerq@kernel.org \
--cc=s-anna@ti.com \
--cc=ssantosh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).