From: Milo Kim <woogyom.kim@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: bcousson@baylibre.com, Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] mfd: tps65217: Fix mismatched interrupt number
Date: Fri, 28 Oct 2016 13:04:33 +0900 [thread overview]
Message-ID: <08151892-96b0-2a9b-5b5a-b91bec94e247@gmail.com> (raw)
In-Reply-To: <20161026135631.GC13127@dell>
On 10/26/2016 10:56 PM, Lee Jones wrote:
>> diff --git a/include/linux/mfd/tps65217.h b/include/linux/mfd/tps65217.h
>> > index 4ccda89..75a3a5f 100644
>> > --- a/include/linux/mfd/tps65217.h
>> > +++ b/include/linux/mfd/tps65217.h
>> > @@ -235,9 +235,9 @@ struct tps65217_bl_pdata {
>> > };
>> >
>> > enum tps65217_irq_type {
>> > - TPS65217_IRQ_PB,
>> > - TPS65217_IRQ_AC,
>> > TPS65217_IRQ_USB,
>> > + TPS65217_IRQ_AC,
>> > + TPS65217_IRQ_PB,
>> > TPS65217_NUM_IRQ
>> > };
> This is why using enum for these types of assignments is sometimes
> dangerous. It's probably best to be explicit.
I agree with you. Let me fix in v2 - use #define instead of enum type.
Best regards,
Milo
prev parent reply other threads:[~2016-10-28 4:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 14:00 [PATCH 0/7] Support TPS65217 PMIC interrupt in DT Milo Kim
2016-10-21 14:01 ` [PATCH 1/7] ARM: dts: tps65217: Specify the interrupt controller Milo Kim
2016-10-21 14:01 ` [PATCH 2/7] ARM: dts: tps65217: Add the charger device Milo Kim
2016-10-21 14:01 ` [PATCH 3/7] ARM: dts: tps65217: Add the power button device Milo Kim
2016-10-21 14:01 ` [PATCH 4/7] ARM: dts: am335x: Support the PMIC interrupt Milo Kim
2016-10-21 14:01 ` [PATCH 5/7] ARM: dts: am335x: Add the charger interrupt Milo Kim
2016-10-21 20:47 ` Robert Nelson
2016-10-21 21:01 ` Robert Nelson
[not found] ` <CAOCHtYgBTq0a1FAMQJb5VoLPWBHYkF3rH_Km6U9u6ep=8ApZuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-28 4:01 ` Milo Kim
2016-10-21 14:01 ` [PATCH 6/7] ARM: dts: am335x: Add the power button interrupt Milo Kim
2016-10-21 14:01 ` [PATCH 7/7] mfd: tps65217: Fix mismatched interrupt number Milo Kim
[not found] ` <20161021140106.21531-8-woogyom.kim-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-26 13:56 ` Lee Jones
2016-10-28 4:04 ` Milo Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08151892-96b0-2a9b-5b5a-b91bec94e247@gmail.com \
--to=woogyom.kim@gmail.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).