devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Fabrice Gasnier <fabrice.gasnier@foss.st.com>, robh+dt@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	amelie.delaunay@foss.st.com, alexandre.torgue@foss.st.com,
	gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com
Subject: Re: [PATCH 1/4] dt-bindings: usb: typec: add bindings for stm32g0 controller
Date: Mon, 4 Jul 2022 09:55:33 +0200	[thread overview]
Message-ID: <0821acfe-bcfe-b1d8-c1a9-81023f4ab6a0@linaro.org> (raw)
In-Reply-To: <dfad8fb5-6205-d620-81eb-5d44b9175e05@foss.st.com>

On 01/07/2022 12:04, Fabrice Gasnier wrote:
> 
> Then I no longer get this warning upon build. But the dtbs_check complains:
> ---
> connector: ports: 'port@0' is a required property
> 	From schema: ..
> Documentation/devicetree/bindings/connector/usb-connector.yaml
> 
> So It looks like to me there's something missing to handle the single
> port case in usb-connector.yaml, when using the "ports".
> 
> Maybe usb-connector could be updated to handle "port" (w/o unit-addr) ?

Not really, the dtc warning looks false-positive. Especially that you
need port@1 for USB 3.0 (super speed), unless you do not support it?

> I'm talking about:
>     required:
>       - port@0
> 
> So, I came up with:
> 
> --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> @@ -176,6 +176,9 @@ properties:
>        port number as described below.
> 
>      properties:
> +      port:
> +        $ref: /schemas/graph.yaml#/properties/port
> +
>        port@0:
>          $ref: /schemas/graph.yaml#/properties/port
>          description: High Speed (HS), present in all connectors.
> @@ -189,8 +192,11 @@ properties:
>          description: Sideband Use (SBU), present in USB-C. This
> describes the
>            alternate mode connection of which SBU is a part.
> 
> -    required:
> -      - port@0
> +    oneOf:
> +      - required:
> +          - port
> +      - required:
> +          - port@0
> 
> 
> Do you agree on this approach ? (I can add a pre-cursor patch to this
> series, to handle the single port case)



Best regards,
Krzysztof

  reply	other threads:[~2022-07-04  7:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24 15:54 [PATCH 0/4] usb: typec: ucsi: add support for stm32g0 Fabrice Gasnier
2022-06-24 15:54 ` [PATCH 1/4] dt-bindings: usb: typec: add bindings for stm32g0 controller Fabrice Gasnier
2022-06-24 16:16   ` Krzysztof Kozlowski
2022-06-27 14:21     ` Fabrice Gasnier
2022-06-28 10:28       ` Krzysztof Kozlowski
2022-06-28 17:01         ` Fabrice Gasnier
2022-06-29  5:54           ` Krzysztof Kozlowski
2022-07-01 10:04             ` Fabrice Gasnier
2022-07-04  7:55               ` Krzysztof Kozlowski [this message]
2022-07-04  9:08                 ` Fabrice Gasnier
2022-07-06  7:06                   ` Krzysztof Kozlowski
2022-06-24 15:54 ` [PATCH 2/4] usb: typec: ucsi: stm32g0: add support for stm32g0 i2c controller Fabrice Gasnier
2022-06-25  6:37   ` Christophe JAILLET
2022-06-27 13:17   ` Heikki Krogerus
2022-06-28  7:21     ` Fabrice Gasnier
2022-06-28  9:56       ` Heikki Krogerus
2022-06-24 15:54 ` [PATCH 3/4] usb: typec: ucsi: stm32g0: add bootloader support Fabrice Gasnier
2022-06-24 15:54 ` [PATCH 4/4] usb: typec: ucsi: stm32g0: add support for power management Fabrice Gasnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0821acfe-bcfe-b1d8-c1a9-81023f4ab6a0@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=amelie.delaunay@foss.st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrice.gasnier@foss.st.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).