From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA4F3C433EF for ; Thu, 9 Jun 2022 13:22:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239258AbiFINWl (ORCPT ); Thu, 9 Jun 2022 09:22:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232953AbiFINWk (ORCPT ); Thu, 9 Jun 2022 09:22:40 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 655BB25F5 for ; Thu, 9 Jun 2022 06:22:38 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id n28so31188186edb.9 for ; Thu, 09 Jun 2022 06:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=nPMBIqsJZwcPYHy4tA1bMGL8vPZI0Il4YAYQQ5QYP70=; b=HcyOqScH0H7f0QBbSZpnZWOuxME9FUTvh0o4cXzuLeQk+NOezh1q7LxxcYFZFNw6zU mZniV6vvuxjuq/HjCk6/69/omoJIFpua/zC/93/JWnALilG9KhAyGa9gcJ4kgLg6R9Vt pZW6nyofEFdiiGFNE+i8EhE9mebe/H8CMU/KCEy/nj87uAZy2ryT/0BvVfwSmRm5kdk3 uErkK9ou5SC8ttxhJFbJo4KLQuWVsH4uRg56RWUuqbr/fg1iUbt2ecsdwSxi4HLg6B9b uWNziFNvxq0Mm4Jc3V5lIfdIrksokxD/8ZBurL9kl5GI1zCostGBmEYlaJCm0vtjsMrP QjWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=nPMBIqsJZwcPYHy4tA1bMGL8vPZI0Il4YAYQQ5QYP70=; b=c+/Ho9zNxk/h3bfzmAkAg2p/3dKlBRlr0nRDNNzD6It+YYz9+GGqz8DH1VYwJf90nl EfrD9tQzfbvyF6QPnDpkrEfGhdK0WZ6YypYew86A4oohZpRyOAAuu5w/PTFDcOszzs8k cdtkaq1Sf1lVPcc1Qz4CAddCS0zJnpnsR8Y+OsAfxPKXqvwbALHZGsRUCT/iAv1bK9Il xr4aKa7r1/4zQjDIFvA3FZVuCS/80jUTfU06V4SnAJv386MoHoInrX3vb3iWuSgPqhQq pCn4qlTGMnetA3JmJN8tjXIzfTyHky6K0CRWnY6YmMDcTX7gEZg+C5Sm902Zhy4AQrSO rfHA== X-Gm-Message-State: AOAM531Rno7/9dqoYetKpk1XNWiJcriC0rUZvDNYStn7XyPQSjDqs8jk XMp2ftPytUD8Ng815958ph63SQ== X-Google-Smtp-Source: ABdhPJycqxez50LdWJaT0BJ8GA7qrEg33IF52lV1YBM9+fDCeVtIUlfKDd3+doY6QFvG1RpSBUGiyA== X-Received: by 2002:a05:6402:27cc:b0:42d:de10:4b6c with SMTP id c12-20020a05640227cc00b0042dde104b6cmr46324557ede.424.1654780956908; Thu, 09 Jun 2022 06:22:36 -0700 (PDT) Received: from [192.168.0.198] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id s22-20020a1709062ed600b006feb875503fsm2211664eji.78.2022.06.09.06.22.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jun 2022 06:22:35 -0700 (PDT) Message-ID: <082366b0-6811-b492-c68c-12f9a9ee512e@linaro.org> Date: Thu, 9 Jun 2022 15:22:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 06/20] dt-binding: clk: npcm845: Add binding for Nuvoton NPCM8XX Clock Content-Language: en-US To: Tomer Maimon Cc: Avi Fishman , Tali Perry , Joel Stanley , Patrick Venture , Nancy Yuen , Benjamin Fair , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Philipp Zabel , Greg KH , Daniel Lezcano , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Catalin Marinas , Will Deacon , Arnd Bergmann , Olof Johansson , Jiri Slaby , Shawn Guo , Bjorn Andersson , Geert Uytterhoeven , Marcel Ziswiler , Vinod Koul , Biju Das , Nobuhiro Iwamatsu , Robert Hancock , =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= , Lubomir Rintel , devicetree , Linux Kernel Mailing List , linux-clk , "open list:SERIAL DRIVERS" , LINUXWATCHDOG , Linux ARM References: <20220608095623.22327-1-tmaimon77@gmail.com> <20220608095623.22327-7-tmaimon77@gmail.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/06/2022 15:17, Tomer Maimon wrote: > Hi Krzysztof, > > Thanks for your comments. > > On Wed, 8 Jun 2022 at 13:03, Krzysztof Kozlowski > wrote: >> >> On 08/06/2022 11:56, Tomer Maimon wrote: >>> Add binding for the Arbel BMC NPCM8XX Clock controller. >>> >>> Signed-off-by: Tomer Maimon >>> --- >>> .../bindings/clock/nuvoton,npcm845-clk.yaml | 63 +++++++++++++++++++ >>> .../dt-bindings/clock/nuvoton,npcm8xx-clock.h | 50 +++++++++++++++ >>> 2 files changed, 113 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml >>> create mode 100644 include/dt-bindings/clock/nuvoton,npcm8xx-clock.h >>> >>> diff --git a/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml >>> new file mode 100644 >>> index 000000000000..e1f375716bc5 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml >>> @@ -0,0 +1,63 @@ >>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/clock/nuvoton,npcm845-clk.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Nuvoton NPCM8XX Clock Controller Binding >>> + >>> +maintainers: >>> + - Tomer Maimon >>> + >>> +description: | >>> + Nuvoton Arbel BMC NPCM8XX contains an integrated clock controller, which >>> + generates and supplies clocks to all modules within the BMC. >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - nuvoton,npcm845-clk >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + clocks: >>> + items: >>> + - description: 25M reference clock >>> + - description: CPU reference clock >>> + - description: MC reference clock >>> + >>> + clock-names: >>> + items: >>> + - const: refclk >>> + - const: sysbypck >>> + - const: mcbypck >>> + >> >> I asked what is the suffix about and you replied "ck"... ok, so let's >> make clear. This should be: >> >> items: >> - const: ref >> - const: sysbyp >> - const: mcbyp >> >> or something similar, without the same suffix all over. > The clock names are the same clock name in our spec, this why we > prefer to leave the clock names as is. The naming with useless suffixes does not help. If your spec had "refclk_really_clock_this_is_a_clock" you also would insist on that? It does not make sense. >> >>> diff --git a/include/dt-bindings/clock/nuvoton,npcm8xx-clock.h b/include/dt-bindings/clock/nuvoton,npcm8xx-clock.h >>> new file mode 100644 >>> index 000000000000..229915a254a5 >>> --- /dev/null >>> +++ b/include/dt-bindings/clock/nuvoton,npcm8xx-clock.h >> >> Same comment as before. No changes here... >> > about the comments from V1:: > - Krzysztof: Filename - same as bindings, so nuvoton,npcm845-clk.h > In NPCM7XX we use the same include file and clock source > dt-binding > https://elixir.bootlin.com/linux/v5.19-rc1/source/Documentation/devicetree/bindings/clock/nuvoton,npcm750-clk.txt > dt-binding include > https://elixir.bootlin.com/linux/v5.19-rc1/source/include/dt-bindings/clock/nuvoton,npcm7xx-clock.h > we prefer to be align with our older BMC version Older has incorrect name, so do not align to incorrect one. What is the logic behind having header not matching the bindings file? It makes it only more difficult to connect these two. > > - Krzysztof: Dual license, same as bindings. > modified in the file * SPDX-License-Identifier: (GPL-2.0-only OR > BSD-2-Clause) */ > the same license approved in en7523-clk include file and pushed to > Linux kernel 5.19 : > https://elixir.bootlin.com/linux/v5.19-rc1/source/include/dt-bindings/clock/en7523-clk.h I don't understand this comment at all. I am not commenting about en7523-clk.h. I am commenting about the header here - it should have dual license. What en7523-clk.h has to do with it? Best regards, Krzysztof