From: Krzysztof Kozlowski <krzk@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Lorenzo Bianconi <lorenzo@kernel.org>,
upstream@airoha.com
Subject: Re: [PATCH 1/2] dt-bindings: watchdog: airoha: document watchdog for Airoha EN7581
Date: Thu, 19 Sep 2024 14:35:02 +0200 [thread overview]
Message-ID: <08288a0b-3e10-4f83-8bc7-0587328ee9a0@kernel.org> (raw)
In-Reply-To: <20240919122759.10456-1-ansuelsmth@gmail.com>
On 19/09/2024 14:26, Christian Marangi wrote:
> Document watchdog for Airoha EN7581. This SoC implement a simple
> watchdog that supports a max timeout of 28 seconds.
>
> The watchdog ticks on half the BUS clock and require the BUS frequency
> to be provided.
Clock provider should implement clk_get_rate()...
>
...
> +maintainers:
> + - Christian Marangi <ansuelsmth@gmail.com>
> +
> +allOf:
> + - $ref: watchdog.yaml#
> +
> +properties:
> + compatible:
> + const: airoha,en7581-wdt
> +
> + reg:
> + maxItems: 1
> +
> + clock-frequency:
> + description: BUS frequency in Hz (timer ticks at half the BUS freq)
> + const: 300000000
Which bus frequency? Aren't you missing here clock input?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-19 12:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 12:26 [PATCH 1/2] dt-bindings: watchdog: airoha: document watchdog for Airoha EN7581 Christian Marangi
2024-09-19 12:26 ` [PATCH 2/2] watchdog: Add support for Airoha EN7851 watchdog Christian Marangi
2024-09-21 17:17 ` kernel test robot
2024-09-22 6:16 ` kernel test robot
2024-09-19 12:35 ` Krzysztof Kozlowski [this message]
2024-09-19 12:39 ` [PATCH 1/2] dt-bindings: watchdog: airoha: document watchdog for Airoha EN7581 Christian Marangi
2024-09-19 12:42 ` Krzysztof Kozlowski
2024-09-25 8:53 ` Christian Marangi
2024-09-19 13:23 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08288a0b-3e10-4f83-8bc7-0587328ee9a0@kernel.org \
--to=krzk@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lorenzo@kernel.org \
--cc=robh@kernel.org \
--cc=upstream@airoha.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).