From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@somainline.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750
Date: Wed, 12 Oct 2022 09:02:32 -0400 [thread overview]
Message-ID: <0829050b-8ef3-e210-9a40-fbec01bb4d21@linaro.org> (raw)
In-Reply-To: <8d43fd52-3bbe-d711-e025-b45a79451ae2@quicinc.com>
On 12/10/2022 02:22, Manikanta Pubbisetty wrote:
>> If you did it, you would see the check will fail. The bindings would
>> report error. There is no need to engage reviewers if bindings find the
>> errors for you, right?
>>
>> Nodes you added here are not allowed.
>>
>
> Thanks for the inputs Krzysztof, I now see the following error
> "smp2p-wpss: 'wlan-ap-to-wpss', 'wlan-wpss-to-ap' do not match any of
> the regexes: '^master-kernel|slave-kernel|ipa-ap-to-modem|ipa-modem-to-ap$'"
>
> After making changes to the smp2p binding, I did not see this error.
> Following are the changes made.
>
> patternProperties:
> - "^master-kernel|slave-kernel|ipa-ap-to-modem|ipa-modem-to-ap$":
> +
> "^master-kernel|slave-kernel|ipa-ap-to-modem|ipa-modem-to-ap|wlan-ap-to-wpss|wlan-wpss-to-ap$":
>
> Shall I go ahead and make the smp2p binding change?
If it is correct change, then yes.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-12 13:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 4:57 [PATCH v2] arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750 Manikanta Pubbisetty
2022-09-26 9:00 ` Krzysztof Kozlowski
2022-09-28 6:00 ` Manikanta Pubbisetty
2022-09-28 6:47 ` Krzysztof Kozlowski
2022-10-03 4:55 ` Manikanta Pubbisetty
2022-10-03 7:59 ` Manikanta Pubbisetty
2022-10-03 8:04 ` Krzysztof Kozlowski
2022-10-12 6:22 ` Manikanta Pubbisetty
2022-10-12 13:02 ` Krzysztof Kozlowski [this message]
2022-09-27 13:08 ` Konrad Dybcio
2022-09-28 6:01 ` Manikanta Pubbisetty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0829050b-8ef3-e210-9a40-fbec01bb4d21@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=quic_mpubbise@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).