From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FF96C433FE for ; Wed, 12 Oct 2022 13:05:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229977AbiJLNE6 (ORCPT ); Wed, 12 Oct 2022 09:04:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229964AbiJLNEs (ORCPT ); Wed, 12 Oct 2022 09:04:48 -0400 Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BE52B877 for ; Wed, 12 Oct 2022 06:04:46 -0700 (PDT) Received: by mail-qv1-xf35.google.com with SMTP id mx8so10821963qvb.8 for ; Wed, 12 Oct 2022 06:04:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=M9U4fPi5GNAg/H+GrZPg2lsLynUd9fsNHOB+vFj+U9I=; b=qKI0Ur+UE5p/xiaydTpqCSSQieHcGXOkm2SqpzECXfcPDKwcUFMOnMnZHP2Z6q7B6U jnhi/UguNrWMVPYzLeGlduv/fbsJ6Hpxo3h9PdgF9X8COXFgxg1ICfHvLfkhp4m0fk+V Y8mB+7w98cXNJOiEcp/HXFs4uwG1pCXe09zZ6HNPh9qCor4Y7snCskyxl0Ghiob73ySy awlnT0aRK/X/xox5Jv+L+VX3hBr8eLvo+yTHPu4ohvDizgIJff1fTi3klEw1C0tp0RQJ lbqZDTNiRdnoqJJZG1UULMWl4+6pQfWg4jM+a9ZSi1jZ6431YLA84rfR1PhSCpy/lR10 buJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M9U4fPi5GNAg/H+GrZPg2lsLynUd9fsNHOB+vFj+U9I=; b=HXqoG4aa6GVal5DubgTW1l0S8tjFVTqibSaFEUK4WqT2f66hGsAa3KPdmbW1R1sEj8 OTaP+pRH0dxlneFYfczHIJsnTM4mWhw0d1uk9MUY7zFXATU4DUgC4ZaCLMo6QLH/OYe3 cGl+eMOIgzUtn4wxYG5hHXu1og83cXoXFfL9hb1CsQOhHi4+JPz+a5YliB1Rnw5Iu7vp 5RRIkPlTCd/cC1MKWq0UMLtJxQbNNUcaVwTkUxBxyvEttWsv+1EWbJp/YV+RNzO9pZqn cS/BKTaf2ceOhGDTcvsbP+Mmai5gFGdO0vti2XiPj9a3XK8RiSDtqyC05AKWhSXUVus0 5flA== X-Gm-Message-State: ACrzQf1Jj7r9DFC1aZ6n63S5B4SDA1EHXboHsYjUz6OThXlqm8XiS3HD Ih+iGjN0WM7K6kaK8zX/wyvPQg== X-Google-Smtp-Source: AMsMyM4df3Hlk1yaiildPII8+BA5RljRoYu9EFFBUn6ZvtLDOEYluoJvE1GkwFaFhCb4wPGMdl5R/w== X-Received: by 2002:a05:6214:224c:b0:4b1:811d:9a06 with SMTP id c12-20020a056214224c00b004b1811d9a06mr23509248qvc.19.1665579885369; Wed, 12 Oct 2022 06:04:45 -0700 (PDT) Received: from [192.168.1.57] (cpe-72-225-192-120.nyc.res.rr.com. [72.225.192.120]) by smtp.gmail.com with ESMTPSA id j10-20020ac806ca000000b00359961365f1sm12324130qth.68.2022.10.12.06.04.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Oct 2022 06:04:44 -0700 (PDT) Message-ID: <0829050b-8ef3-e210-9a40-fbec01bb4d21@linaro.org> Date: Wed, 12 Oct 2022 09:02:32 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v2] arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750 Content-Language: en-US To: Manikanta Pubbisetty , agross@kernel.org, andersson@kernel.org, konrad.dybcio@somainline.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20220926045735.719-1-quic_mpubbise@quicinc.com> <8d43fd52-3bbe-d711-e025-b45a79451ae2@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <8d43fd52-3bbe-d711-e025-b45a79451ae2@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/10/2022 02:22, Manikanta Pubbisetty wrote: >> If you did it, you would see the check will fail. The bindings would >> report error. There is no need to engage reviewers if bindings find the >> errors for you, right? >> >> Nodes you added here are not allowed. >> > > Thanks for the inputs Krzysztof, I now see the following error > "smp2p-wpss: 'wlan-ap-to-wpss', 'wlan-wpss-to-ap' do not match any of > the regexes: '^master-kernel|slave-kernel|ipa-ap-to-modem|ipa-modem-to-ap$'" > > After making changes to the smp2p binding, I did not see this error. > Following are the changes made. > > patternProperties: > - "^master-kernel|slave-kernel|ipa-ap-to-modem|ipa-modem-to-ap$": > + > "^master-kernel|slave-kernel|ipa-ap-to-modem|ipa-modem-to-ap|wlan-ap-to-wpss|wlan-wpss-to-ap$": > > Shall I go ahead and make the smp2p binding change? If it is correct change, then yes. Best regards, Krzysztof