* [PATCH v2] arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750
@ 2022-09-26 4:57 Manikanta Pubbisetty
2022-09-26 9:00 ` Krzysztof Kozlowski
2022-09-27 13:08 ` Konrad Dybcio
0 siblings, 2 replies; 11+ messages in thread
From: Manikanta Pubbisetty @ 2022-09-26 4:57 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt
Cc: linux-arm-msm, devicetree, Manikanta Pubbisetty
Add DT nodes to support WoW (Wake on Wireless) feature on WCN6750
WiFi hardware on SC7280 SoC.
Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
---
Changes from V1:
- Rebased on ToT
arch/arm64/boot/dts/qcom/sc7280.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 212580316d3e..3f6a3f575339 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -752,6 +752,17 @@ wpss_smp2p_in: slave-kernel {
interrupt-controller;
#interrupt-cells = <2>;
};
+
+ wlan_smp2p_out: wlan-ap-to-wpss {
+ qcom,entry-name = "wlan";
+ #qcom,smem-state-cells = <1>;
+ };
+
+ wlan_smp2p_in: wlan-wpss-to-ap {
+ qcom,entry-name = "wlan";
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
};
pmu {
@@ -2004,6 +2015,8 @@ wifi: wifi@17a10040 {
qcom,rproc = <&remoteproc_wpss>;
memory-region = <&wlan_fw_mem>, <&wlan_ce_mem>;
status = "disabled";
+ qcom,smem-states = <&wlan_smp2p_out 0>;
+ qcom,smem-state-names = "wlan-smp2p-out";
};
pcie1: pci@1c08000 {
base-commit: aaa11ce2ffc84166d11c4d2ac88c3fcf75425fbd
--
2.37.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750
2022-09-26 4:57 [PATCH v2] arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750 Manikanta Pubbisetty
@ 2022-09-26 9:00 ` Krzysztof Kozlowski
2022-09-28 6:00 ` Manikanta Pubbisetty
2022-09-27 13:08 ` Konrad Dybcio
1 sibling, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 9:00 UTC (permalink / raw)
To: Manikanta Pubbisetty, agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt
Cc: linux-arm-msm, devicetree
On 26/09/2022 06:57, Manikanta Pubbisetty wrote:
> Add DT nodes to support WoW (Wake on Wireless) feature on WCN6750
> WiFi hardware on SC7280 SoC.
>
> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
Thank you for your patch. There is something to discuss/improve.
> ---
> Changes from V1:
> - Rebased on ToT
>
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 212580316d3e..3f6a3f575339 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -752,6 +752,17 @@ wpss_smp2p_in: slave-kernel {
> interrupt-controller;
> #interrupt-cells = <2>;
> };
> +
> + wlan_smp2p_out: wlan-ap-to-wpss {
Does not look like you tested the DTS against bindings. Please run `make
dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
for instructions).
> + qcom,entry-name = "wlan";
> + #qcom,smem-state-cells = <1>;
> + };
> +
> + wlan_smp2p_in: wlan-wpss-to-ap {
> + qcom,entry-name = "wlan";
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> };
>
> pmu {
> @@ -2004,6 +2015,8 @@ wifi: wifi@17a10040 {
> qcom,rproc = <&remoteproc_wpss>;
> memory-region = <&wlan_fw_mem>, <&wlan_ce_mem>;
> status = "disabled";
status is the last.
> + qcom,smem-states = <&wlan_smp2p_out 0>;
> + qcom,smem-state-names = "wlan-smp2p-out";
Are these valid properties for this node? Did you check with bindings?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750
2022-09-26 9:00 ` Krzysztof Kozlowski
@ 2022-09-28 6:00 ` Manikanta Pubbisetty
2022-09-28 6:47 ` Krzysztof Kozlowski
0 siblings, 1 reply; 11+ messages in thread
From: Manikanta Pubbisetty @ 2022-09-28 6:00 UTC (permalink / raw)
To: Krzysztof Kozlowski, agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt
Cc: linux-arm-msm, devicetree
On 9/26/2022 2:30 PM, Krzysztof Kozlowski wrote:
> On 26/09/2022 06:57, Manikanta Pubbisetty wrote:
>> Add DT nodes to support WoW (Wake on Wireless) feature on WCN6750
>> WiFi hardware on SC7280 SoC.
>>
>> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
>
> Thank you for your patch. There is something to discuss/improve.
>
>
>> ---
>> Changes from V1:
>> - Rebased on ToT
>>
>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 212580316d3e..3f6a3f575339 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -752,6 +752,17 @@ wpss_smp2p_in: slave-kernel {
>> interrupt-controller;
>> #interrupt-cells = <2>;
>> };
>> +
>> + wlan_smp2p_out: wlan-ap-to-wpss {
>
> Does not look like you tested the DTS against bindings. Please run `make
> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
> for instructions).
>
I'm sorry I was not aware of checking the DTS against bindings. I'll do
the due diligence going forward. `make dtbs_check is throwing error of
"No rule to make target". Not sure if we need pass any options to the
command. I did try to understand the problem but all went in vain. Pls
help understand if I'm missing anything.
>> + qcom,entry-name = "wlan";
>> + #qcom,smem-state-cells = <1>;
>> + };
>> +
>> + wlan_smp2p_in: wlan-wpss-to-ap {
>> + qcom,entry-name = "wlan";
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + };
>> };
>>
>> pmu {
>> @@ -2004,6 +2015,8 @@ wifi: wifi@17a10040 {
>> qcom,rproc = <&remoteproc_wpss>;
>> memory-region = <&wlan_fw_mem>, <&wlan_ce_mem>;
>> status = "disabled";
>
> status is the last.
Sure.
>
>> + qcom,smem-states = <&wlan_smp2p_out 0>;
>> + qcom,smem-state-names = "wlan-smp2p-out";
>
> Are these valid properties for this node? Did you check with bindings?
>
These are valid properties IIUC. Pls help check the binding here
https://patchwork.kernel.org/project/linux-wireless/patch/20220902112520.24804-2-quic_mpubbise@quicinc.com/
.
Thanks,
Manikanta
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750
2022-09-28 6:00 ` Manikanta Pubbisetty
@ 2022-09-28 6:47 ` Krzysztof Kozlowski
2022-10-03 4:55 ` Manikanta Pubbisetty
0 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-28 6:47 UTC (permalink / raw)
To: Manikanta Pubbisetty, agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt
Cc: linux-arm-msm, devicetree
On 28/09/2022 08:00, Manikanta Pubbisetty wrote:
> On 9/26/2022 2:30 PM, Krzysztof Kozlowski wrote:
>> On 26/09/2022 06:57, Manikanta Pubbisetty wrote:
>>> Add DT nodes to support WoW (Wake on Wireless) feature on WCN6750
>>> WiFi hardware on SC7280 SoC.
>>>
>>> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
>>
>> Thank you for your patch. There is something to discuss/improve.
>>
>>
>>> ---
>>> Changes from V1:
>>> - Rebased on ToT
>>>
>>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 13 +++++++++++++
>>> 1 file changed, 13 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>> index 212580316d3e..3f6a3f575339 100644
>>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>> @@ -752,6 +752,17 @@ wpss_smp2p_in: slave-kernel {
>>> interrupt-controller;
>>> #interrupt-cells = <2>;
>>> };
>>> +
>>> + wlan_smp2p_out: wlan-ap-to-wpss {
>>
>> Does not look like you tested the DTS against bindings. Please run `make
>> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
>> for instructions).
>>
>
> I'm sorry I was not aware of checking the DTS against bindings. I'll do
> the due diligence going forward. `make dtbs_check is throwing error of
> "No rule to make target". Not sure if we need pass any options to the
> command. I did try to understand the problem but all went in vain. Pls
> help understand if I'm missing anything.
There is doc explaining possible usage, but in general works perfect
without argument. If you do not have such target, means you run it on
some ancient kernel, so anyway patch cannot be accepted and has to be
rebased. Please always develop on newest kernel - newest mainline rc,
maintainer's for-next branch or linux-next.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750
2022-09-28 6:47 ` Krzysztof Kozlowski
@ 2022-10-03 4:55 ` Manikanta Pubbisetty
2022-10-03 7:59 ` Manikanta Pubbisetty
0 siblings, 1 reply; 11+ messages in thread
From: Manikanta Pubbisetty @ 2022-10-03 4:55 UTC (permalink / raw)
To: Krzysztof Kozlowski, agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt
Cc: linux-arm-msm, devicetree
On 9/28/2022 12:17 PM, Krzysztof Kozlowski wrote:
> On 28/09/2022 08:00, Manikanta Pubbisetty wrote:
>> On 9/26/2022 2:30 PM, Krzysztof Kozlowski wrote:
>>> On 26/09/2022 06:57, Manikanta Pubbisetty wrote:
>>>> Add DT nodes to support WoW (Wake on Wireless) feature on WCN6750
>>>> WiFi hardware on SC7280 SoC.
>>>>
>>>> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
>>>
>>> Thank you for your patch. There is something to discuss/improve.
>>>
>>>
>>>> ---
>>>> Changes from V1:
>>>> - Rebased on ToT
>>>>
>>>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 13 +++++++++++++
>>>> 1 file changed, 13 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>>> index 212580316d3e..3f6a3f575339 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>>> @@ -752,6 +752,17 @@ wpss_smp2p_in: slave-kernel {
>>>> interrupt-controller;
>>>> #interrupt-cells = <2>;
>>>> };
>>>> +
>>>> + wlan_smp2p_out: wlan-ap-to-wpss {
>>>
>>> Does not look like you tested the DTS against bindings. Please run `make
>>> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
>>> for instructions).
>>>
>>
>> I'm sorry I was not aware of checking the DTS against bindings. I'll do
>> the due diligence going forward. `make dtbs_check is throwing error of
>> "No rule to make target". Not sure if we need pass any options to the
>> command. I did try to understand the problem but all went in vain. Pls
>> help understand if I'm missing anything.
>
> There is doc explaining possible usage, but in general works perfect
> without argument. If you do not have such target, means you run it on
> some ancient kernel, so anyway patch cannot be accepted and has to be
> rebased. Please always develop on newest kernel - newest mainline rc,
> maintainer's for-next branch or linux-next.
>
I'm working on the latest kernel (ath.git which is maintained by Kalle
Valo for Atheros drivers). I'll give a try on the linux-next branch once.
Thanks for the suggestions.
Manikanta
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750
2022-10-03 4:55 ` Manikanta Pubbisetty
@ 2022-10-03 7:59 ` Manikanta Pubbisetty
2022-10-03 8:04 ` Krzysztof Kozlowski
0 siblings, 1 reply; 11+ messages in thread
From: Manikanta Pubbisetty @ 2022-10-03 7:59 UTC (permalink / raw)
To: Krzysztof Kozlowski, agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt
Cc: linux-arm-msm, devicetree
On 10/3/2022 10:25 AM, Manikanta Pubbisetty wrote:
> On 9/28/2022 12:17 PM, Krzysztof Kozlowski wrote:
>> On 28/09/2022 08:00, Manikanta Pubbisetty wrote:
>>> On 9/26/2022 2:30 PM, Krzysztof Kozlowski wrote:
>>>> On 26/09/2022 06:57, Manikanta Pubbisetty wrote:
>>>>> Add DT nodes to support WoW (Wake on Wireless) feature on WCN6750
>>>>> WiFi hardware on SC7280 SoC.
>>>>>
>>>>> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
>>>>
>>>> Thank you for your patch. There is something to discuss/improve.
>>>>
>>>>
>>>>> ---
>>>>> Changes from V1:
>>>>> - Rebased on ToT
>>>>>
>>>>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 13 +++++++++++++
>>>>> 1 file changed, 13 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>>>> b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>>>> index 212580316d3e..3f6a3f575339 100644
>>>>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>>>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>>>> @@ -752,6 +752,17 @@ wpss_smp2p_in: slave-kernel {
>>>>> interrupt-controller;
>>>>> #interrupt-cells = <2>;
>>>>> };
>>>>> +
>>>>> + wlan_smp2p_out: wlan-ap-to-wpss {
>>>>
>>>> Does not look like you tested the DTS against bindings. Please run
>>>> `make
>>>> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
>>>> for instructions).
>>>>
>>>
>>> I'm sorry I was not aware of checking the DTS against bindings. I'll do
>>> the due diligence going forward. `make dtbs_check is throwing error of
>>> "No rule to make target". Not sure if we need pass any options to the
>>> command. I did try to understand the problem but all went in vain. Pls
>>> help understand if I'm missing anything.
>>
>> There is doc explaining possible usage, but in general works perfect
>> without argument. If you do not have such target, means you run it on
>> some ancient kernel, so anyway patch cannot be accepted and has to be
>> rebased. Please always develop on newest kernel - newest mainline rc,
>> maintainer's for-next branch or linux-next.
>>
>
> I'm working on the latest kernel (ath.git which is maintained by Kalle
> Valo for Atheros drivers). I'll give a try on the linux-next branch once.
>
> Thanks for the suggestions.
>
Hi Krzysztof,
I have tested the DTS against the bindings. Have used this command `make
CROSS_COMPILE=aarch64-linux-gnu- ARCH=arm64 dtbs_check -m
DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml`.
`make dtbs_check` did not report any error.
Thanks,
Manikanta
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750
2022-10-03 7:59 ` Manikanta Pubbisetty
@ 2022-10-03 8:04 ` Krzysztof Kozlowski
2022-10-12 6:22 ` Manikanta Pubbisetty
0 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-03 8:04 UTC (permalink / raw)
To: Manikanta Pubbisetty, agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt
Cc: linux-arm-msm, devicetree
On 03/10/2022 09:59, Manikanta Pubbisetty wrote:
> On 10/3/2022 10:25 AM, Manikanta Pubbisetty wrote:
>> On 9/28/2022 12:17 PM, Krzysztof Kozlowski wrote:
>>> On 28/09/2022 08:00, Manikanta Pubbisetty wrote:
>>>> On 9/26/2022 2:30 PM, Krzysztof Kozlowski wrote:
>>>>> On 26/09/2022 06:57, Manikanta Pubbisetty wrote:
>>>>>> Add DT nodes to support WoW (Wake on Wireless) feature on WCN6750
>>>>>> WiFi hardware on SC7280 SoC.
>>>>>>
>>>>>> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
>>>>>
>>>>> Thank you for your patch. There is something to discuss/improve.
>>>>>
>>>>>
>>>>>> ---
>>>>>> Changes from V1:
>>>>>> - Rebased on ToT
>>>>>>
>>>>>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 13 +++++++++++++
>>>>>> 1 file changed, 13 insertions(+)
>>>>>>
>>>>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>>>>> b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>>>>> index 212580316d3e..3f6a3f575339 100644
>>>>>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>>>>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>>>>> @@ -752,6 +752,17 @@ wpss_smp2p_in: slave-kernel {
>>>>>> interrupt-controller;
>>>>>> #interrupt-cells = <2>;
>>>>>> };
>>>>>> +
>>>>>> + wlan_smp2p_out: wlan-ap-to-wpss {
>>>>>
>>>>> Does not look like you tested the DTS against bindings. Please run
>>>>> `make
>>>>> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
>>>>> for instructions).
>>>>>
>>>>
>>>> I'm sorry I was not aware of checking the DTS against bindings. I'll do
>>>> the due diligence going forward. `make dtbs_check is throwing error of
>>>> "No rule to make target". Not sure if we need pass any options to the
>>>> command. I did try to understand the problem but all went in vain. Pls
>>>> help understand if I'm missing anything.
>>>
>>> There is doc explaining possible usage, but in general works perfect
>>> without argument. If you do not have such target, means you run it on
>>> some ancient kernel, so anyway patch cannot be accepted and has to be
>>> rebased. Please always develop on newest kernel - newest mainline rc,
>>> maintainer's for-next branch or linux-next.
>>>
>>
>> I'm working on the latest kernel (ath.git which is maintained by Kalle
>> Valo for Atheros drivers). I'll give a try on the linux-next branch once.
>>
>> Thanks for the suggestions.
>>
>
> Hi Krzysztof,
>
> I have tested the DTS against the bindings. Have used this command `make
> CROSS_COMPILE=aarch64-linux-gnu- ARCH=arm64 dtbs_check -m
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml`.
>
> `make dtbs_check` did not report any error.
You selected some schema to test, so yes, maybe it passes. It's not a
proof of anything. Run with either applicable bindings (the one which I
commented about) or with all of them.
If you did it, you would see the check will fail. The bindings would
report error. There is no need to engage reviewers if bindings find the
errors for you, right?
Nodes you added here are not allowed.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750
2022-10-03 8:04 ` Krzysztof Kozlowski
@ 2022-10-12 6:22 ` Manikanta Pubbisetty
2022-10-12 13:02 ` Krzysztof Kozlowski
0 siblings, 1 reply; 11+ messages in thread
From: Manikanta Pubbisetty @ 2022-10-12 6:22 UTC (permalink / raw)
To: Krzysztof Kozlowski, agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt
Cc: linux-arm-msm, devicetree
On 10/3/2022 1:34 PM, Krzysztof Kozlowski wrote:
> On 03/10/2022 09:59, Manikanta Pubbisetty wrote:
>> On 10/3/2022 10:25 AM, Manikanta Pubbisetty wrote:
>>> On 9/28/2022 12:17 PM, Krzysztof Kozlowski wrote:
>>>> On 28/09/2022 08:00, Manikanta Pubbisetty wrote:
>>>>> On 9/26/2022 2:30 PM, Krzysztof Kozlowski wrote:
>>>>>> On 26/09/2022 06:57, Manikanta Pubbisetty wrote:
>>>>>>> Add DT nodes to support WoW (Wake on Wireless) feature on WCN6750
>>>>>>> WiFi hardware on SC7280 SoC.
>>>>>>>
>>>>>>> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
>>>>>>
>>>>>> Thank you for your patch. There is something to discuss/improve.
>>>>>>
>>>>>>
>>>>>>> ---
>>>>>>> Changes from V1:
>>>>>>> - Rebased on ToT
>>>>>>>
>>>>>>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 13 +++++++++++++
>>>>>>> 1 file changed, 13 insertions(+)
>>>>>>>
>>>>>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>>>>>> b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>>>>>> index 212580316d3e..3f6a3f575339 100644
>>>>>>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>>>>>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>>>>>> @@ -752,6 +752,17 @@ wpss_smp2p_in: slave-kernel {
>>>>>>> interrupt-controller;
>>>>>>> #interrupt-cells = <2>;
>>>>>>> };
>>>>>>> +
>>>>>>> + wlan_smp2p_out: wlan-ap-to-wpss {
>>>>>>
>>>>>> Does not look like you tested the DTS against bindings. Please run
>>>>>> `make
>>>>>> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
>>>>>> for instructions).
>>>>>>
>>>>>
>>>>> I'm sorry I was not aware of checking the DTS against bindings. I'll do
>>>>> the due diligence going forward. `make dtbs_check is throwing error of
>>>>> "No rule to make target". Not sure if we need pass any options to the
>>>>> command. I did try to understand the problem but all went in vain. Pls
>>>>> help understand if I'm missing anything.
>>>>
>>>> There is doc explaining possible usage, but in general works perfect
>>>> without argument. If you do not have such target, means you run it on
>>>> some ancient kernel, so anyway patch cannot be accepted and has to be
>>>> rebased. Please always develop on newest kernel - newest mainline rc,
>>>> maintainer's for-next branch or linux-next.
>>>>
>>>
>>> I'm working on the latest kernel (ath.git which is maintained by Kalle
>>> Valo for Atheros drivers). I'll give a try on the linux-next branch once.
>>>
>>> Thanks for the suggestions.
>>>
>>
>> Hi Krzysztof,
>>
>> I have tested the DTS against the bindings. Have used this command `make
>> CROSS_COMPILE=aarch64-linux-gnu- ARCH=arm64 dtbs_check -m
>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml`.
>>
>> `make dtbs_check` did not report any error.
>
> You selected some schema to test, so yes, maybe it passes. It's not a
> proof of anything. Run with either applicable bindings (the one which I
> commented about) or with all of them.
>
> If you did it, you would see the check will fail. The bindings would
> report error. There is no need to engage reviewers if bindings find the
> errors for you, right?
>
> Nodes you added here are not allowed.
>
Thanks for the inputs Krzysztof, I now see the following error
"smp2p-wpss: 'wlan-ap-to-wpss', 'wlan-wpss-to-ap' do not match any of
the regexes: '^master-kernel|slave-kernel|ipa-ap-to-modem|ipa-modem-to-ap$'"
After making changes to the smp2p binding, I did not see this error.
Following are the changes made.
patternProperties:
- "^master-kernel|slave-kernel|ipa-ap-to-modem|ipa-modem-to-ap$":
+
"^master-kernel|slave-kernel|ipa-ap-to-modem|ipa-modem-to-ap|wlan-ap-to-wpss|wlan-wpss-to-ap$":
Shall I go ahead and make the smp2p binding change?
Thanks,
Manikanta
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750
2022-10-12 6:22 ` Manikanta Pubbisetty
@ 2022-10-12 13:02 ` Krzysztof Kozlowski
0 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-12 13:02 UTC (permalink / raw)
To: Manikanta Pubbisetty, agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt
Cc: linux-arm-msm, devicetree
On 12/10/2022 02:22, Manikanta Pubbisetty wrote:
>> If you did it, you would see the check will fail. The bindings would
>> report error. There is no need to engage reviewers if bindings find the
>> errors for you, right?
>>
>> Nodes you added here are not allowed.
>>
>
> Thanks for the inputs Krzysztof, I now see the following error
> "smp2p-wpss: 'wlan-ap-to-wpss', 'wlan-wpss-to-ap' do not match any of
> the regexes: '^master-kernel|slave-kernel|ipa-ap-to-modem|ipa-modem-to-ap$'"
>
> After making changes to the smp2p binding, I did not see this error.
> Following are the changes made.
>
> patternProperties:
> - "^master-kernel|slave-kernel|ipa-ap-to-modem|ipa-modem-to-ap$":
> +
> "^master-kernel|slave-kernel|ipa-ap-to-modem|ipa-modem-to-ap|wlan-ap-to-wpss|wlan-wpss-to-ap$":
>
> Shall I go ahead and make the smp2p binding change?
If it is correct change, then yes.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750
2022-09-26 4:57 [PATCH v2] arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750 Manikanta Pubbisetty
2022-09-26 9:00 ` Krzysztof Kozlowski
@ 2022-09-27 13:08 ` Konrad Dybcio
2022-09-28 6:01 ` Manikanta Pubbisetty
1 sibling, 1 reply; 11+ messages in thread
From: Konrad Dybcio @ 2022-09-27 13:08 UTC (permalink / raw)
To: Manikanta Pubbisetty, agross, andersson, robh+dt,
krzysztof.kozlowski+dt
Cc: linux-arm-msm, devicetree
On 26.09.2022 06:57, Manikanta Pubbisetty wrote:
> Add DT nodes to support WoW (Wake on Wireless) feature on WCN6750
> WiFi hardware on SC7280 SoC.
>
> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
> ---
> Changes from V1:
> - Rebased on ToT
>
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 212580316d3e..3f6a3f575339 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -752,6 +752,17 @@ wpss_smp2p_in: slave-kernel {
> interrupt-controller;
> #interrupt-cells = <2>;
> };
> +
> + wlan_smp2p_out: wlan-ap-to-wpss {
> + qcom,entry-name = "wlan";
> + #qcom,smem-state-cells = <1>;
> + };
> +
> + wlan_smp2p_in: wlan-wpss-to-ap {
> + qcom,entry-name = "wlan";
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> };
>
> pmu {
> @@ -2004,6 +2015,8 @@ wifi: wifi@17a10040 {
> qcom,rproc = <&remoteproc_wpss>;
> memory-region = <&wlan_fw_mem>, <&wlan_ce_mem>;
> status = "disabled";
> + qcom,smem-states = <&wlan_smp2p_out 0>;
> + qcom,smem-state-names = "wlan-smp2p-out";
Keep status last, please.
Other than that:
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> };
>
> pcie1: pci@1c08000 {
>
> base-commit: aaa11ce2ffc84166d11c4d2ac88c3fcf75425fbd
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750
2022-09-27 13:08 ` Konrad Dybcio
@ 2022-09-28 6:01 ` Manikanta Pubbisetty
0 siblings, 0 replies; 11+ messages in thread
From: Manikanta Pubbisetty @ 2022-09-28 6:01 UTC (permalink / raw)
To: Konrad Dybcio, agross, andersson, robh+dt, krzysztof.kozlowski+dt
Cc: linux-arm-msm, devicetree
On 9/27/2022 6:38 PM, Konrad Dybcio wrote:
>
>
> On 26.09.2022 06:57, Manikanta Pubbisetty wrote:
>> Add DT nodes to support WoW (Wake on Wireless) feature on WCN6750
>> WiFi hardware on SC7280 SoC.
>>
>> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
>> ---
>> Changes from V1:
>> - Rebased on ToT
>>
>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 212580316d3e..3f6a3f575339 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -752,6 +752,17 @@ wpss_smp2p_in: slave-kernel {
>> interrupt-controller;
>> #interrupt-cells = <2>;
>> };
>> +
>> + wlan_smp2p_out: wlan-ap-to-wpss {
>> + qcom,entry-name = "wlan";
>> + #qcom,smem-state-cells = <1>;
>> + };
>> +
>> + wlan_smp2p_in: wlan-wpss-to-ap {
>> + qcom,entry-name = "wlan";
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + };
>> };
>>
>> pmu {
>> @@ -2004,6 +2015,8 @@ wifi: wifi@17a10040 {
>> qcom,rproc = <&remoteproc_wpss>;
>> memory-region = <&wlan_fw_mem>, <&wlan_ce_mem>;
>> status = "disabled";
>> + qcom,smem-states = <&wlan_smp2p_out 0>;
>> + qcom,smem-state-names = "wlan-smp2p-out";
> Keep status last, please.
>
Sure.
> Other than that:
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
>
Thanks for the review.
Manikanta
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-10-12 13:05 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-26 4:57 [PATCH v2] arm64: dts: qcom: sc7280: Add nodes to support WoW on WCN6750 Manikanta Pubbisetty
2022-09-26 9:00 ` Krzysztof Kozlowski
2022-09-28 6:00 ` Manikanta Pubbisetty
2022-09-28 6:47 ` Krzysztof Kozlowski
2022-10-03 4:55 ` Manikanta Pubbisetty
2022-10-03 7:59 ` Manikanta Pubbisetty
2022-10-03 8:04 ` Krzysztof Kozlowski
2022-10-12 6:22 ` Manikanta Pubbisetty
2022-10-12 13:02 ` Krzysztof Kozlowski
2022-09-27 13:08 ` Konrad Dybcio
2022-09-28 6:01 ` Manikanta Pubbisetty
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).