From: Kukjin Kim <kgene@kernel.org>
To: 'Sachin Kamat' <sachin.kamat@linaro.org>,
linux-samsung-soc@vger.kernel.org
Cc: tushar.behera@linaro.org, patches@linaro.org, devicetree@vger.kernel.org
Subject: RE: [PATCH 2/2] ARM: dts: Update display clock frequency for Origen-4412
Date: Tue, 12 Nov 2013 19:17:45 +0900 [thread overview]
Message-ID: <085801cedf90$6e2a6580$4a7f3080$@org> (raw)
In-Reply-To: <1380171018-24229-2-git-send-email-sachin.kamat@linaro.org>
Sachin Kamat wrote:
>
+ dt ml.
> As per the timing information for supported panel, the value should
> be between 47.2 MHz to 47.9 MHz for 60Hz refresh rate.
>
> Total horizontal pixels = 1024 (x-res) + 80 (margin) + 48 (hsync) = 1152
> Total vertical pixels = 600 (y-res) + 80 (margin) + 3 (vsync) = 653
Should be 683?
>
> Target pixel clock rate for refresh rate @60 Hz
> = 1152 * 653 * 60 = 47208960 Hz ~ 47.5 MHz
>
Same here.
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> arch/arm/boot/dts/exynos4412-origen.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos4412-origen.dts
> b/arch/arm/boot/dts/exynos4412-origen.dts
> index 8768b03..923bcd7 100644
> --- a/arch/arm/boot/dts/exynos4412-origen.dts
> +++ b/arch/arm/boot/dts/exynos4412-origen.dts
> @@ -152,7 +152,7 @@
> display-timings {
> native-mode = <&timing0>;
> timing0: timing {
> - clock-frequency = <50000>;
> + clock-frequency = <47500000>;
> hactive = <1024>;
> vactive = <600>;
> hfront-porch = <64>;
> --
> 1.7.9.5
Please make sure it works fine on both origen boards with your two fixes.
If so, let me pick them up into Samsung tree after squash into one patch.
Thanks,
Kukjin
next parent reply other threads:[~2013-11-12 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1380171018-24229-1-git-send-email-sachin.kamat@linaro.org>
[not found] ` <1380171018-24229-2-git-send-email-sachin.kamat@linaro.org>
2013-11-12 10:17 ` Kukjin Kim [this message]
2013-11-13 3:47 ` [PATCH 2/2] ARM: dts: Update display clock frequency for Origen-4412 Tushar Behera
2013-12-02 4:14 ` Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='085801cedf90$6e2a6580$4a7f3080$@org' \
--to=kgene@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).