* RE: [PATCH 2/2] ARM: dts: Update display clock frequency for Origen-4412
[not found] ` <1380171018-24229-2-git-send-email-sachin.kamat@linaro.org>
@ 2013-11-12 10:17 ` Kukjin Kim
2013-11-13 3:47 ` Tushar Behera
0 siblings, 1 reply; 3+ messages in thread
From: Kukjin Kim @ 2013-11-12 10:17 UTC (permalink / raw)
To: 'Sachin Kamat', linux-samsung-soc
Cc: tushar.behera, patches, devicetree
Sachin Kamat wrote:
>
+ dt ml.
> As per the timing information for supported panel, the value should
> be between 47.2 MHz to 47.9 MHz for 60Hz refresh rate.
>
> Total horizontal pixels = 1024 (x-res) + 80 (margin) + 48 (hsync) = 1152
> Total vertical pixels = 600 (y-res) + 80 (margin) + 3 (vsync) = 653
Should be 683?
>
> Target pixel clock rate for refresh rate @60 Hz
> = 1152 * 653 * 60 = 47208960 Hz ~ 47.5 MHz
>
Same here.
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> arch/arm/boot/dts/exynos4412-origen.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos4412-origen.dts
> b/arch/arm/boot/dts/exynos4412-origen.dts
> index 8768b03..923bcd7 100644
> --- a/arch/arm/boot/dts/exynos4412-origen.dts
> +++ b/arch/arm/boot/dts/exynos4412-origen.dts
> @@ -152,7 +152,7 @@
> display-timings {
> native-mode = <&timing0>;
> timing0: timing {
> - clock-frequency = <50000>;
> + clock-frequency = <47500000>;
> hactive = <1024>;
> vactive = <600>;
> hfront-porch = <64>;
> --
> 1.7.9.5
Please make sure it works fine on both origen boards with your two fixes.
If so, let me pick them up into Samsung tree after squash into one patch.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] ARM: dts: Update display clock frequency for Origen-4412
2013-11-12 10:17 ` [PATCH 2/2] ARM: dts: Update display clock frequency for Origen-4412 Kukjin Kim
@ 2013-11-13 3:47 ` Tushar Behera
2013-12-02 4:14 ` Sachin Kamat
0 siblings, 1 reply; 3+ messages in thread
From: Tushar Behera @ 2013-11-13 3:47 UTC (permalink / raw)
To: Kukjin Kim; +Cc: Sachin Kamat, linux-samsung-soc, Patch Tracking, devicetree
On 12 November 2013 15:47, Kukjin Kim <kgene@kernel.org> wrote:
> Sachin Kamat wrote:
>>
> + dt ml.
>
>> As per the timing information for supported panel, the value should
>> be between 47.2 MHz to 47.9 MHz for 60Hz refresh rate.
>>
>> Total horizontal pixels = 1024 (x-res) + 80 (margin) + 48 (hsync) = 1152
>> Total vertical pixels = 600 (y-res) + 80 (margin) + 3 (vsync) = 653
>
> Should be 683?
>
>>
>> Target pixel clock rate for refresh rate @60 Hz
>> = 1152 * 653 * 60 = 47208960 Hz ~ 47.5 MHz
>>
> Same here.
>
Yes, typo in both the cases, however the calculation is right. The
same typo in patch 1/2 also. You may please fix them while applying.
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>> arch/arm/boot/dts/exynos4412-origen.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos4412-origen.dts
>> b/arch/arm/boot/dts/exynos4412-origen.dts
>> index 8768b03..923bcd7 100644
>> --- a/arch/arm/boot/dts/exynos4412-origen.dts
>> +++ b/arch/arm/boot/dts/exynos4412-origen.dts
>> @@ -152,7 +152,7 @@
>> display-timings {
>> native-mode = <&timing0>;
>> timing0: timing {
>> - clock-frequency = <50000>;
>> + clock-frequency = <47500000>;
>> hactive = <1024>;
>> vactive = <600>;
>> hfront-porch = <64>;
>> --
>> 1.7.9.5
>
> Please make sure it works fine on both origen boards with your two fixes.
>
> If so, let me pick them up into Samsung tree after squash into one patch.
>
> Thanks,
> Kukjin
>
Thanks.
--
Tushar Behera
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] ARM: dts: Update display clock frequency for Origen-4412
2013-11-13 3:47 ` Tushar Behera
@ 2013-12-02 4:14 ` Sachin Kamat
0 siblings, 0 replies; 3+ messages in thread
From: Sachin Kamat @ 2013-12-02 4:14 UTC (permalink / raw)
To: Tushar Behera; +Cc: Kukjin Kim, linux-samsung-soc, devicetree, Sachin Kamat
On 13 November 2013 09:17, Tushar Behera <tushar.behera@linaro.org> wrote:
> On 12 November 2013 15:47, Kukjin Kim <kgene@kernel.org> wrote:
>> Sachin Kamat wrote:
>>>
>> + dt ml.
>>
>>> As per the timing information for supported panel, the value should
>>> be between 47.2 MHz to 47.9 MHz for 60Hz refresh rate.
>>>
>>> Total horizontal pixels = 1024 (x-res) + 80 (margin) + 48 (hsync) = 1152
>>> Total vertical pixels = 600 (y-res) + 80 (margin) + 3 (vsync) = 653
>>
>> Should be 683?
>>
>>>
>>> Target pixel clock rate for refresh rate @60 Hz
>>> = 1152 * 653 * 60 = 47208960 Hz ~ 47.5 MHz
>>>
>> Same here.
>>
>
> Yes, typo in both the cases, however the calculation is right. The
> same typo in patch 1/2 also. You may please fix them while applying.
>
Ping Kukjin.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-02 4:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1380171018-24229-1-git-send-email-sachin.kamat@linaro.org>
[not found] ` <1380171018-24229-2-git-send-email-sachin.kamat@linaro.org>
2013-11-12 10:17 ` [PATCH 2/2] ARM: dts: Update display clock frequency for Origen-4412 Kukjin Kim
2013-11-13 3:47 ` Tushar Behera
2013-12-02 4:14 ` Sachin Kamat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).