From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tinghan Shen <tinghan.shen@mediatek.com>,
Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
MandyJH Liu <mandyjh.liu@mediatek.com>
Cc: iommu@lists.linux.dev, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v3 08/21] arm64: dts: mediatek: Update mt81xx scpsys node to align with dt-bindings
Date: Wed, 20 Jul 2022 19:39:23 +0200 [thread overview]
Message-ID: <085a003e-576d-b39a-60ce-ca8f53c89d43@linaro.org> (raw)
In-Reply-To: <20220720123023.13500-9-tinghan.shen@mediatek.com>
On 20/07/2022 14:30, Tinghan Shen wrote:
> Update scpsys nodes using simple-mfd in mt81xx SoC devicetree
> to align with the bindings.
"Update" is not accurate enough description. The same in commit title.
It answers "why" you are doing it, but does not answer what exactly you
are changing here and what is the effect. IOW, you need to explain the
true logic behind it - 10006000 is not power domain provider etc.
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-20 17:39 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 12:30 [PATCH v3 00/21] Add driver nodes for MT8195 SoC Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 01/21] dt-bindings: iommu: mediatek: Increase max interrupt number Tinghan Shen
2022-07-20 17:30 ` Krzysztof Kozlowski
2022-07-20 12:30 ` [PATCH v3 02/21] dt-bindings: memory: mediatek: Update condition for mt8195 smi node Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 03/21] dt-bindings: power: mediatek: Refine multiple level power domain nodes Tinghan Shen
2022-07-20 17:32 ` Krzysztof Kozlowski
2022-07-20 12:30 ` [PATCH v3 04/21] dt-bindings: power: mediatek: Support naming power controller node with unit address Tinghan Shen
2022-07-20 17:32 ` Krzysztof Kozlowski
2022-07-20 12:30 ` [PATCH v3 05/21] dt-bindings: power: mediatek: Update maintainer list Tinghan Shen
2022-07-25 22:24 ` Rob Herring
2022-07-20 12:30 ` [PATCH v3 06/21] dt-bindings: power: mediatek: Add bindings for MediaTek SCPSYS Tinghan Shen
2022-07-20 13:31 ` Lee Jones
2022-07-20 17:37 ` Krzysztof Kozlowski
2022-07-21 2:35 ` Tinghan Shen
2022-07-21 11:36 ` Lee Jones
2022-07-20 17:35 ` Krzysztof Kozlowski
2022-07-21 3:05 ` Tinghan Shen
2022-07-21 6:34 ` Krzysztof Kozlowski
2022-07-20 12:30 ` [PATCH v3 07/21] dt-bindings: power: mediatek: Update example in dt-bindings Tinghan Shen
2022-07-20 17:38 ` Krzysztof Kozlowski
2022-07-20 12:30 ` [PATCH v3 08/21] arm64: dts: mediatek: Update mt81xx scpsys node to align with dt-bindings Tinghan Shen
2022-07-20 17:39 ` Krzysztof Kozlowski [this message]
2022-07-20 12:30 ` [PATCH v3 09/21] arm64: dts: mt8195: Disable watchdog external reset signal Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 10/21] arm64: dts: mt8195: Disable I2C0 node Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 11/21] arm64: dts: mt8195: Add cpufreq node Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 12/21] arm64: dts: mt8195: Add vdosys and vppsys clock nodes Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 13/21] arm64: dts: mt8195: Add power domains controller Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 14/21] arm64: dts: mt8195: Add spmi node Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 15/21] arm64: dts: mt8195: Add scp node Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 16/21] arm64: dts: mt8195: Add audio related nodes Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 17/21] arm64: dts: mt8195: Add adsp node and adsp mailbox nodes Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 18/21] arm64: dts: mt8195: Specify audio reset controller Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 19/21] arm64: dts: mt8195: Add iommu and smi nodes Tinghan Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=085a003e-576d-b39a-60ce-ca8f53c89d43@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mandyjh.liu@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=tinghan.shen@mediatek.com \
--cc=will@kernel.org \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).