From: Marek Vasut <marex@denx.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Joakim Zhang <qiangqing.zhang@nxp.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, kernel@dh-electronics.com
Subject: Re: [net-next,PATCH] dt-bindings: net: realtek,rtl82xx: Document known PHY IDs as compatible strings
Date: Mon, 24 Jun 2024 01:52:49 +0200 [thread overview]
Message-ID: <085b1167-ed94-4527-af0f-dc7df2f2c354@denx.de> (raw)
In-Reply-To: <cc539292-0b76-46b8-99b3-508b7bc7d94d@lunn.ch>
On 6/23/24 10:00 PM, Andrew Lunn wrote:
>> - $ref: ethernet-phy.yaml#
>>
>> properties:
>> + compatible:
>> + enum:
>> + - ethernet-phy-id0000.8201
>
> I'm not sure that one should be listed. It is not an official ID,
> since it does not have an OUI. In fact, this is one of the rare cases
> where actually listing a compatible in DT makes sense, because you can
> override the broken hardware and give a correct ID in realtek address
> space.
Hmmm, so, shall I drop this ID or keep it ?
I generally put the PHY IDs into DT so the PHY drivers can correctly
handle clock and reset sequencing for those PHYs, before the PHY ID
registers can be read out of the PHY.
next prev parent reply other threads:[~2024-06-24 0:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-23 19:41 [net-next,PATCH] dt-bindings: net: realtek,rtl82xx: Document known PHY IDs as compatible strings Marek Vasut
2024-06-23 20:00 ` Andrew Lunn
2024-06-23 23:52 ` Marek Vasut [this message]
2024-06-24 13:52 ` Andrew Lunn
2024-06-25 0:32 ` Marek Vasut
2024-06-25 13:17 ` Andrew Lunn
2024-06-25 18:44 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=085b1167-ed94-4527-af0f-dc7df2f2c354@denx.de \
--to=marex@denx.de \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@dh-electronics.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qiangqing.zhang@nxp.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).