From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tao Ren Subject: Re: [PATCH] ARM: dts: aspeed: Add Facebook Wedge100 BMC Date: Fri, 2 Aug 2019 03:56:11 +0000 Message-ID: <0862C896-35D3-4032-8DA8-E4B7632CC333@fb.com> References: <20190802010155.489238-1-taoren@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Content-ID: <84D26974C03CED42B63C839A5C734926@namprd15.prod.outlook.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Joel Stanley Cc: Mark Rutland , devicetree , "linux-aspeed@lists.ozlabs.org" , Andrew Jeffery , OpenBMC Maillist , Linux Kernel Mailing List , Rob Herring , Linux ARM List-Id: devicetree@vger.kernel.org On 8/1/19, 8:02 PM, "Joel Stanley" wrote: > On Fri, 2 Aug 2019 at 01:02, Tao Ren wrote: >> + >> + chosen { >> + stdout-path = &uart3; >> + bootargs = "debug console=ttyS2,9600n8 root=/dev/ram rw"; > > Are you sure you want 'debug' in your boot arguments? > > The rest lgtm. I can remove debug when applying, or leave it there if > it was intentional. Ahh, I copied bootargs from "/proc/cmdline" on my machine (running old kernel) but I don't think I need it. Thank you for pointing it out. Let me send out v2 patches in a few minutes (so you could apply without extra changes). Cheers, Tao