From: Kukjin Kim <kgene@kernel.org>
To: 'Leela Krishna Amudala' <l.krishna@samsung.com>,
'Sachin Kamat' <sachin.kamat@linaro.org>
Cc: 'linux-samsung-soc' <linux-samsung-soc@vger.kernel.org>,
devicetree@vger.kernel.org, 'Tomasz Figa' <t.figa@samsung.com>,
abrestic@chromium.org, olofj@chromium.org
Subject: RE: [RESEND] [PATCH] ARM: dts: exynos5: add pwm DT nodes to Exynos5250 and Exynos5420
Date: Tue, 12 Nov 2013 20:39:12 +0900 [thread overview]
Message-ID: <086801cedf9b$cef3c450$6cdb4cf0$@org> (raw)
In-Reply-To: <CAL1wa8e0e1NwrntEPTnm8=_bSXj3k=Gk+jenphYPEAh8tXKwiA@mail.gmail.com>
Leela Krishna Amudala wrote:
>
> Hi Sachin,
>
> On Thu, Oct 10, 2013 at 11:18 AM, Sachin Kamat <sachin.kamat@linaro.org>
> wrote:
> > Hi Leela,
> >
> > On 10 October 2013 11:12, Leela Krishna Amudala <l.krishna@samsung.com>
> wrote:
> >> Add the device-tree binding for the PWM controller to Exynos5250 and
> Exynos5420
> >>
> >> Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
> >> Signed-off-by: Olof Johansson <olofj@chromium.org>
> >> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> >> ---
> >> arch/arm/boot/dts/exynos5250.dtsi | 9 +++++++++
> >> arch/arm/boot/dts/exynos5420.dtsi | 9 +++++++++
> >> 2 files changed, 18 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> >> index 864ae90..99abc72 100644
> >> --- a/arch/arm/boot/dts/exynos5250.dtsi
> >> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> >> @@ -521,6 +521,15 @@
> >> };
> >> };
> >>
> >> + pwm: pwm@12dd0000 {
> >> + compatible = "samsung,exynos4210-pwm";
> >> + reg = <0x12dd0000 0x100>;
> >> + samsung,pwm-outputs = <0>, <1>, <2>, <3>;
> >> + #pwm-cells = <3>;
> >> + clocks = <&clock 311>;
> >> + clock-names = "timers";
> >> + };
> >> +
> >> amba {
> >> #address-cells = <1>;
> >> #size-cells = <1>;
> >> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> b/arch/arm/boot/dts/exynos5420.dtsi
> >> index d537cd7..80afc8b 100644
> >> --- a/arch/arm/boot/dts/exynos5420.dtsi
> >> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> >> @@ -206,6 +206,15 @@
> >> clock-names = "uart", "clk_uart_baud0";
> >> };
> >>
> >> + pwm: pwm@12dd0000 {
> >> + compatible = "samsung,exynos4210-pwm";
> >> + reg = <0x12dd0000 0x100>;
> >> + samsung,pwm-outputs = <0>, <1>, <2>, <3>;
> >> + #pwm-cells = <3>;
> >> + clocks = <&clock 279>;
> >> + clock-names = "timers";
> >> + };
> >> +
> >
> > Looking at the properties in the above 2 nodes, can't we have the
> > common ones defined in exynos5.dtsi?
> >
>
Sorry for late, I missed...
Well, upcoming exynos5 SoC has different properties so would be better if we
could keep current version for pwm.
> Yes, we can do it, will change and post the next version
>
Let me ignore your v2 patch and take this one.
Thanks,
Kukjin
next prev parent reply other threads:[~2013-11-12 11:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 5:42 [RESEND] [PATCH] ARM: dts: exynos5: add pwm DT nodes to Exynos5250 and Exynos5420 Leela Krishna Amudala
2013-10-10 5:48 ` Sachin Kamat
2013-10-10 8:41 ` Leela Krishna Amudala
2013-11-12 11:39 ` Kukjin Kim [this message]
2013-12-12 11:35 ` Leela Krishna Amudala
2013-12-18 17:40 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='086801cedf9b$cef3c450$6cdb4cf0$@org' \
--to=kgene@kernel.org \
--cc=abrestic@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=l.krishna@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olofj@chromium.org \
--cc=sachin.kamat@linaro.org \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).