* [RESEND] [PATCH] ARM: dts: exynos5: add pwm DT nodes to Exynos5250 and Exynos5420
@ 2013-10-10 5:42 Leela Krishna Amudala
2013-10-10 5:48 ` Sachin Kamat
0 siblings, 1 reply; 6+ messages in thread
From: Leela Krishna Amudala @ 2013-10-10 5:42 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: kgene.kim, devicetree, t.figa, abrestic, olofj
Add the device-tree binding for the PWM controller to Exynos5250 and Exynos5420
Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
Signed-off-by: Olof Johansson <olofj@chromium.org>
Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
---
arch/arm/boot/dts/exynos5250.dtsi | 9 +++++++++
arch/arm/boot/dts/exynos5420.dtsi | 9 +++++++++
2 files changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 864ae90..99abc72 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -521,6 +521,15 @@
};
};
+ pwm: pwm@12dd0000 {
+ compatible = "samsung,exynos4210-pwm";
+ reg = <0x12dd0000 0x100>;
+ samsung,pwm-outputs = <0>, <1>, <2>, <3>;
+ #pwm-cells = <3>;
+ clocks = <&clock 311>;
+ clock-names = "timers";
+ };
+
amba {
#address-cells = <1>;
#size-cells = <1>;
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index d537cd7..80afc8b 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -206,6 +206,15 @@
clock-names = "uart", "clk_uart_baud0";
};
+ pwm: pwm@12dd0000 {
+ compatible = "samsung,exynos4210-pwm";
+ reg = <0x12dd0000 0x100>;
+ samsung,pwm-outputs = <0>, <1>, <2>, <3>;
+ #pwm-cells = <3>;
+ clocks = <&clock 279>;
+ clock-names = "timers";
+ };
+
dp_phy: video-phy@10040728 {
compatible = "samsung,exynos5250-dp-video-phy";
reg = <0x10040728 4>;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [RESEND] [PATCH] ARM: dts: exynos5: add pwm DT nodes to Exynos5250 and Exynos5420
2013-10-10 5:42 [RESEND] [PATCH] ARM: dts: exynos5: add pwm DT nodes to Exynos5250 and Exynos5420 Leela Krishna Amudala
@ 2013-10-10 5:48 ` Sachin Kamat
2013-10-10 8:41 ` Leela Krishna Amudala
0 siblings, 1 reply; 6+ messages in thread
From: Sachin Kamat @ 2013-10-10 5:48 UTC (permalink / raw)
To: Leela Krishna Amudala
Cc: linux-samsung-soc, Kukjin Kim, devicetree, Tomasz Figa, abrestic,
olofj
Hi Leela,
On 10 October 2013 11:12, Leela Krishna Amudala <l.krishna@samsung.com> wrote:
> Add the device-tree binding for the PWM controller to Exynos5250 and Exynos5420
>
> Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
> Signed-off-by: Olof Johansson <olofj@chromium.org>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 9 +++++++++
> arch/arm/boot/dts/exynos5420.dtsi | 9 +++++++++
> 2 files changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 864ae90..99abc72 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -521,6 +521,15 @@
> };
> };
>
> + pwm: pwm@12dd0000 {
> + compatible = "samsung,exynos4210-pwm";
> + reg = <0x12dd0000 0x100>;
> + samsung,pwm-outputs = <0>, <1>, <2>, <3>;
> + #pwm-cells = <3>;
> + clocks = <&clock 311>;
> + clock-names = "timers";
> + };
> +
> amba {
> #address-cells = <1>;
> #size-cells = <1>;
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index d537cd7..80afc8b 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -206,6 +206,15 @@
> clock-names = "uart", "clk_uart_baud0";
> };
>
> + pwm: pwm@12dd0000 {
> + compatible = "samsung,exynos4210-pwm";
> + reg = <0x12dd0000 0x100>;
> + samsung,pwm-outputs = <0>, <1>, <2>, <3>;
> + #pwm-cells = <3>;
> + clocks = <&clock 279>;
> + clock-names = "timers";
> + };
> +
Looking at the properties in the above 2 nodes, can't we have the
common ones defined in exynos5.dtsi?
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND] [PATCH] ARM: dts: exynos5: add pwm DT nodes to Exynos5250 and Exynos5420
2013-10-10 5:48 ` Sachin Kamat
@ 2013-10-10 8:41 ` Leela Krishna Amudala
2013-11-12 11:39 ` Kukjin Kim
0 siblings, 1 reply; 6+ messages in thread
From: Leela Krishna Amudala @ 2013-10-10 8:41 UTC (permalink / raw)
To: Sachin Kamat
Cc: Leela Krishna Amudala, linux-samsung-soc, Kukjin Kim, devicetree,
Tomasz Figa, abrestic, olofj
Hi Sachin,
On Thu, Oct 10, 2013 at 11:18 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Hi Leela,
>
> On 10 October 2013 11:12, Leela Krishna Amudala <l.krishna@samsung.com> wrote:
>> Add the device-tree binding for the PWM controller to Exynos5250 and Exynos5420
>>
>> Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
>> Signed-off-by: Olof Johansson <olofj@chromium.org>
>> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos5250.dtsi | 9 +++++++++
>> arch/arm/boot/dts/exynos5420.dtsi | 9 +++++++++
>> 2 files changed, 18 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
>> index 864ae90..99abc72 100644
>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> @@ -521,6 +521,15 @@
>> };
>> };
>>
>> + pwm: pwm@12dd0000 {
>> + compatible = "samsung,exynos4210-pwm";
>> + reg = <0x12dd0000 0x100>;
>> + samsung,pwm-outputs = <0>, <1>, <2>, <3>;
>> + #pwm-cells = <3>;
>> + clocks = <&clock 311>;
>> + clock-names = "timers";
>> + };
>> +
>> amba {
>> #address-cells = <1>;
>> #size-cells = <1>;
>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
>> index d537cd7..80afc8b 100644
>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> @@ -206,6 +206,15 @@
>> clock-names = "uart", "clk_uart_baud0";
>> };
>>
>> + pwm: pwm@12dd0000 {
>> + compatible = "samsung,exynos4210-pwm";
>> + reg = <0x12dd0000 0x100>;
>> + samsung,pwm-outputs = <0>, <1>, <2>, <3>;
>> + #pwm-cells = <3>;
>> + clocks = <&clock 279>;
>> + clock-names = "timers";
>> + };
>> +
>
> Looking at the properties in the above 2 nodes, can't we have the
> common ones defined in exynos5.dtsi?
>
Yes, we can do it, will change and post the next version
> --
> With warm regards,
> Sachin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [RESEND] [PATCH] ARM: dts: exynos5: add pwm DT nodes to Exynos5250 and Exynos5420
2013-10-10 8:41 ` Leela Krishna Amudala
@ 2013-11-12 11:39 ` Kukjin Kim
2013-12-12 11:35 ` Leela Krishna Amudala
0 siblings, 1 reply; 6+ messages in thread
From: Kukjin Kim @ 2013-11-12 11:39 UTC (permalink / raw)
To: 'Leela Krishna Amudala', 'Sachin Kamat'
Cc: 'linux-samsung-soc', devicetree, 'Tomasz Figa',
abrestic, olofj
Leela Krishna Amudala wrote:
>
> Hi Sachin,
>
> On Thu, Oct 10, 2013 at 11:18 AM, Sachin Kamat <sachin.kamat@linaro.org>
> wrote:
> > Hi Leela,
> >
> > On 10 October 2013 11:12, Leela Krishna Amudala <l.krishna@samsung.com>
> wrote:
> >> Add the device-tree binding for the PWM controller to Exynos5250 and
> Exynos5420
> >>
> >> Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
> >> Signed-off-by: Olof Johansson <olofj@chromium.org>
> >> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> >> ---
> >> arch/arm/boot/dts/exynos5250.dtsi | 9 +++++++++
> >> arch/arm/boot/dts/exynos5420.dtsi | 9 +++++++++
> >> 2 files changed, 18 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> >> index 864ae90..99abc72 100644
> >> --- a/arch/arm/boot/dts/exynos5250.dtsi
> >> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> >> @@ -521,6 +521,15 @@
> >> };
> >> };
> >>
> >> + pwm: pwm@12dd0000 {
> >> + compatible = "samsung,exynos4210-pwm";
> >> + reg = <0x12dd0000 0x100>;
> >> + samsung,pwm-outputs = <0>, <1>, <2>, <3>;
> >> + #pwm-cells = <3>;
> >> + clocks = <&clock 311>;
> >> + clock-names = "timers";
> >> + };
> >> +
> >> amba {
> >> #address-cells = <1>;
> >> #size-cells = <1>;
> >> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> b/arch/arm/boot/dts/exynos5420.dtsi
> >> index d537cd7..80afc8b 100644
> >> --- a/arch/arm/boot/dts/exynos5420.dtsi
> >> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> >> @@ -206,6 +206,15 @@
> >> clock-names = "uart", "clk_uart_baud0";
> >> };
> >>
> >> + pwm: pwm@12dd0000 {
> >> + compatible = "samsung,exynos4210-pwm";
> >> + reg = <0x12dd0000 0x100>;
> >> + samsung,pwm-outputs = <0>, <1>, <2>, <3>;
> >> + #pwm-cells = <3>;
> >> + clocks = <&clock 279>;
> >> + clock-names = "timers";
> >> + };
> >> +
> >
> > Looking at the properties in the above 2 nodes, can't we have the
> > common ones defined in exynos5.dtsi?
> >
>
Sorry for late, I missed...
Well, upcoming exynos5 SoC has different properties so would be better if we
could keep current version for pwm.
> Yes, we can do it, will change and post the next version
>
Let me ignore your v2 patch and take this one.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND] [PATCH] ARM: dts: exynos5: add pwm DT nodes to Exynos5250 and Exynos5420
2013-11-12 11:39 ` Kukjin Kim
@ 2013-12-12 11:35 ` Leela Krishna Amudala
2013-12-18 17:40 ` Kukjin Kim
0 siblings, 1 reply; 6+ messages in thread
From: Leela Krishna Amudala @ 2013-12-12 11:35 UTC (permalink / raw)
To: Kukjin Kim, Kukjin Kim
Cc: Leela Krishna Amudala, Sachin Kamat, linux-samsung-soc,
devicetree@vger.kernel.org, Tomasz Figa, abrestic, olofj
Hi Kukjin,
Even though you said it is applied, I didn't see this patch in any of
your trees.
Can you kindly look into this patch and take necessary action..?
Best Wishes,
Leela Krishna.
On Tue, Nov 12, 2013 at 8:39 PM, Kukjin Kim <kgene@kernel.org> wrote:
> Leela Krishna Amudala wrote:
>>
>> Hi Sachin,
>>
>> On Thu, Oct 10, 2013 at 11:18 AM, Sachin Kamat <sachin.kamat@linaro.org>
>> wrote:
>> > Hi Leela,
>> >
>> > On 10 October 2013 11:12, Leela Krishna Amudala <l.krishna@samsung.com>
>> wrote:
>> >> Add the device-tree binding for the PWM controller to Exynos5250 and
>> Exynos5420
>> >>
>> >> Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
>> >> Signed-off-by: Olof Johansson <olofj@chromium.org>
>> >> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
>> >> ---
>> >> arch/arm/boot/dts/exynos5250.dtsi | 9 +++++++++
>> >> arch/arm/boot/dts/exynos5420.dtsi | 9 +++++++++
>> >> 2 files changed, 18 insertions(+)
>> >>
>> >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
>> b/arch/arm/boot/dts/exynos5250.dtsi
>> >> index 864ae90..99abc72 100644
>> >> --- a/arch/arm/boot/dts/exynos5250.dtsi
>> >> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> >> @@ -521,6 +521,15 @@
>> >> };
>> >> };
>> >>
>> >> + pwm: pwm@12dd0000 {
>> >> + compatible = "samsung,exynos4210-pwm";
>> >> + reg = <0x12dd0000 0x100>;
>> >> + samsung,pwm-outputs = <0>, <1>, <2>, <3>;
>> >> + #pwm-cells = <3>;
>> >> + clocks = <&clock 311>;
>> >> + clock-names = "timers";
>> >> + };
>> >> +
>> >> amba {
>> >> #address-cells = <1>;
>> >> #size-cells = <1>;
>> >> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
>> b/arch/arm/boot/dts/exynos5420.dtsi
>> >> index d537cd7..80afc8b 100644
>> >> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> >> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> >> @@ -206,6 +206,15 @@
>> >> clock-names = "uart", "clk_uart_baud0";
>> >> };
>> >>
>> >> + pwm: pwm@12dd0000 {
>> >> + compatible = "samsung,exynos4210-pwm";
>> >> + reg = <0x12dd0000 0x100>;
>> >> + samsung,pwm-outputs = <0>, <1>, <2>, <3>;
>> >> + #pwm-cells = <3>;
>> >> + clocks = <&clock 279>;
>> >> + clock-names = "timers";
>> >> + };
>> >> +
>> >
>> > Looking at the properties in the above 2 nodes, can't we have the
>> > common ones defined in exynos5.dtsi?
>> >
>>
> Sorry for late, I missed...
>
> Well, upcoming exynos5 SoC has different properties so would be better if we
> could keep current version for pwm.
>
>> Yes, we can do it, will change and post the next version
>>
> Let me ignore your v2 patch and take this one.
>
> Thanks,
> Kukjin
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND] [PATCH] ARM: dts: exynos5: add pwm DT nodes to Exynos5250 and Exynos5420
2013-12-12 11:35 ` Leela Krishna Amudala
@ 2013-12-18 17:40 ` Kukjin Kim
0 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2013-12-18 17:40 UTC (permalink / raw)
To: Leela Krishna Amudala
Cc: Kukjin Kim, Kukjin Kim, Sachin Kamat, linux-samsung-soc,
devicetree@vger.kernel.org, Tomasz Figa, abrestic, olofj
On 12/12/13 20:35, Leela Krishna Amudala wrote:
> Hi Kukjin,
>
> Even though you said it is applied, I didn't see this patch in any of
> your trees.
> Can you kindly look into this patch and take necessary action..?
>
Applied, thanks.
Kukjin
> Best Wishes,
> Leela Krishna.
>
> On Tue, Nov 12, 2013 at 8:39 PM, Kukjin Kim<kgene@kernel.org> wrote:
>> Leela Krishna Amudala wrote:
>>>
>>> Hi Sachin,
>>>
>>> On Thu, Oct 10, 2013 at 11:18 AM, Sachin Kamat<sachin.kamat@linaro.org>
>>> wrote:
>>>> Hi Leela,
>>>>
>>>> On 10 October 2013 11:12, Leela Krishna Amudala<l.krishna@samsung.com>
>>> wrote:
>>>>> Add the device-tree binding for the PWM controller to Exynos5250 and
>>> Exynos5420
>>>>>
>>>>> Signed-off-by: Andrew Bresticker<abrestic@chromium.org>
>>>>> Signed-off-by: Olof Johansson<olofj@chromium.org>
>>>>> Signed-off-by: Leela Krishna Amudala<l.krishna@samsung.com>
>>>>> ---
>>>>> arch/arm/boot/dts/exynos5250.dtsi | 9 +++++++++
>>>>> arch/arm/boot/dts/exynos5420.dtsi | 9 +++++++++
>>>>> 2 files changed, 18 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
>>> b/arch/arm/boot/dts/exynos5250.dtsi
>>>>> index 864ae90..99abc72 100644
>>>>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>>>>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>>>>> @@ -521,6 +521,15 @@
>>>>> };
>>>>> };
>>>>>
>>>>> + pwm: pwm@12dd0000 {
>>>>> + compatible = "samsung,exynos4210-pwm";
>>>>> + reg =<0x12dd0000 0x100>;
>>>>> + samsung,pwm-outputs =<0>,<1>,<2>,<3>;
>>>>> + #pwm-cells =<3>;
>>>>> + clocks =<&clock 311>;
>>>>> + clock-names = "timers";
>>>>> + };
>>>>> +
>>>>> amba {
>>>>> #address-cells =<1>;
>>>>> #size-cells =<1>;
>>>>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
>>> b/arch/arm/boot/dts/exynos5420.dtsi
>>>>> index d537cd7..80afc8b 100644
>>>>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>>>>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>>>>> @@ -206,6 +206,15 @@
>>>>> clock-names = "uart", "clk_uart_baud0";
>>>>> };
>>>>>
>>>>> + pwm: pwm@12dd0000 {
>>>>> + compatible = "samsung,exynos4210-pwm";
>>>>> + reg =<0x12dd0000 0x100>;
>>>>> + samsung,pwm-outputs =<0>,<1>,<2>,<3>;
>>>>> + #pwm-cells =<3>;
>>>>> + clocks =<&clock 279>;
>>>>> + clock-names = "timers";
>>>>> + };
>>>>> +
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-12-18 17:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-10 5:42 [RESEND] [PATCH] ARM: dts: exynos5: add pwm DT nodes to Exynos5250 and Exynos5420 Leela Krishna Amudala
2013-10-10 5:48 ` Sachin Kamat
2013-10-10 8:41 ` Leela Krishna Amudala
2013-11-12 11:39 ` Kukjin Kim
2013-12-12 11:35 ` Leela Krishna Amudala
2013-12-18 17:40 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).