From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB64C3A3819; Mon, 30 Mar 2026 14:12:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774879923; cv=none; b=s1Wt+K/SOrhv+YU+cgrZkDPSZxDZbO4qxm4kj7ublZuaj/jWLvU5jvs9i1wRCCk8DjqJpgstX62OPd16JpmKpEVj9B6upiZ23x+PNHSxcxgFZnLdcRPnlZNZxTCFDt8/1Ki/t+qyy85kJcbrQhptralkZCtYTOo/q9/BB00jV3w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774879923; c=relaxed/simple; bh=fv7u2PJPLBHp3kxSG+S/aLopXh7onyeyM+OxnvrlMPo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SAIn9KbyqUGAbWqD1j1odX0EX3GM4e8I08u7FFmRulOqQBTUXjWIY0kGJqP9gqGxzyvTSRMbd8Qy0JFDV0Yjf0TjxxrmwD492vPer0lttusLVbxd0YxzwS+OS5YsCy7ZbNU5bkja6iVSmVKQk53yqEdlRfpFhAto3N9pNiTjOzU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aZRjqt/C; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aZRjqt/C" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C685C4CEF7; Mon, 30 Mar 2026 14:12:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774879923; bh=fv7u2PJPLBHp3kxSG+S/aLopXh7onyeyM+OxnvrlMPo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=aZRjqt/Ch214ay3BxdslOxCzad2Y3vxAEBkiPeN9TZr0EIqjzx/EE5y+1FP1Q0oO+ Sb0c7B8hx7foRfu/lehZyeKH2mCbuUkW4v3eblWtCMYX2p3OZQ4ddr229wzNjXjkBT ZSLn18qhOtBDu5l8TKV9I9dGFI1udtbtVkBqIm3eK4lBlGxVcXSAHO3y74UbFmAynl dYm9FY33TV2EA1sKJSYepXEIkY7hp308LHDu9q0T/Lcv9yevzIM+OTb8tlBc1mxMpR B351kRNLzgSGIdzTSeoB5v//cAW1ACxrpN2s1il3cQVbigmfg0PyJkEhs5DZcg6HF2 autR+TW3FV0LQ== Message-ID: <0879e4c1-5381-4a70-9fb3-4af9b3bf6e48@kernel.org> Date: Mon, 30 Mar 2026 15:11:58 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 2/3] media: qcom: camss: Add CAMSS Offline Processing Engine driver To: johannes.goede@oss.qualcomm.com, Dmitry Baryshkov Cc: Loic Poulain , vladimir.zapolskiy@linaro.org, laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com, robh@kernel.org, krzk+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, mchehab@kernel.org References: <20260323125824.211615-1-loic.poulain@oss.qualcomm.com> <20260323125824.211615-3-loic.poulain@oss.qualcomm.com> <1ba54ec0-be51-4694-a79b-f272e76303d2@kernel.org> <12194cc0-0960-486c-be7e-1a22d95de340@kernel.org> <7fc31426-3157-49c7-a30d-dcd7b181fcc6@oss.qualcomm.com> <8DTHyPLaUjGKd83PvBsisjn_SnpUnvkateTtwz9P6CChP9VGfDyQmJa4Rfd5KwOBOLhtGFJPDzfHrXC4zvV-Fg==@protonmail.internalid> <0330f63f-7137-4484-954a-fc0776a9b052@oss.qualcomm.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <0330f63f-7137-4484-954a-fc0776a9b052@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30/03/2026 14:46, johannes.goede@oss.qualcomm.com wrote: >>> And then your CCMv1 or CCMv2 helper will get called with >>> the matching parameter-data. >> This leads to userspace having to know exact format for each hardware >> version, which is not nice. At the very least it should be possible to >> accept CCMv1 buffers and covert them to CCMv2 when required. > Yes, but a new ISP may also have a different pipeline altogether > with e.g. more then one preview/viewfinder output vs one viewfinder > output for current hw, etc. My scoping on HFI shows that the IQ structures between Kona and later versions have pretty stable data-structures. It might be worthwhile for the non-HFI version to implement those structures. I keep mentioning CDM. Its also possible to construct the buffer in the format the CDM would require and hand that from user-space into the kernel. That would save alot of overhead translating from one format to another. That's another reason I bring up CDM again and again. We probably don't want to fix to the wrong format for OPE, introduce the CDM and then find we have to map from one format to another for large and complex data over and over again for each frame or every N frames. TBH I think the CDM should happen for this system and in that vein is there any reason not to pack the data in the order the CDM will want ? So probably in fact IQ structs are not the right thing for OPE+IFE. --- bod