Re: [PATCH v6] dt-bindings: imx-pata: Convert to dtschema

[Damien Le Moal <dlemoal@kernel.org>]

On 3/11/24 12:33, Animesh Agarwal wrote:
> On Mon, Mar 11, 2024 at 2:03 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>> BTW, If this was not clear, I am quite fed up with these patches, so
>> keep the rule of one version per day. You made quite a lot of changes
>> which were not necessary and I have impression that you should just
>> double check your code *before* sending next version.
> This was my first attempt at a contribution to the linux kernel. I
> have learned a lot, I feel like I have wasted a ton of your time.
> I always try to not make any mistakes before posting but it was
> clearly not a good try.
> Moving forward I'll be a lot more cautious and write better code and
> add proper explanation for the changes I made.

It is simple: the commit message should always explain *WHAT* you did and
*WHY*. This is to give some context to reviewers and to help with checking that
your code actually does what you explained. This also helps with potential
future issues with a change as the commit message remains in the git log history.

Regardless of the version of your patch, always have the what & why explained
in your commit message. This implies that the commit message must change if the
patch content changes between versions. Keep in mind that the changelog added
to a patch is lost when the patch is applied, but the commit message remains.

> 
> Thanks & Regards
> Animesh

-- 
Damien Le Moal
Western Digital Research