devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] arm64: dts: marvell: armada-37xx: Add default PCI interrup controller address cells
@ 2025-08-22 13:33 Krzysztof Kozlowski
  2025-08-22 13:33 ` [PATCH 2/2] arm64: dts: marvell: armada-cp11x: Add default ICU " Krzysztof Kozlowski
  2025-08-22 21:27 ` [PATCH 1/2] arm64: dts: marvell: armada-37xx: Add default PCI interrup controller " Rob Herring (Arm)
  0 siblings, 2 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-22 13:33 UTC (permalink / raw)
  To: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, devicetree,
	linux-kernel
  Cc: Krzysztof Kozlowski

Add missing address-cells 0 to the PCI interrupt node to silence W=1
warning:

  armada-37xx.dtsi:518.4-521.29: Warning (interrupt_map): /soc/pcie@d0070000:interrupt-map:
    Missing property '#address-cells' in node /soc/pcie@d0070000/interrupt-controller, using 0 as fallback

Value '0' is correct because:
1. GIC interrupt controller does not have children,
2. interrupt-map property (in PCI node) consists of five components and
   the fourth component "parent unit address", which size is defined by
   '#address-cells' of the node pointed to by the interrupt-parent
   component, is not used (=0)

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
index 75b0fdc3efb2..c612317043ea 100644
--- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
@@ -524,6 +524,7 @@ pcie0: pcie@d0070000 {
 			pcie_intc: interrupt-controller {
 				interrupt-controller;
 				#interrupt-cells = <1>;
+				#address-cells = <0>;
 			};
 		};
 	};
-- 
2.48.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-08-23 16:35 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-22 13:33 [PATCH 1/2] arm64: dts: marvell: armada-37xx: Add default PCI interrup controller address cells Krzysztof Kozlowski
2025-08-22 13:33 ` [PATCH 2/2] arm64: dts: marvell: armada-cp11x: Add default ICU " Krzysztof Kozlowski
2025-08-23  8:47   ` Krzysztof Kozlowski
2025-08-22 21:27 ` [PATCH 1/2] arm64: dts: marvell: armada-37xx: Add default PCI interrup controller " Rob Herring (Arm)
2025-08-23  8:54   ` Krzysztof Kozlowski
2025-08-23 16:35     ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).