From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1EA021CC4B; Fri, 10 Oct 2025 02:37:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760063841; cv=none; b=s3vIfN+2ZlkSagPxDfsxCoAS2ahtsDCJytOASzhLyGEYjasfoUUU3RA1Ldo9T6awFnbRohOVJ+tckpv7BMBwwzaS6ywUrEDoHET+dO9px7p8x84YYehjSNFLc0N57VjuebJ3pmnEcDfXqEgmdOeDcCGb/4ouE0/A+MTuSDrY0X8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760063841; c=relaxed/simple; bh=lwU66AJfEbvhUiM0tXc7O29qiW1GKY8GCIbXRnYqYcA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=h7CTCDg/mffSEjI1ZI3DdTfN58rMeWgvB+z00WByLHxNz7HDY5L2ImOJjepzkVx8PgSlp2XyWYlea+A4NlNvzD0/d8MNODQ4vOWajhYuIxKaoR5A81f7iwC5oPmpJKLy3IQ3Ctn85r6VP5IX9SnJ7kVkXFTN/92eNIRVZANku5I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jjzQee5f; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jjzQee5f" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D247BC4CEE7; Fri, 10 Oct 2025 02:37:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760063841; bh=lwU66AJfEbvhUiM0tXc7O29qiW1GKY8GCIbXRnYqYcA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jjzQee5fd+TTjh2I3b9VYeSdkRHtmfRhxTagPkNiZQT26G1MZyeegDtZ0WZtC+VOh AxOl6LiY/207erzxpoZqqO6C+EL2k2EuZB+NTyMJc1j22qZnC3MehUBFbY42fuow0q vN0X9zgHl6j3FKBmAMKQ7r2zo/tmE3Y+EutfwGcLS4GB79EVOqnM+MkVUTDbighMz2 yBzys/B7/lM+iFkwdCtt6NmsvuSdqSibC9b3zITd2KYZHJLtCGMJNRo91qIWvEq4Ik 7vxWLMZ9WPTww8/DlDgVdppQBXbv/RMSRDhFWFqzZK7rUL0ZF6J9rz0kG4m/wnBc5B mPc46L1SLuZDQ== Message-ID: <08b7a21a-72f7-47e4-9dc9-37a7316f94d5@kernel.org> Date: Fri, 10 Oct 2025 04:37:14 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dt-bindings: mfd: Add Renesas R2A11302FT PMIC To: Wolfram Sang , linux-renesas-soc@vger.kernel.org Cc: Geert Uytterhoeven , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Magnus Damm , devicetree@vger.kernel.org References: <20251009181916.2431-2-wsa+renesas@sang-engineering.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20251009181916.2431-2-wsa+renesas@sang-engineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 09/10/2025 20:12, Wolfram Sang wrote: > This PMIC is referenced in upstream DTs for the Renesas Lager and > Koelsch boards. Sadly, we don't have documentation for more complete > bindings, but due to the spi-cpol/cpha it also doesn't belong to trivial That's not a problem. > devices. So, start with this minimal binding description with the facts > that we do know: > > Fixes: > arch/arm/boot/dts/renesas/r8a7790-lager.dtb: /soc/spi@e6e10000/pmic@0: failed to match any schema with compatible: ['renesas,r2a11302ft'] > arch/arm/boot/dts/renesas/r8a7791-koelsch.dtb: /soc/spi@e6e20000/pmic@0: failed to match any schema with compatible: ['renesas,r2a11302ft'] > > Reviewed-by: Geert Uytterhoeven > Signed-off-by: Wolfram Sang > --- > > Change since RFC [1]: Please start using b4. This is v2. Your wrong numbering makes any comparisons broken. Try yourself with b4. > * dropped "unevaluatedProperties" because we know this binding is not > complete currently You cannot. Bindings must be complete (or complete "enough"), otherwise I see no point in accepting them. It is like you sent driver code which does not build because you did not write half of it. Why would we want it? > * removed 'pmic' label from the example > * proper patch description > > [1] https://lore.kernel.org/r/20250929083449.14393-1-wsa+renesas@sang-engineering.com > > .../bindings/mfd/renesas,r2a11302ft.yaml | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/renesas,r2a11302ft.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/renesas,r2a11302ft.yaml b/Documentation/devicetree/bindings/mfd/renesas,r2a11302ft.yaml > new file mode 100644 > index 000000000000..e978b359b3ec > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/renesas,r2a11302ft.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/renesas,r2a11302ft.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas R2A11302FT Power Supply ICs for R-Car > + > +maintainers: > + - Wolfram Sang > + > +properties: > + compatible: > + const: renesas,r2a11302ft > + > + reg: > + maxItems: 1 > + > + spi-max-frequency: > + maximum: 6000000 > + > + spi-cpol: true > + > + spi-cpha: true > + > +required: > + - compatible > + - reg > + - spi-cpol > + - spi-cpha > + > +allOf: > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + Missing unevaluatedProps. See writing schema (and any of my talks). > +examples: > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + pmic@0 { > + compatible = "renesas,r2a11302ft"; Messed indentation. Best regards, Krzysztof