devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Cheng Jiang <quic_chejiang@quicinc.com>,
	Marcel Holtmann <marcel@holtmann.org>,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Balakrishna Godavarthi <quic_bgodavar@quicinc.com>,
	Rocky Liao <quic_rjliao@quicinc.com>
Cc: linux-bluetooth@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	quic_bt@quicinc.com
Subject: Re: [PATCH v1 1/3] arm64: dts: qcom: sa8775p-ride: Change the BT node
Date: Thu, 28 Nov 2024 15:39:20 +0100	[thread overview]
Message-ID: <08c19ae1-b781-475a-8059-18bf9b708dfd@kernel.org> (raw)
In-Reply-To: <20241128120922.3518582-2-quic_chejiang@quicinc.com>

On 28/11/2024 13:09, Cheng Jiang wrote:
> The SA8775P-Ride uses the QCA6698 chipset, which shares the same IP core
> as the WCN6855. However, it has different RF components and RAM sizes,
> so new firmware is needed.  This change allows driver to distinguish it
> from the WCN6855 and load the specific firmware.
> 
> Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
> index 3fc62e123..f95e709bd 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
> @@ -856,7 +856,7 @@ &uart17 {
>  	status = "okay";
>  
>  	bluetooth {
> -		compatible = "qcom,wcn6855-bt";
> +		compatible = "qcom,qca6698-bt";

This breaks users without mentioning it, without really justifying the
impact. Also it is not clear for me whether devices are or are not
compatible.

Best regards,
Krzysztof

  reply	other threads:[~2024-11-28 14:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-28 12:09 [PATCH v1 0/3] bluetooth: qca: Add QCA6698 Bluetooth chip Cheng Jiang
2024-11-28 12:09 ` [PATCH v1 1/3] arm64: dts: qcom: sa8775p-ride: Change the BT node Cheng Jiang
2024-11-28 14:39   ` Krzysztof Kozlowski [this message]
2024-11-29  2:47     ` Cheng Jiang (IOE)
2024-11-28 12:09 ` [PATCH v1 2/3] dt-bindings: net: Add QCA6698 Bluetooth Cheng Jiang
2024-11-28 12:58   ` Dmitry Baryshkov
2024-11-29  2:30     ` Cheng Jiang (IOE)
2024-11-29 17:13       ` Dmitry Baryshkov
2024-11-30  3:16         ` Cheng Jiang (IOE)
2024-11-28 14:41   ` Krzysztof Kozlowski
2024-11-28 14:41     ` Krzysztof Kozlowski
2024-11-29  2:13       ` Cheng Jiang (IOE)
2024-11-29  6:56         ` Krzysztof Kozlowski
2024-11-29  2:15     ` Cheng Jiang (IOE)
2024-11-28 12:09 ` [PATCH v1 3/3] Bluetooth: btqca: Add QCA6698 support Cheng Jiang
2024-11-28 13:02   ` Dmitry Baryshkov
2024-11-29  2:05     ` Cheng Jiang (IOE)
2024-11-29 17:18       ` Dmitry Baryshkov
2024-11-29  1:13   ` kernel test robot
2024-11-29  3:38   ` kernel test robot
2024-11-28 12:57 ` [PATCH v1 0/3] bluetooth: qca: Add QCA6698 Bluetooth chip Dmitry Baryshkov
2024-11-29  1:20   ` Cheng Jiang (IOE)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08c19ae1-b781-475a-8059-18bf9b708dfd@kernel.org \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=quic_bgodavar@quicinc.com \
    --cc=quic_bt@quicinc.com \
    --cc=quic_chejiang@quicinc.com \
    --cc=quic_rjliao@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).