devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com>,
	James Cowgill <james.cowgill@blaize.com>,
	Matt Redfearn <matthew.redfearn@blaize.com>,
	Neil Jones <neil.jones@blaize.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] arm64/dts/blaize: Enable Ethernet support for BLZP1600
Date: Fri, 11 Jul 2025 15:50:12 +0200	[thread overview]
Message-ID: <08cea1aa-ffc0-422d-8236-91f0f940ae56@kernel.org> (raw)
In-Reply-To: <20250711-kernel-upstreaming-add_network_support-v1-1-4a66a17c94b3@blaize.com>

On 11/07/2025 15:36, Nikolaos Pasaloukos wrote:
> Enable the Synopsys gigabit Ethernet controller which is available
> on the Blaize BLZP1600 SoC.
> 
> Due to the SoC IP block configuration, the max frame size cannot
> exceed the 2030 bytes.
> 
> Signed-off-by: Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com>
> ---
>  arch/arm64/boot/dts/blaize/blaize-blzp1600.dtsi | 22 ++++++++++++++++++++++

Subject prefix: that's not standard. arm64: dts: blaize:


See git log.

>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/blaize/blaize-blzp1600.dtsi b/arch/arm64/boot/dts/blaize/blaize-blzp1600.dtsi
> index 5a6c882b2f57d57d304869dee877c996cbabb712..890f678ddbc43f84cb3cc16c9d2af6edb6350ecc 100644
> --- a/arch/arm64/boot/dts/blaize/blaize-blzp1600.dtsi
> +++ b/arch/arm64/boot/dts/blaize/blaize-blzp1600.dtsi
> @@ -213,5 +213,27 @@ arm_cc712: crypto@550000 {
>  			interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;
>  			clocks = <&scmi_clk 7>;
>  		};
> +
> +		gmac: ethernet@640000 {
> +			compatible = "snps,dwmac";

You need specific compatibles for your soc most likely.

This should be really disallowed alone, but every vendor keeps copying
and doing the same :/


Best regards,
Krzysztof

  reply	other threads:[~2025-07-11 13:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-11 13:36 [PATCH 0/2] arm64/blaize: Enable Ethernet to SoC & CB2 Nikolaos Pasaloukos
2025-07-11 13:36 ` [PATCH 1/2] arm64/dts/blaize: Enable Ethernet support for BLZP1600 Nikolaos Pasaloukos
2025-07-11 13:50   ` Krzysztof Kozlowski [this message]
2025-07-11 13:36 ` [PATCH 2/2] arm64/dts/blaize: Enable Ethernet on CB2 board Nikolaos Pasaloukos
2025-07-11 13:51   ` Krzysztof Kozlowski
2025-07-11 14:02     ` Nikolaos Pasaloukos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08cea1aa-ffc0-422d-8236-91f0f940ae56@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=james.cowgill@blaize.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.redfearn@blaize.com \
    --cc=neil.jones@blaize.com \
    --cc=nikolaos.pasaloukos@blaize.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).