devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Arseniy Krasnov <avkrasnov@sberdevices.ru>,
	Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Liang Yang <liang.yang@amlogic.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	oxffffaa@gmail.com, kernel@sberdevices.ru,
	linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] dt-bindings: nand: meson: Fix 'nand-rb' property
Date: Wed, 7 Jun 2023 10:53:59 +0200	[thread overview]
Message-ID: <08da4e86-433a-7d2e-25ff-ffa24221abdf@linaro.org> (raw)
In-Reply-To: <166bdc27-f77c-9076-f866-180cfa5bff76@sberdevices.ru>

On 07/06/2023 10:40, Arseniy Krasnov wrote:
> Hello Miquel, 
> 
> On 07.06.2023 10:58, Miquel Raynal wrote:
> 
>> Hi Arseniy,
>>
>> AVKrasnov@sberdevices.ru wrote on Tue, 6 Jun 2023 22:35:07 +0300:
>>
>>> Add description of 'nand-rb' property. Use "Fixes" because this property
>>> must be supported since the beginning. For this controller 'nand-rb' is
>>> stored in the controller node (not in chip), because it has only single
>>> r/b wire for all chips.
>>
>> Sorry if I mislead you in the first place, but you could definitely
>> have two chips and only one with RB wired. It needs to be defined in
>> the chips.
> 
> Ok, so to clarify: is it ok, that in bindings this property will be placed in the
> chip, but in driver, i'm trying to read it from the controller node (thus  in
> dts file it will be also in controller node)?

No, because how would your DTS pass validation? I understand you did not
test the bindings, but this will improve, right?

> Because in driver there is no sense
> to store this value in chip structure. 

Driver does not shape the DTS. Hardware does.



Best regards,
Krzysztof


  reply	other threads:[~2023-06-07  8:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-06 19:35 [PATCH v1] dt-bindings: nand: meson: Fix 'nand-rb' property Arseniy Krasnov
2023-06-06 20:12 ` Rob Herring
2023-06-07  7:58 ` Miquel Raynal
2023-06-07  8:40   ` Arseniy Krasnov
2023-06-07  8:53     ` Krzysztof Kozlowski [this message]
2023-06-07  8:57       ` Arseniy Krasnov
2023-06-07  9:08         ` Krzysztof Kozlowski
2023-06-07  9:04           ` Arseniy Krasnov
2023-06-07  9:36             ` Miquel Raynal
2023-06-07 14:52               ` Arseniy Krasnov
2023-06-07 14:58                 ` Krzysztof Kozlowski
2023-06-07 14:55                   ` Arseniy Krasnov
2023-06-07 15:07                     ` Krzysztof Kozlowski
2023-06-07 15:21                       ` Arseniy Krasnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08da4e86-433a-7d2e-25ff-ffa24221abdf@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=avkrasnov@sberdevices.ru \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=kernel@sberdevices.ru \
    --cc=khilman@baylibre.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=liang.yang@amlogic.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=neil.armstrong@linaro.org \
    --cc=oxffffaa@gmail.com \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).