From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23852C83005 for ; Wed, 7 Jun 2023 08:55:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236086AbjFGIzd (ORCPT ); Wed, 7 Jun 2023 04:55:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239617AbjFGIyw (ORCPT ); Wed, 7 Jun 2023 04:54:52 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F4131FE6 for ; Wed, 7 Jun 2023 01:54:04 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-974f4897d87so833610466b.0 for ; Wed, 07 Jun 2023 01:54:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686128042; x=1688720042; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=X96dpBw8S4IY6Gzd4KpRfg7hYofA6lqYbeQBswygWX8=; b=Rub0Qx/sbOrUtTriSDzOsFqIWDAXZSm2DLB0RlGmTUNapdv6VM5lxilTBurtQiorNa vxKd47kcNmBomEu4Y57Jxuik9LkohylcEJjsxRXyAbQpbf9OzeICl3cUQrQzGN267+71 dxZ5xN4030LlJtPIm8pI3kQtk5z+ABjbfOjfGRL11DR+jHpe8Nq6/BujsirGk0Rf7ksq t6MNLB8Z1pl9AWNn1W+G8AEnX3DLhSWhvEgYC41ccVEaC96qm2RUQ1AknQYkEyNgtVNy F1srZXKIbcXJJURehv9/tC6y0dciIv7xVeBVhdQE147nCZ1Pl76eEFyhRzEHkyv+PO6e 8zuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686128042; x=1688720042; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=X96dpBw8S4IY6Gzd4KpRfg7hYofA6lqYbeQBswygWX8=; b=X/JP8wedTjFGe3pbuACk9N0Z6zf5+uk0O2QDJNp94FZyRxJ8QXGNA5VtSqNzmDXAh7 j87+MXCdY0RBFEmt/EedEX4tvBoIHNgR+OZiyQvn3qUCU77AUgHMiIRZOvkIKT7mJ6L+ llY/SJUOFlQ/bc5DA9TbkKPdyYfWFrsqjAkmx3I/TdnW8tuUxU8UGQjAH1QUArmtZ0aN wnyfN9zr1GLgWtdyXZYUdqaMrYJn4++aDge+t6Hb4kiBSDk4l8xUYMt/2CySz3LLNsYo NwJT1xw3D2lWz73GK955XHU/k4xyWkO9i+7qIW5SkgSy8RXd5GyJyYiFvrggKOZrt+ob Dg2w== X-Gm-Message-State: AC+VfDyMOe6Tq38BPONmvwWA66XenOEF87QMc5DT7jxX/WQnyp++V6mb MaKstRIVuyZr/VOSZKhxqUhJ4w== X-Google-Smtp-Source: ACHHUZ7yX1CFlPtzj5ye82i6EMSyNPrLJX5q2v+anBRmgx/s3kNd1PeNOoPKK0AdUrHHxO7MOx8/ZA== X-Received: by 2002:a17:907:3da9:b0:973:f321:36a6 with SMTP id he41-20020a1709073da900b00973f32136a6mr4765561ejc.31.1686128042291; Wed, 07 Jun 2023 01:54:02 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id i5-20020a170906850500b0097886843f75sm328645ejx.177.2023.06.07.01.54.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jun 2023 01:54:01 -0700 (PDT) Message-ID: <08da4e86-433a-7d2e-25ff-ffa24221abdf@linaro.org> Date: Wed, 7 Jun 2023 10:53:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v1] dt-bindings: nand: meson: Fix 'nand-rb' property Content-Language: en-US To: Arseniy Krasnov , Miquel Raynal Cc: Liang Yang , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , oxffffaa@gmail.com, kernel@sberdevices.ru, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230606193507.35024-1-AVKrasnov@sberdevices.ru> <20230607095802.3adcd4f9@xps-13> <166bdc27-f77c-9076-f866-180cfa5bff76@sberdevices.ru> From: Krzysztof Kozlowski In-Reply-To: <166bdc27-f77c-9076-f866-180cfa5bff76@sberdevices.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/06/2023 10:40, Arseniy Krasnov wrote: > Hello Miquel, > > On 07.06.2023 10:58, Miquel Raynal wrote: > >> Hi Arseniy, >> >> AVKrasnov@sberdevices.ru wrote on Tue, 6 Jun 2023 22:35:07 +0300: >> >>> Add description of 'nand-rb' property. Use "Fixes" because this property >>> must be supported since the beginning. For this controller 'nand-rb' is >>> stored in the controller node (not in chip), because it has only single >>> r/b wire for all chips. >> >> Sorry if I mislead you in the first place, but you could definitely >> have two chips and only one with RB wired. It needs to be defined in >> the chips. > > Ok, so to clarify: is it ok, that in bindings this property will be placed in the > chip, but in driver, i'm trying to read it from the controller node (thus in > dts file it will be also in controller node)? No, because how would your DTS pass validation? I understand you did not test the bindings, but this will improve, right? > Because in driver there is no sense > to store this value in chip structure. Driver does not shape the DTS. Hardware does. Best regards, Krzysztof