From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>
Cc: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, vkoul@kernel.org, kishon@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, gregkh@linuxfoundation.org,
catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de,
arnd@arndb.de, geert+renesas@glider.be,
neil.armstrong@linaro.org, nfraprado@collabora.com,
broonie@kernel.org, rafal@milecki.pl, quic_srichara@quicinc.com,
quic_varada@quicinc.org, quic_wcheng@quicinc.com,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 4/6] arm64: dts: qcom: ipq5332: Add USB related nodes
Date: Wed, 12 Jul 2023 14:02:51 +0200 [thread overview]
Message-ID: <08da796b-f1a9-19dc-cde6-67414927d2a6@linaro.org> (raw)
In-Reply-To: <20230712112815.GA21004@varda-linux.qualcomm.com>
On 12/07/2023 13:28, Varadarajan Narayanan wrote:
>>> +
>>> + usb2: usb2@8a00000 {
>>
>> It does not look like you tested the DTS against bindings. Please run
>> `make dtbs_check` (see
>> Documentation/devicetree/bindings/writing-schema.rst or
>> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
>> for instructions).
>
> 'make dtbs_check' passed. The '2' in 'usb2' is to indicate USB v2.
> There is one more USB v3 controller in this SoC. Hence, to
> differentiate between the two used 'usb2'.
>
> Hope that is ok.
Nope, unfortunately it is not.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-12 12:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 8:51 [PATCH v3 0/6] Enable IPQ5332 USB2 Varadarajan Narayanan
2023-07-11 8:51 ` [PATCH v3 1/6] dt-bindings: usb: dwc3: Add IPQ5332 compatible Varadarajan Narayanan
2023-07-11 9:02 ` Krzysztof Kozlowski
2023-07-11 8:51 ` [PATCH v3 2/6] dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy Varadarajan Narayanan
2023-07-11 9:03 ` Krzysztof Kozlowski
2023-07-13 11:36 ` Krzysztof Kozlowski
2023-07-11 8:51 ` [PATCH v3 3/6] phy: qcom-m31: Introduce qcom,m31 USB phy driver Varadarajan Narayanan
2023-07-11 9:09 ` Krzysztof Kozlowski
2023-07-11 8:51 ` [PATCH v3 4/6] arm64: dts: qcom: ipq5332: Add USB related nodes Varadarajan Narayanan
2023-07-11 9:01 ` Krzysztof Kozlowski
2023-07-12 11:28 ` Varadarajan Narayanan
2023-07-12 12:02 ` Krzysztof Kozlowski [this message]
2023-07-11 8:51 ` [PATCH v3 5/6] arm64: dts: qcom: ipq5332: Enable USB Varadarajan Narayanan
2023-07-11 8:51 ` [PATCH v3 6/6] arm64: defconfig: Enable M31 USB phy driver Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08da796b-f1a9-19dc-cde6-67414927d2a6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nfraprado@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=quic_varada@quicinc.org \
--cc=quic_wcheng@quicinc.com \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).