From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B603524205 for ; Wed, 17 Jul 2024 08:09:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721203783; cv=none; b=DTm9Kne/Mhkuz3Uy2cJuHX0JRrnEJXwAlMoyWAqQV0VulVHdgM5gqc5vk2+e/WAEFJthL8+2B35Vf2mTAcZi1c2AJsbU0qzNJdJb5dfeBUwU3v8YAEFx4JgXWwiN6MdsBmhLIsZ+x+ZRpnPL2GMwds3KvjvkSCBSjef7Q0yq7Y0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721203783; c=relaxed/simple; bh=3lpgL8JX6lclcl5bOHVHY4a3EyinEV2YVq/V1EYlI3g=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=Zs2Z0+O/hh89PkvDY8GnTJ6doYFZTWWZAq3BrvDZxKLBvfkVvlXcp+eOIyPPIK0VPNIE8zEw9DsX8YVSOHjJ1tkwBwLwkcADa9YEw2mmMY8u2yTChYBkabA57nIEKP7GYrBrocQxps1n6j+WVWxpZfiXLwglpYIZ8aAMKpZsMOA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Bfk5/whl; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Bfk5/whl" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4279ca8af51so41162895e9.3 for ; Wed, 17 Jul 2024 01:09:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721203780; x=1721808580; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=mEk9j3PxQi/U6Kj2C9qYjTRpguq4a9W1RY82vlez4mk=; b=Bfk5/whl9n9T+dgbx7qIglPyGHb5qmK0Q6SE8N8/xAYNWogdf+O7SK9r0aoHNaXlDe uuSddojbrl4JpDboZlckZTxe8XCoX5wkKMZMPyHVRGhltZxmRJ65fSi0tYGf7WL5ntCy NgjJFzjoed+TzKRPDcREFXz20h+6H1nRgwi+XDJe4ImaZoz2u8qgx+ZuaxNMVzAREMWD xfWPYok5nEVMddbDdq71WXIJXBN7TMDbBbj5F1Wl1PWnVVJeSFdAZtCyLl74b0dR/W42 oW2Y8Ke6DD9Ap8q71evw2ngfJhBOT12bCDgebnRSJxsB3sHl5KhXgI7zCVdoZSd8PDgr xMEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721203780; x=1721808580; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mEk9j3PxQi/U6Kj2C9qYjTRpguq4a9W1RY82vlez4mk=; b=XU38Xyq3V45mweWRAtHwRVssgbDgP2QLFRxsN54TykJzWtlKYFL6fjrCEZSb1t8KQY thDfBYwmYexykS7QDp84ajXDSxXFlfbB8lGYPjTacbdgFXba7ydGzlMsR6wR+rfHyvH0 lqNYbqTtoc2Hr3FJOhe/tY1xy/JxDsHQN8yB+TFaOKoYG2TA9E5FnjnM/pq7oW/4ji9R y1V+jNpgSWcnLnGN5W+NTJjB/qhLcok9MnvnnOtW+cT7aaVHmVJAgIfCc6PihA+y/4tI 54DhjYP4hr+c4hvtXKT0AB9xZAcwCUGHB1pDUlDNg1VZ6nvKkfc6leKytO+XtpdjJ+PZ I7+g== X-Forwarded-Encrypted: i=1; AJvYcCX3edxDWVBOvhdf1sqX6Zqgbfy96rEtvlO8FEAK+aHDthaWObdrfcCkHE88c4afcSVFu+YV0IM3At/7awtNq4CzY/IodYNAhJ78Aw== X-Gm-Message-State: AOJu0Yy/H3xy4a1fe58i+L9fd4pNZkjjemhY+LkeHmZPtmqkDEYBUUp9 9OPN6PvNqGYL4/hbSW6G6gixi4zlvQ7gu8jK1ikL/40cro5Qev9hzb3W6SmMVSE= X-Google-Smtp-Source: AGHT+IHt+gwZdzXzE8FBVvFbVFGzMeHqi3Jxcv2Sr7SCgDhwWr+SbRFe7FpOiAtmmq2gX67RFTqfEw== X-Received: by 2002:a05:600c:1c21:b0:426:5d0d:a2c9 with SMTP id 5b1f17b1804b1-427c2cd36d1mr6173605e9.10.1721203780186; Wed, 17 Jul 2024 01:09:40 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:c5b9:9b90:b1c4:1a1d? ([2a01:e0a:982:cbb0:c5b9:9b90:b1c4:1a1d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4279f25a957sm193359715e9.13.2024.07.17.01.09.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jul 2024 01:09:39 -0700 (PDT) Message-ID: <08e0945c-1c52-4f95-af6b-0e0b9b28b30d@linaro.org> Date: Wed, 17 Jul 2024 10:09:38 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 5/7] clk: qcom: dispcc-sm8550: use rcg2_shared_ops for ESC RCGs To: Dmitry Baryshkov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20240717-dispcc-sm8550-fixes-v1-0-efb4d927dc9a@linaro.org> <20240717-dispcc-sm8550-fixes-v1-5-efb4d927dc9a@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20240717-dispcc-sm8550-fixes-v1-5-efb4d927dc9a@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 16/07/2024 23:13, Dmitry Baryshkov wrote: > Follow the recommendations and park disp_cc_mdss_esc[01]_clk_src to the > XO instead of disabling the clocks by using the clk_rcg2_shared_ops. > > Fixes: 90114ca11476 ("clk: qcom: add SM8550 DISPCC driver") > Signed-off-by: Dmitry Baryshkov > --- > drivers/clk/qcom/dispcc-sm8550.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/qcom/dispcc-sm8550.c b/drivers/clk/qcom/dispcc-sm8550.c > index 49dff9b81fa1..a476be3403ba 100644 > --- a/drivers/clk/qcom/dispcc-sm8550.c > +++ b/drivers/clk/qcom/dispcc-sm8550.c > @@ -562,7 +562,7 @@ static struct clk_rcg2 disp_cc_mdss_esc0_clk_src = { > .parent_data = disp_cc_parent_data_5, > .num_parents = ARRAY_SIZE(disp_cc_parent_data_5), > .flags = CLK_SET_RATE_PARENT, > - .ops = &clk_rcg2_ops, > + .ops = &clk_rcg2_shared_ops, > }, > }; > > @@ -577,7 +577,7 @@ static struct clk_rcg2 disp_cc_mdss_esc1_clk_src = { > .parent_data = disp_cc_parent_data_5, > .num_parents = ARRAY_SIZE(disp_cc_parent_data_5), > .flags = CLK_SET_RATE_PARENT, > - .ops = &clk_rcg2_ops, > + .ops = &clk_rcg2_shared_ops, > }, > }; > > Reviewed-by: Neil Armstrong