From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Cercueil Subject: Re: [PATCH v2 01/14] Documentation: dt/bindings: Document pinctrl-ingenic Date: Fri, 27 Jan 2017 16:27:56 +0100 Message-ID: <08e9505d2d366557950f8e6a4e81f57a@mail.crapouillou.net> References: <27071da2f01d48141e8ac3dfaa13255d@mail.crapouillou.net> <20170122144947.16158-1-paul@crapouillou.net> <20170122144947.16158-2-paul@crapouillou.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Linus Walleij Cc: Rob Herring , Mark Rutland , Ralf Baechle , Ulf Hansson , Boris Brezillon , Thierry Reding , Bartlomiej Zolnierkiewicz , Maarten ter Huurne , Lars-Peter Clausen , Paul Burton , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Linux MIPS , linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, James Hogan List-Id: devicetree@vger.kernel.org Hi, > So I still don't understand these properties. > > Does this mean that there is a pull-up *inside* the SoC or *outside* > on the board where it is mounted? The pull-up resistors are inside the SoCs. > In the former case, if this pertains to the *inside* of the SoC: > is it just different between jz4740 and jz4780? > In that case, just code this into the driver as .data to the > .compatible > in the DT match. No special DT properties needed. Well, I've been taught that devicetree is for describing the hardware, and the driver code is for functionality. So that's why I put it in devicetree. That's also the reason why I put the list of functions and groups in devicetree and not in the driver code. > Standard bindings use just "pins". Why the custom ingenic, > prefix? I can change that. Regards, -Paul