From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lelvem-ot02.ext.ti.com (lelvem-ot02.ext.ti.com [198.47.23.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07BDC130A73; Fri, 15 Aug 2025 13:50:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.23.235 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755265843; cv=none; b=e1CQSXkdVqzabsaPU+awyxKqCFTJCJ6xc81gbzPiYDfojRsrdCZaBi/DPvmS9EHkPKX3t9VZv7WZcKkeCme7W8LfB1uXSjg3lLLvPk02liPuFF+9KVIm08IGZZZqfrs0LJQn/Xel0GndaIUhdNHXM86x9T7ahmQqQU+SUQIxYCI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755265843; c=relaxed/simple; bh=ZtjHngrc92zWlZz4apSIcZ+8KqwiOJtKZ+ei2GD/8+M=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=Uj6WqjMdjguf3vnqRbEkPJuRPd3fiDTT/W/tcvvJHTC+I8kTx5CVaNjPjw08ZEEJ091/VruuCJxcaNf32Fbr/EjCq/wWZUXmG5vSs4TAcXZl9Caiv9rLNrCKksTa7PBq+Z923txeQgJhi7wSrpHbJnuYaQsU7XtcAmAJloGbQEQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=FjliZxpE; arc=none smtp.client-ip=198.47.23.235 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="FjliZxpE" Received: from fllvem-sh04.itg.ti.com ([10.64.41.54]) by lelvem-ot02.ext.ti.com (8.15.2/8.15.2) with ESMTP id 57FDoXoC2615996; Fri, 15 Aug 2025 08:50:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1755265833; bh=7XQhf8b1lSnCYAFBATVY+THATyFGfb93E2LT2ShyR6U=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=FjliZxpEpSzKZBd2AQNXUeOJDfoHUMOUz55e1aa2zNi1Wp+6QEhy1oh68w4TCac8B Q5UeXBPq6yeA+hzaNjszbvPszkjiAcqHq+LLqCntAjJN2p4zco9PWa1qoOiqwLne9O DUCsJzg62jVtPk0Rg8iUa/HhrnOdKTFDNeJvqf3Q= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by fllvem-sh04.itg.ti.com (8.18.1/8.18.1) with ESMTPS id 57FDoXLn2629259 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=FAIL); Fri, 15 Aug 2025 08:50:33 -0500 Received: from DLEE113.ent.ti.com (157.170.170.24) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55; Fri, 15 Aug 2025 08:50:32 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55 via Frontend Transport; Fri, 15 Aug 2025 08:50:32 -0500 Received: from [10.249.42.149] ([10.249.42.149]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 57FDoWno1371580; Fri, 15 Aug 2025 08:50:32 -0500 Message-ID: <08eec1de-1c92-44ce-8caa-2dc43a67c514@ti.com> Date: Fri, 15 Aug 2025 08:50:32 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 2/4] drm/bridge: it66121: Drop ftrace like dev_dbg() prints To: Nishanth Menon , Conor Dooley , Krzysztof Kozlowski , Rob Herring , David Airlie , Maxime Ripard , Laurent Pinchart , Neil Armstrong CC: , , , Robert Nelson , Jason Kridner , , References: <20250815034105.1276548-1-nm@ti.com> <20250815034105.1276548-3-nm@ti.com> Content-Language: en-US From: Andrew Davis In-Reply-To: <20250815034105.1276548-3-nm@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea On 8/14/25 10:41 PM, Nishanth Menon wrote: > Drop the ftrace like dev_dbg() that checkpatch --strict complains about: > > WARNING: Unnecessary ftrace-like logging - prefer using ftrace > + dev_dbg(dev, "%s\n", __func__); > > WARNING: Unnecessary ftrace-like logging - prefer using ftrace > + dev_dbg(dev, "%s\n", __func__); > > WARNING: Unnecessary ftrace-like logging - prefer using ftrace > + dev_dbg(dev, "%s\n", __func__); > > Signed-off-by: Nishanth Menon > --- Reviewed-by: Andrew Davis > Changes in V3: > * New patch > > drivers/gpu/drm/bridge/ite-it66121.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c > index aa7b1dcc5d70..9b8ed2fae2f4 100644 > --- a/drivers/gpu/drm/bridge/ite-it66121.c > +++ b/drivers/gpu/drm/bridge/ite-it66121.c > @@ -1384,8 +1384,6 @@ static int it66121_audio_startup(struct device *dev, void *data) > int ret; > struct it66121_ctx *ctx = dev_get_drvdata(dev); > > - dev_dbg(dev, "%s\n", __func__); > - > mutex_lock(&ctx->lock); > ret = it661221_audio_output_enable(ctx, true); > if (ret) > @@ -1401,8 +1399,6 @@ static void it66121_audio_shutdown(struct device *dev, void *data) > int ret; > struct it66121_ctx *ctx = dev_get_drvdata(dev); > > - dev_dbg(dev, "%s\n", __func__); > - > mutex_lock(&ctx->lock); > ret = it661221_audio_output_enable(ctx, false); > if (ret) > @@ -1479,8 +1475,6 @@ static int it66121_audio_codec_init(struct it66121_ctx *ctx, struct device *dev) > .no_capture_mute = 1, > }; > > - dev_dbg(dev, "%s\n", __func__); > - > if (!of_property_present(dev->of_node, "#sound-dai-cells")) { > dev_info(dev, "No \"#sound-dai-cells\", no audio\n"); > return 0;