From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jameson Thies <jthies@google.com>,
tzungbi@kernel.org, ukaszb@chromium.org, bleung@chromium.org,
heikki.krogerus@linux.intel.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, groeck@chromium.org,
swboyd@chromium.org, akuchynski@chromium.org
Cc: devicetree@vger.kernel.org, chrome-platform@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v1 3/3] mfd: cros_ec: Don't add cros_ec_ucsi if it is defined in OF or ACPI
Date: Thu, 13 Mar 2025 08:46:15 +0100 [thread overview]
Message-ID: <090bbaee-88e0-42fa-b43d-db80ec065d35@linaro.org> (raw)
In-Reply-To: <52e592c5-7f97-4b7b-bcf1-1bca34c716e1@linaro.org>
On 13/03/2025 08:11, Krzysztof Kozlowski wrote:
> On 12/03/2025 20:59, Jameson Thies wrote:
>> Check for cros_ec_ucsi to be defined in the OF device tree or an ACPI
>> node. If it is defined by either OF or ACPI, it does not need to be
>> added as a subdevice of cros_ec_dev.
>
> No, it does not have to. You just populate the children and appropriate
Uh, I did not notice that it is !of_find_compatible_node(), so this
comment should be rephrased - you just add MFD children anyway and if
there is no node, they won't be created.
> devices will be created automatically. None of parent devices should
> ever check if the child exist to create a child - it makes no sense.
This is still valid - none of parents should be poking around to see if
there is a child or not. The core handles it, DT handles it etc.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-13 7:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 19:59 [PATCH v1 0/3] Load cros_ec_ucsi from OF and ACPI definitions Jameson Thies
2025-03-12 19:59 ` [PATCH v1 1/3] dt-bindings: Add cros-ec-ucsi to cros-ec-typec device tree documentation Jameson Thies
2025-03-13 7:10 ` Krzysztof Kozlowski
2025-03-13 7:13 ` Krzysztof Kozlowski
2025-03-13 23:23 ` Jameson Thies
2025-03-12 19:59 ` [PATCH v1 2/3] usb: typec: cros_ec_ucsi: Load driver from OF and ACPI definitions Jameson Thies
2025-03-12 19:59 ` [PATCH v1 3/3] mfd: cros_ec: Don't add cros_ec_ucsi if it is defined in OF or ACPI Jameson Thies
2025-03-13 7:11 ` Krzysztof Kozlowski
2025-03-13 7:46 ` Krzysztof Kozlowski [this message]
2025-03-13 14:53 ` kernel test robot
2025-03-13 16:07 ` kernel test robot
2025-03-13 23:29 ` Jameson Thies
-- strict thread matches above, loose matches on Subject: below --
2025-09-30 1:23 [PATCH v1 0/3] Load cros_ec_ucsi from OF and ACPI definitions Jameson Thies
2025-09-30 1:23 ` [PATCH v1 3/3] mfd: cros_ec: Don't add cros_ec_ucsi if it is defined in OF or ACPI Jameson Thies
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=090bbaee-88e0-42fa-b43d-db80ec065d35@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=akuchynski@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jthies@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=tzungbi@kernel.org \
--cc=ukaszb@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).