From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tapio Reijonen <tapio.reijonen@vaisala.com>
Cc: Peter Rosin <peda@axentia.se>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: mux: Add description for enable GPIO
Date: Thu, 6 Nov 2025 13:18:48 +0100 [thread overview]
Message-ID: <09148e20-03e9-44fb-a45c-3038909cde06@kernel.org> (raw)
In-Reply-To: <62a77b8c-6721-45b3-878a-f90f859bfbfe@vaisala.com>
On 06/11/2025 12:55, Tapio Reijonen wrote:
> Hi,
>
> On 11/6/25 11:08, Krzysztof Kozlowski wrote:
>> On Wed, Nov 05, 2025 at 02:49:12PM +0000, Tapio Reijonen wrote:
>>> Add description for enabling GPIO-controlled multiplexer
>>> GPIO pins, according to the state of the mux idle state.
>>
>> You basically repeated binding. Please explain here which GPIO this is,
>> e.g. give concrete device example.
>>
> Here is the example:
> mux: mux-controller {
> compatible = "gpio-mux";
> #mux-control-cells = <0>;
>
> mux-gpios =
> <&gpio4 22 GPIO_ACTIVE_HIGH>,
> <&gpio2 18 GPIO_ACTIVE_HIGH>,
> <&gpio2 13 GPIO_ACTIVE_HIGH>,
> <&gpio2 17 GPIO_ACTIVE_HIGH>;
> idle-state = <MUX_IDLE_DISCONNECT>;
> /* BUS_EN */
> enable-gpios = <&gpio4 27 GPIO_ACTIVE_LOW>;
I meant real device, so I can look at datasheet and understand how/why
you do it. This also is supposed to be in the commit msg.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-06 12:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 14:49 [PATCH 0/2] mux: gpio: Add external mux enable gpio Tapio Reijonen
2025-11-05 14:49 ` [PATCH 1/2] dt-bindings: mux: Add description for enable GPIO Tapio Reijonen
2025-11-06 9:08 ` Krzysztof Kozlowski
2025-11-06 11:55 ` Tapio Reijonen
2025-11-06 12:18 ` Krzysztof Kozlowski [this message]
2025-11-05 14:49 ` [PATCH 2/2] mux: gpio: Add external mux enable gpio Tapio Reijonen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09148e20-03e9-44fb-a45c-3038909cde06@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
--cc=tapio.reijonen@vaisala.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).