From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Yan <andyshrk@163.com>, heiko@sntech.de
Cc: hjc@rock-chips.com, dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, sebastian.reichel@collabora.com,
kever.yang@rock-chips.com, chris.obbard@collabora.com,
Andy Yan <andy.yan@rock-chips.com>
Subject: Re: [PATCH v4 10/17] dt-bindings: display: vop2: Add rk3588 support
Date: Fri, 8 Dec 2023 18:46:42 +0100 [thread overview]
Message-ID: <0915b94c-596e-4a19-925c-1a5b1d0a3531@linaro.org> (raw)
In-Reply-To: <20231207080133.652417-1-andyshrk@163.com>
On 07/12/2023 09:01, Andy Yan wrote:
> From: Andy Yan <andy.yan@rock-chips.com>
>
> The vop2 on rk3588 is similar to which on rk356x
> but with 4 video ports and need to reference
> more grf modules.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>
> ---
>
> Changes in v4:
> - drop redundant description.
> - use full stop at all the description's end.
> - address Krzysztof's review in v3
What changed? Please list specific changes, not just generic "address
review".
>
> Changes in v3:
> - constrain properties in allOf:if:then
> - some description updates
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.
https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-08 17:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 7:59 [PATCH v4 00/17] Add VOP2 support on rk3588 Andy Yan
2023-12-07 7:59 ` [PATCH v4 01/17] drm/rockchip: move output interface related definition to rockchip_drm_drv.h Andy Yan
2023-12-07 7:59 ` [PATCH v4 02/17] Revert "drm/rockchip: vop2: Use regcache_sync() to fix suspend/resume" Andy Yan
2023-12-07 8:00 ` [PATCH v4 03/17] drm/rockchip: vop2: set half_block_en bit in all mode Andy Yan
2023-12-07 8:00 ` [PATCH v4 04/17] drm/rockchip: vop2: clear afbc en and transform bit for cluster window at linear mode Andy Yan
2023-12-07 8:00 ` [PATCH v4 05/17] drm/rockchip: vop2: Add write mask for VP config done Andy Yan
2023-12-07 8:00 ` [PATCH v4 06/17] drm/rockchip: vop2: Set YUV/RGB overlay mode Andy Yan
2023-12-07 8:00 ` [PATCH v4 07/17] drm/rockchip: vop2: set bg dly and prescan dly at vop2_post_config Andy Yan
2023-12-07 8:01 ` [PATCH v4 08/17] drm/rockchip: vop2: rename grf to sys_grf Andy Yan
2023-12-07 8:01 ` [PATCH v4 09/17] dt-bindings: soc: rockchip: add rk3588 vop/vo syscon Andy Yan
2023-12-07 8:01 ` [PATCH v4 10/17] dt-bindings: display: vop2: Add rk3588 support Andy Yan
2023-12-08 17:46 ` Krzysztof Kozlowski [this message]
2023-12-09 1:30 ` Andy Yan
2023-12-07 8:01 ` [PATCH v4 11/17] dt-bindings: rockchip,vop2: Add more endpoint definition Andy Yan
2023-12-07 8:01 ` [PATCH v4 12/17] drm/rockchip: vop2: Add support for rk3588 Andy Yan
2023-12-07 8:02 ` [PATCH v4 13/17] drm/rockchip: vop2: rename VOP_FEATURE_OUTPUT_10BIT to VOP2_VP_FEATURE_OUTPUT_10BIT Andy Yan
2023-12-11 7:02 ` Sascha Hauer
2023-12-07 8:02 ` [PATCH v4 14/17] drm/rockchip: vop2: Add debugfs support Andy Yan
2023-12-11 6:59 ` Sascha Hauer
2023-12-07 8:02 ` [PATCH v4 15/17] dt-bindings: iommu: rockchip: Add Rockchip RK3588 Andy Yan
2023-12-08 16:29 ` Heiko Stübner
2023-12-09 1:26 ` Andy Yan
2023-12-09 14:04 ` Heiko Stübner
2023-12-08 17:47 ` Krzysztof Kozlowski
2023-12-07 8:02 ` [PATCH v4 16/17] arm64: dts: rockchip: Add vop on rk3588 Andy Yan
2023-12-08 16:26 ` Heiko Stübner
2023-12-09 1:28 ` Andy Yan
2023-12-07 8:03 ` [PATCH v4 17/17] MAINTAINERS: Add myself as a reviewer for rockchip drm Andy Yan
2023-12-08 16:07 ` [PATCH v4 00/17] Add VOP2 support on rk3588 Heiko Stübner
2023-12-09 1:21 ` Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0915b94c-596e-4a19-925c-1a5b1d0a3531@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andy.yan@rock-chips.com \
--cc=andyshrk@163.com \
--cc=chris.obbard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).