Re: [PATCH v4 12/16] device property: Move dev_fwnode() to linux/property.h

[Sakari Ailus <sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>]

Hi Rafael,

On 03/13/17 23:49, Rafael J. Wysocki wrote:
> On Monday, March 06, 2017 04:19:26 PM Sakari Ailus wrote:
>> The function to obtain a fwnode related to a struct device is useful for
>> drivers that use the fwnode property API: it allows not being aware of the
>> underlying firmware implementation.
>>
>> Signed-off-by: Sakari Ailus <sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
>> ---
>>  drivers/base/property.c  |  6 ------
>>  include/linux/property.h | 10 ++++++++--
>>  2 files changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/base/property.c b/drivers/base/property.c
>> index 111049b..860e160 100644
>> --- a/drivers/base/property.c
>> +++ b/drivers/base/property.c
>> @@ -183,12 +183,6 @@ static int pset_prop_read_string(struct property_set *pset,
>>  	return 0;
>>  }
>>  
>> -static inline struct fwnode_handle *dev_fwnode(struct device *dev)
>> -{
>> -	return IS_ENABLED(CONFIG_OF) && dev->of_node ?
>> -		&dev->of_node->fwnode : dev->fwnode;
>> -}
> 
> What about making it non-inline instead?
> 
>> -
>>  /**
>>   * device_property_present - check if a property of a device is present
>>   * @dev: Device whose property is being checked
>> diff --git a/include/linux/property.h b/include/linux/property.h
>> index 0ae7d20..0b61ea4 100644
>> --- a/include/linux/property.h
>> +++ b/include/linux/property.h
>> @@ -13,11 +13,11 @@
>>  #ifndef _LINUX_PROPERTY_H_
>>  #define _LINUX_PROPERTY_H_
>>  
>> +#include <linux/device.h>
>>  #include <linux/fwnode.h>
>> +#include <linux/of.h>
>>  #include <linux/types.h>
> 
> You would not need to add the above includes here then.

Makes sense. I'll change it.

-- 
Regards,

Sakari Ailus
sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html