From: Krzysztof Kozlowski <krzk@kernel.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>, wim@linux-watchdog.org
Cc: linux@roeck-us.net, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org, S32@nxp.com,
ghennadi.procopciuc@nxp.com, thomas.fossati@linaro.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: watchdog: Add NXP Software Watchdog Timer
Date: Tue, 8 Apr 2025 10:21:49 +0200 [thread overview]
Message-ID: <094855d6-a99b-4ca5-bc8f-ab6faccfd332@kernel.org> (raw)
In-Reply-To: <20250407160318.936142-2-daniel.lezcano@linaro.org>
On 07/04/2025 18:03, Daniel Lezcano wrote:
> +
> +allOf:
> + - $ref: watchdog.yaml#
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: nxp,s32g2-swt
> + - items:
> + - const: nxp,s32g3-swt
> + - const: nxp,s32g2-swt
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: Counter clock
> + - description: Module clock
> + - description: Register clock
> + minItems: 1
Why clocks are flexible? The SoC does not change between boards. It
should be a fixed list - block receives that number of clocks or does
not... unless you meant that different instances of the block have
different clocks?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-04-08 8:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 16:03 [PATCH v3 0/2] Add the NXP S32 Watchdog Daniel Lezcano
2025-04-07 16:03 ` [PATCH v3 1/2] dt-bindings: watchdog: Add NXP Software Watchdog Timer Daniel Lezcano
2025-04-08 8:21 ` Krzysztof Kozlowski [this message]
2025-04-08 9:03 ` Daniel Lezcano
2025-04-08 9:39 ` Krzysztof Kozlowski
2025-04-08 10:30 ` Ghennadi Procopciuc
2025-04-07 16:03 ` [PATCH v3 2/2] watchdog: Add the Watchdog Timer for the NXP S32 platform Daniel Lezcano
2025-04-08 7:25 ` Alexandru-Catalin Ionita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=094855d6-a99b-4ca5-bc8f-ab6faccfd332@kernel.org \
--to=krzk@kernel.org \
--cc=S32@nxp.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ghennadi.procopciuc@nxp.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=thomas.fossati@linaro.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).