[PATCH 1/3] dt-bindings: arm: rockchip: Add Radxa ROCK Pi E v3.0

[PATCH 1/3] dt-bindings: arm: rockchip: Add Radxa ROCK Pi E v3.0

[FUKAUMI Naoki]

Add devicetree binding for the Radxa ROCK Pi E v3.0 board.

Radxa ROCK Pi E v3.0 is a single-board computer based on the Rockchip
RK3328 SoC with a compact form factor.

Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index eca0a42eb384..53ca61c47b76 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -779,6 +779,11 @@ properties:
           - const: radxa,rockpi-e
           - const: rockchip,rk3328
 
+      - description: Radxa ROCK Pi E v3.0
+        items:
+          - const: radxa,rockpi-e-v3
+          - const: rockchip,rk3328
+
       - description: Radxa ROCK Pi N8
         items:
           - const: radxa,rockpi-n8
-- 
2.43.0

[PATCH 2/3] arm64: dts: rockchip: prepare common .dtsi for Radxa ROCK Pi E

[FUKAUMI Naoki]

Radxa ROCK Pi E v1.2x and ROCK Pi E v3.0 share most of their parts.
prepare rk3328-rock-pi-e-base.dtsi as a common dtsi for both boards.

Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 .../{rk3328-rock-pi-e.dts => rk3328-rock-pi-e-base.dtsi}       | 3 ---
 1 file changed, 3 deletions(-)
 rename arch/arm64/boot/dts/rockchip/{rk3328-rock-pi-e.dts => rk3328-rock-pi-e-base.dtsi} (99%)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e-base.dtsi
similarity index 99%
rename from arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts
rename to arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e-base.dtsi
index a608a219543e..b2c5089ad2f8 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e-base.dtsi
@@ -17,9 +17,6 @@
 #include "rk3328.dtsi"
 
 / {
-	model = "Radxa ROCK Pi E";
-	compatible = "radxa,rockpi-e", "rockchip,rk3328";
-
 	aliases {
 		ethernet0 = &gmac2io;
 		ethernet1 = &gmac2phy;
-- 
2.43.0

[PATCH 3/3] arm64: dts: rockchip: add support for Radxa ROCK Pi E v3.0

[FUKAUMI Naoki]

ROCK Pi E v3.0 is newer version of ROCK Pi E v1.2x. Changes are

- Upgrade DDR3 to DDR4
- Elevate eMMC connector to onboard eMMC
- Update silkscreen to ROCK PI E V3.0

Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e-v3.dts | 10 ++++++++++
 arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts    | 10 ++++++++++
 2 files changed, 20 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e-v3.dts
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts

diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e-v3.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e-v3.dts
new file mode 100644
index 000000000000..be369dace843
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e-v3.dts
@@ -0,0 +1,10 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
+/dts-v1/;
+
+#include "rk3328-rock-pi-e-base.dtsi"
+
+/ {
+	model = "Radxa ROCK Pi E v3.0";
+	compatible = "radxa,rockpi-e-v3", "rockchip,rk3328";
+};
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts
new file mode 100644
index 000000000000..bdb2ca1a225f
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts
@@ -0,0 +1,10 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
+/dts-v1/;
+
+#include "rk3328-rock-pi-e-base.dtsi"
+
+/ {
+	model = "Radxa ROCK Pi E";
+	compatible = "radxa,rockpi-e", "rockchip,rk3328";
+};
-- 
2.43.0

Re: [PATCH 1/3] dt-bindings: arm: rockchip: Add Radxa ROCK Pi E v3.0

[Krzysztof Kozlowski]

On 23/06/2024 14:00, FUKAUMI Naoki wrote:
> Add devicetree binding for the Radxa ROCK Pi E v3.0 board.
> 
> Radxa ROCK Pi E v3.0 is a single-board computer based on the Rockchip
> RK3328 SoC with a compact form factor.
> 
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>

Isn't this v2 of something? What changed here? Provide detailed
changelog per each patch (see submitting patches).

Best regards,
Krzysztof

Re: [PATCH 2/3] arm64: dts: rockchip: prepare common .dtsi for Radxa ROCK Pi E

[Krzysztof Kozlowski]

On 23/06/2024 14:00, FUKAUMI Naoki wrote:
> Radxa ROCK Pi E v1.2x and ROCK Pi E v3.0 share most of their parts.
> prepare rk3328-rock-pi-e-base.dtsi as a common dtsi for both boards.
> 
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
>  .../{rk3328-rock-pi-e.dts => rk3328-rock-pi-e-base.dtsi}       | 3 ---
>  1 file changed, 3 deletions(-)
>  rename arch/arm64/boot/dts/rockchip/{rk3328-rock-pi-e.dts => rk3328-rock-pi-e-base.dtsi} (99%)

This breaks users and is not bisectable.

Best regards,
Krzysztof

Re: [PATCH 3/3] arm64: dts: rockchip: add support for Radxa ROCK Pi E v3.0

[Krzysztof Kozlowski]

On 23/06/2024 14:00, FUKAUMI Naoki wrote:
> ROCK Pi E v3.0 is newer version of ROCK Pi E v1.2x. Changes are
> 
> - Upgrade DDR3 to DDR4
> - Elevate eMMC connector to onboard eMMC
> - Update silkscreen to ROCK PI E V3.0
> 
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e-v3.dts | 10 ++++++++++
>  arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts    | 10 ++++++++++
>  2 files changed, 20 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e-v3.dts
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts

And how did you test it if you cannot build it?

Best regards,
Krzysztof

Re: [PATCH 1/3] dt-bindings: arm: rockchip: Add Radxa ROCK Pi E v3.0

[FUKAUMI Naoki]

Hi

On 6/23/24 21:08, Krzysztof Kozlowski wrote:
> On 23/06/2024 14:00, FUKAUMI Naoki wrote:
>> Add devicetree binding for the Radxa ROCK Pi E v3.0 board.
>>
>> Radxa ROCK Pi E v3.0 is a single-board computer based on the Rockchip
>> RK3328 SoC with a compact form factor.
>>
>> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> 
> Isn't this v2 of something? What changed here? Provide detailed
> changelog per each patch (see submitting patches).

this patch set are for adding new board.
please discard previous patch set.

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

> Best regards,
> Krzysztof
> 
>