From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74050C433EF for ; Wed, 6 Jul 2022 04:00:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231461AbiGFEAh (ORCPT ); Wed, 6 Jul 2022 00:00:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229886AbiGFEAh (ORCPT ); Wed, 6 Jul 2022 00:00:37 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 366DE1EC49; Tue, 5 Jul 2022 21:00:36 -0700 (PDT) X-UUID: 8224a56f7ac941aea686f9d1fc71e754-20220706 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.8,REQID:8881b9bc-26f8-4fdc-b3f5-1f3a4d6d52a9,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:0f94e32,CLOUDID:c2b5a886-57f0-47ca-ba27-fe8c57fbf305,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:nil,BEC:nil,COL:0 X-UUID: 8224a56f7ac941aea686f9d1fc71e754-20220706 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 505661595; Wed, 06 Jul 2022 12:00:30 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs11n2.mediatek.inc (172.21.101.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Wed, 6 Jul 2022 12:00:28 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Wed, 6 Jul 2022 12:00:28 +0800 Message-ID: <098f43e5033c42e9dd44d61d4a505f6870a7a8b0.camel@mediatek.com> Subject: Re: [PATCH v1 04/16] arm64: dts: mt8195: Disable watchdog external reset signal From: Tinghan Shen To: AngeloGioacchino Del Regno , Yong Wu , Joerg Roedel , Will Deacon , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Chun-Jie Chen , "Weiyi Lu" CC: , , , , , , Fengquan Chen Date: Wed, 6 Jul 2022 12:00:28 +0800 In-Reply-To: References: <20220704100028.19932-1-tinghan.shen@mediatek.com> <20220704100028.19932-5-tinghan.shen@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 2022-07-04 at 12:30 +0200, AngeloGioacchino Del Regno wrote: > Il 04/07/22 12:00, Tinghan Shen ha scritto: > > Disable external output reset signal in first round of watchdog reset > > to reserve wdt reset reason for debugging watchdog issue. > > If my understanding of the commit decription is right, then we can clarify > that with something like: "[...] for debugging eventual watchdog issues". > > Otherwise, if this implies that disable-extrst is needed to avoid losing > the reset reason stored in the WDT, you could say something like: > > "Disable external output reset signal in the first round of watchdog reset > to avoid losing the reset reason stored in the watchdog registers" > > After which: > > Reviewed-by: AngeloGioacchino Del Regno > Ok, I'll update it in next version. Thanks, TingHan