From: Lucas Tanure <tanure@linux.com>
To: Xianwei Zhao <xianwei.zhao@amlogic.com>,
neil.armstrong@linaro.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>
Subject: Re: [PATCH V2 6/6] arm64: dts: add support for T7 power domain controller
Date: Sat, 26 Aug 2023 18:59:33 +0100 [thread overview]
Message-ID: <099b2b17-b236-4fd5-89a7-8ecbfbc9c323@linux.com> (raw)
In-Reply-To: <56c0b78a-b9dd-de6d-7d7e-654fc5dd8e1b@amlogic.com>
On 24-08-2023 09:51, Xianwei Zhao wrote:
> Hi Neil,
> Thanks for your reply.
>
> On 2023/8/24 16:32, Neil Armstrong wrote:
>> [ EXTERNAL EMAIL ]
>>
>> On 24/08/2023 07:59, Xianwei Zhao wrote:
>>> From: "xianwei.zhao" <xianwei.zhao@amlogic.com>
>>>
>>> Enable power domain controller for Amlogic T7 SoC
>>>
>>> Signed-off-by: xianwei.zhao <xianwei.zhao@amlogic.com>
>>> ---
>>> V1 -> V2: None
>>> ---
>>> arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>>> b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>>> index 1423d4a79156..23cdad1b425b 100644
>>> --- a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>>> @@ -4,6 +4,7 @@
>>> */
>>>
>>> #include <dt-bindings/interrupt-controller/arm-gic.h>
>>> +#include <dt-bindings/power/amlogic,t7-pwrc.h>
>>>
>>> / {
>>> interrupt-parent = <&gic>;
>>> @@ -118,6 +119,11 @@ psci {
>>>
>>> sm: secure-monitor {
>>> compatible = "amlogic,meson-gxbb-sm";
>>> +
>>> + pwrc: power-controller {
>>> + compatible = "amlogic,t7-pwrc";
>>> + #power-domain-cells = <1>;
>>> + };
>>> };
>>>
>>> soc {
>>
>> Please change the subject to:
>> arm64: dts: amlogic: t7: add power domain controller node
>>
> Will do.
>> With that:
>> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Tested with Vim4 and all works fine.
Tested-by: Lucas Tanure <tanure@linux.com>
next prev parent reply other threads:[~2023-08-26 18:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 5:59 [PATCH V2 0/6] Power: T7: add power domain driver Xianwei Zhao
[not found] ` <20230824055930.2576849-2-xianwei.zhao@amlogic.com>
2023-08-24 8:24 ` [PATCH V2 1/6] soc: amlogic: modify some power domains property Neil Armstrong
2023-08-24 8:32 ` Xianwei Zhao
[not found] ` <20230824055930.2576849-3-xianwei.zhao@amlogic.com>
2023-08-24 8:27 ` [PATCH V2 2/6] soc: amlogic: add driver to support power parent node Neil Armstrong
2023-08-24 8:42 ` Xianwei Zhao
[not found] ` <20230824055930.2576849-4-xianwei.zhao@amlogic.com>
2023-08-24 8:30 ` [PATCH V2 3/6] soc: amlogic: init power domain state Neil Armstrong
2023-08-24 8:46 ` Xianwei Zhao
[not found] ` <20230824055930.2576849-6-xianwei.zhao@amlogic.com>
2023-08-24 8:30 ` [PATCH V2 5/6] soc: amlogic: Add support for T7 power domains controller Neil Armstrong
2023-08-24 8:49 ` Xianwei Zhao
[not found] ` <20230824055930.2576849-7-xianwei.zhao@amlogic.com>
2023-08-24 8:32 ` [PATCH V2 6/6] arm64: dts: add support for T7 power domain controller Neil Armstrong
2023-08-24 8:51 ` Xianwei Zhao
2023-08-26 17:59 ` Lucas Tanure [this message]
[not found] ` <20230824055930.2576849-5-xianwei.zhao@amlogic.com>
2023-08-24 15:07 ` [PATCH V2 4/6] dt-bindings: power: add Amlogic T7 power domains Conor Dooley
2023-08-26 18:00 ` Lucas Tanure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=099b2b17-b236-4fd5-89a7-8ecbfbc9c323@linux.com \
--to=tanure@linux.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=xianwei.zhao@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).