From: Manikanta Maddireddy <mmaddireddy@nvidia.com>
To: Jon Hunter <jonathanh@nvidia.com>,
vkoul@kernel.org, kishon@kernel.org,
krzysztof.kozlowski+dt@linaro.org, thierry.reding@gmail.com,
vidyas@nvidia.com
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, bhelgaas@google.com,
lpieralisi@kernel.org, nkristam@nvidia.com
Subject: Re: [PATCH 2/3] arm64: tegra: Add uphy lane number and intr in p2u nodes
Date: Fri, 2 Dec 2022 10:44:55 +0530 [thread overview]
Message-ID: <099c5fab-3edc-71ba-ed65-2002ed2427fb@nvidia.com> (raw)
In-Reply-To: <1940f7ef-3119-59c6-0ddc-9498806766c9@nvidia.com>
On 12/1/2022 3:14 PM, Jon Hunter wrote:
>
> On 24/11/2022 08:35, Manikanta Maddireddy wrote:
>> UPHY lane number is required to exchange lane margin data between P2U
>> and UPHY. Add uphy lane number in p2u device tree nodes.
>>
>> Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
>> ---
>> arch/arm64/boot/dts/nvidia/tegra234.dtsi | 120 +++++++++++++++++++++++
>> 1 file changed, 120 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>> b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>> index eaf05ee9acd1..ec8a28a9d380 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>> +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>> @@ -1109,6 +1109,11 @@ p2u_hsio_0: phy@3e00000 {
>> reg = <0x03e00000 0x10000>;
>> reg-names = "ctl";
>> + interrupts = <0 336 0x04>;
>
>
> Please use definitions and don't hard-code the values apart from the
> interrupt number.
Ack, I will address in V2.
Thanks,
Manikanta
>
> Jon
>
next prev parent reply other threads:[~2022-12-02 5:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 8:35 [IP REVIEW PATCH 0/3] Add support for Lane Margining at Receiver Manikanta Maddireddy
2022-11-24 8:35 ` [PATCH 1/3] dt-bindings: PHY: P2U: Add PCIe lane margining support Manikanta Maddireddy
2022-11-24 8:45 ` Krzysztof Kozlowski
2022-11-30 15:11 ` Manikanta Maddireddy
2022-11-30 15:15 ` Krzysztof Kozlowski
2022-11-30 16:13 ` Manikanta Maddireddy
2022-11-24 8:35 ` [PATCH 2/3] arm64: tegra: Add uphy lane number and intr in p2u nodes Manikanta Maddireddy
2022-12-01 9:44 ` Jon Hunter
2022-12-02 5:14 ` Manikanta Maddireddy [this message]
2022-11-24 8:35 ` [PATCH 3/3] phy: tegra: Add lane margin support Manikanta Maddireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=099c5fab-3edc-71ba-ed65-2002ed2427fb@nvidia.com \
--to=mmaddireddy@nvidia.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=nkristam@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).