Re: [PATCH v1 1/9] drm/msm: Add compatibles for SM8350 display

[Dmitry Baryshkov <dmitry.baryshkov@linaro.org>]

On 28/10/2022 15:19, Dmitry Baryshkov wrote:
> On 28/10/2022 15:08, Robert Foss wrote:
>> Add compatible string for "qcom,sm8350-dpu" and
>> "qcom,sm8350-mdss".
>>
>> Signed-off-by: Robert Foss <robert.foss@linaro.org>
>> ---
>>   drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 1 +
>>   drivers/gpu/drm/msm/msm_mdss.c          | 1 +
>>   2 files changed, 2 insertions(+)
> 
> [skipped]
> 
>> diff --git a/drivers/gpu/drm/msm/msm_mdss.c 
>> b/drivers/gpu/drm/msm/msm_mdss.c
>> index e13c5c12b775..fd5a95cace16 100644
>> --- a/drivers/gpu/drm/msm/msm_mdss.c
>> +++ b/drivers/gpu/drm/msm/msm_mdss.c
>> @@ -447,6 +447,7 @@ static const struct of_device_id mdss_dt_match[] = {
>>       { .compatible = "qcom,sc8180x-mdss" },
>>       { .compatible = "qcom,sm8150-mdss" },
>>       { .compatible = "qcom,sm8250-mdss" },
>> +    { .compatible = "qcom,sm8350-mdss" },
>>       {}
>>   };
>>   MODULE_DEVICE_TABLE(of, mdss_dt_match);
> 
> 
> BTW: you probably also have to update the msm_mdss_enable() function 
> with the 8350-specific code.
> 

For mdss changes you can depend on [1], I plan to merge this patch in 
this window.

[1] https://patchwork.freedesktop.org/patch/489578/?series=105162&rev=1

Also with the mdss changes, it would be good to split this patch into 
dpu and mdss parts.

-- 
With best wishes
Dmitry